Re: RFR: 8134640 ( Left Insets Margin Test ) moved to open repo from closed [v2]

2022-05-03 Thread Tejesh R
> The Test had been updated to use all Supported Look and Feel in closed repo. > The same has been moved to open repo. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Copyright Year updated - Changes: - all: https://git.o

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v2]

2022-05-03 Thread Prasanta Sadhukhan
On Mon, 2 May 2022 03:21:25 GMT, Tejesh R wrote: >> In Button ToolTip, Mnemonic key string was shown only in Metal Look and >> Feel, since the feature is implemented in it. In other L&F especially >> Windows L&F the feature is not available. In order to make it available for >> other L&F's, th

Re: RFR: 8284680: sun.font.FontConfigManager.getFontConfig() leaks charset

2022-05-03 Thread Andrew John Hughes
On Thu, 28 Apr 2022 20:12:52 GMT, Zhengyu Gu wrote: > > > > Hmmm, you are right. Phil probably pointed out the same problem, but I > misunderstood it. > > What's odd is that, I tested (made sure that `FcCharSetDestroy` indeed > called), it did not crash and `valgrind` showed the leak site di

Re: RFR: 8284888 : [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same."

2022-05-03 Thread Phil Race
On Mon, 25 Apr 2022 09:37:10 GMT, Prasanta Sadhukhan wrote: > Test used to fail in specific CI macos M1 system owing to miniscule color > difference > > > x 0 y 0 red1 171 red2 171 green1 174 green2 175 blue1 184 blue2 184 > x 0 y 1 red1 172 red2 173 green1 177 green2 177 blue1 185 blue2 185

Re: RFR: 8285308: Win: Japanese logical fonts are drawn with wrong size [v2]

2022-05-03 Thread Phil Race
On Mon, 25 Apr 2022 08:15:18 GMT, Toshio Nakamura wrote: >> Japanese logical fonts are drawn with wrong size since Java 18. >> It's triggered by JEP 400, UTF-8 by Default. `sun.awt.FontConfiguration` >> (and `sun.awt.windows.WFontConfiguration`) seems to expect the native >> encoding instead of

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v10]

2022-05-03 Thread Alexey Ivanov
On Mon, 2 May 2022 19:53:44 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > updated test I'm afraid the t

Integrated: 8273506: java Robot API did the 'm' keypress and caused /awt/event/KeyEvent/KeyCharTest/KeyCharTest.html is timing out on macOS 12

2022-05-03 Thread Alexander Zuev
On Wed, 20 Apr 2022 17:04:09 GMT, Alexander Zuev wrote: > Clear the kCGEventFlagMaskSecondaryFn flag if it is set before posting > keyboard events to the system queue. This pull request has now been integrated. Changeset: 39e50c2d Author:Alexander Zuev URL: https://git.openjdk.java

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings [v3]

2022-05-03 Thread Matthias Baesken
On Tue, 3 May 2022 08:23:52 GMT, Alan Bateman wrote: >> Hi Alan, I agree (thats why I did not change the define in harfbuzz, but I >> missed that wepoll.c is 3rd party code as well). > > I assume you can revert the update to the copyright header in the latest > version as there aren't any chan

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings [v3]

2022-05-03 Thread David Holmes
On Tue, 3 May 2022 07:10:58 GMT, Matthias Baesken wrote: >> Currently we set _WIN32_WINNT at various places in the codebase; this is >> used to target a minimum Windows version we want to support. See also for >> more detailled information : >> https://docs.microsoft.com/en-us/windows/win32/win

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings [v3]

2022-05-03 Thread Erik Joelsson
On Tue, 3 May 2022 07:10:58 GMT, Matthias Baesken wrote: >> Currently we set _WIN32_WINNT at various places in the codebase; this is >> used to target a minimum Windows version we want to support. See also for >> more detailled information : >> https://docs.microsoft.com/en-us/windows/win32/win

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings [v3]

2022-05-03 Thread Alan Bateman
On Thu, 28 Apr 2022 07:13:24 GMT, Matthias Baesken wrote: >> src/java.base/windows/native/libnio/ch/wepoll.c line 159: >> >>> 157: >>> 158: #undef _WIN32_WINNT >>> 159: #define _WIN32_WINNT 0x0601 >> >> This is 3rd party code and would prefer not change it if possible. > > Hi Alan, I agree (th

Re: RFR: 8273506: java Robot API did the 'm' keypress and caused /awt/event/KeyEvent/KeyCharTest/KeyCharTest.html is timing out on macOS 12 [v2]

2022-05-03 Thread Sergey Bylokhov
On Wed, 27 Apr 2022 03:42:51 GMT, Alexander Zuev wrote: > d not. I probably will but it is unlikely it will be addressed quickly so > fixing this issue on our side seems to be required anyways. Please add a "feedback id" to the JBS, so it will be possible to refer that macOS bug later. --

Re: RFR: 8273506: java Robot API did the 'm' keypress and caused /awt/event/KeyEvent/KeyCharTest/KeyCharTest.html is timing out on macOS 12 [v2]

2022-05-03 Thread Sergey Bylokhov
On Thu, 21 Apr 2022 18:50:16 GMT, Alexander Zuev wrote: >> Clear the kCGEventFlagMaskSecondaryFn flag if it is set before posting >> keyboard events to the system queue. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Ad

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings [v3]

2022-05-03 Thread Matthias Baesken
> Currently we set _WIN32_WINNT at various places in the codebase; this is used > to target a minimum Windows version we want to support. See also for more > detailled information : > https://docs.microsoft.com/en-us/windows/win32/winprog/using-the-windows-headers?redirectedfrom=MSDN#setting-winv

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings [v2]

2022-05-03 Thread Matthias Baesken
> Currently we set _WIN32_WINNT at various places in the codebase; this is used > to target a minimum Windows version we want to support. See also for more > detailled information : > https://docs.microsoft.com/en-us/windows/win32/winprog/using-the-windows-headers?redirectedfrom=MSDN#setting-winv