On Mon, 9 May 2022 15:56:35 GMT, Adam Sotona wrote:
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand o
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/win
On Tue, 3 May 2022 07:10:58 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/win
On Thu, 28 Apr 2022 07:16:30 GMT, Matthias Baesken wrote:
> Hi Erik/David/Phil, we already have a good central place where we set the
> definition of WIN32_LEAN_AND_MEAN
>
> autoconf/flags-cflags.m4:460: ALWAYS_DEFINES_JDK="-DWIN32_LEAN_AND_MEAN
> -D_CRT_SECURE_NO_DEPRECATE autoconf/flags-cfla
On Wed, 27 Apr 2022 14:57:41 GMT, Matthias Baesken wrote:
> Currently we set _WIN32_WINNT at various places in the codebase; this is used
> to target a minimum Windows version we want to support. See also for more
> detailled information :
> https://docs.microsoft.com/en-us/windows/win32/winpro
On Thu, 14 Apr 2022 16:05:48 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `make` directory, and accepted those changes where
> it indeed discovered real typos.
>
> (Due to false positives this can unfortunately not be run automatically)
>
> Most of the fixes are in comments. A fe
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote:
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
>
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote:
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
>
On Tue, 22 Mar 2022 18:53:20 GMT, Phil Race wrote:
> Disable a warning from the Xcode 13.3 clang compiler when compiling libpng,
> which is used by libsplashscreen.
>
> Policy is not to change the upstream code locally unless it is also changed
> in the same way upstream.
> We could consider r
On Mon, 21 Mar 2022 16:29:25 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Thu, 17 Mar 2022 00:12:38 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Sat, 5 Mar 2022 06:49:16 GMT, Julian Waters wrote:
> Should I change the JBS issue title to match the PR title, or is it preferred
> for the PR title to change?
They need to match. You can either do it manually, or change the title to just
the bug number and the bot will change it for you.
On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy wrote:
> In JDK 18, JDK-8189591 added the ability to suppress doclint warnings.
> Therefore, it is now possible to enable the full doclint checks for the
> java.desktop module if the instances of warnings are suppressed. This patch
> does this; it wou
On Mon, 15 Nov 2021 13:57:25 GMT, Jayathirth D V wrote:
>> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in
>> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set
>> any deployment target when when we use xcrun to create .air file and this
>> iss
On Mon, 15 Nov 2021 07:17:45 GMT, Jayathirth D V wrote:
> A question popped up while doing this. By making 11.0 as minimum macosx
> version on aarch64, are we not restricting metal to be used only on >=11.0 on
> aarch 64?
Correct, but there are no older versions of Macos on aarch64, so this is
On Fri, 12 Nov 2021 17:45:09 GMT, Phil Race wrote:
> My understanding is that the flag here affects ONLY the metal compiler - for
> compiling metal shaders. And if you don't specify -Dsun.java2d.metal=true
> (since metal is off by defau�lt) its a 100% no-op for the rest of the JDK.
> And alrea
On Fri, 12 Nov 2021 14:55:24 GMT, Magnus Ihse Bursie wrote:
> If we leave -mmacosx-version-min unspecified, will metal pick another value
> by default silently? And if so, might we be actually lowering the min version
> even if specifying 10.14?
I'm not sure how Xcode picks the default target,
On Thu, 11 Nov 2021 15:32:01 GMT, Jayathirth D V wrote:
>> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in
>> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set
>> any deployment target when when we use xcrun to create .air file and this
>> iss
On Mon, 27 Sep 2021 01:00:18 GMT, Joe Darcy wrote:
> This is an initial PR for expanded lint warnings done under two bugs:
>
> 8202056: Expand serial warning to check for bad overloads of serial-related
> methods and ineffectual fields
> 8160675: Issue lint warning for non-serializable non-tran
19 matches
Mail list logo
