Re: Hairline strokes under fractional display metrics

2022-05-27 Thread Philip Race
Indeed .. something very close to that is what is being proposed in a current PR here : https://github.com/openjdk/jdk/pull/7449/files Just bear in mind some of the same constraints and that if printed on a 1200dpi printer with a scale of 16.67 .. your one pixel line might be too thin to be se

Re: Any interest in JDK-8264999 (stroke miter edge case in Marlin)

2022-05-24 Thread Philip Race
I haven't investigated this issue at all .. so sure. -phil. On 5/24/22 10:52 AM, Jeremy Wood wrote: This is a P3 ticket currently assigned to Philip Race: https://bugs.openjdk.java.net/browse/JDK-8264999 If I put together a PR: Is anyone available/willing to help review it? I made a

Re: Debugging Pre-Submit Test Failures

2022-05-22 Thread Philip Race
Apparently Linux 86 is broken because Loom needs work for that port .. so really completely ignore it for now. -phil On 5/22/22 3:21 PM, Philip Race wrote: Oh and if it "x86" then it really isn't something you need to worry about much since "x64" is passing and mai

Re: Debugging Pre-Submit Test Failures

2022-05-22 Thread Philip Race
Oh and if it "x86" then it really isn't something you need to worry about much since "x64" is passing and maintaining x86 is someone's hobby perhaps .. but not a big issue for mainline. I don't know why we even have that there. -phil On 5/22/22 3:14 PM,

Re: Debugging Pre-Submit Test Failures

2022-05-22 Thread Philip Race
Where are these files ? I can't see them. Is it something under  "Pre-submit tests - Linux x86" in the list of "Some checks were not successful" ? The reason I see for errors under there is just the odd "Error: Unable to find an artifact with the name: transient_jtreg_mickleness_88346f4d" M

Re: Unexpected EOFException in ImageReaderSpi.canDecodeInput

2022-05-20 Thread Philip Race
Le 17/05/2022 à 20:36, Philip Race a écrit : Why is it unexpected ? The purpose of ImageReaderSpi.canDecodeInput(Object) is to tell if the source object seems to be supported by the reader. If the file is too small, it is not supported by the reader. So a return value of false is what I would

Re: JDK-8274735, JPEG compression in a TIFF container, openjdk/jdk/pull/7849

2022-05-20 Thread Philip Race
e.g. it knows the space is RGB and not CMYK, it knows that there is a transparency saved with the tile. THX for hints Karm On 5/17/22 21:52, Philip Race wrote: > This could be a bug in the TIFF plugin. > Hard to say without debugging it. > > -phi

Re: JDK-8274735, JPEG compression in a TIFF container, openjdk/jdk/pull/7849

2022-05-17 Thread Philip Race
This could be a bug in the TIFF plugin. Hard to say without debugging it. -phil. On 5/17/22 7:04 AM, Michal Karm wrote: Hello, There used to be an Unsupported Image Type exception thrown when one wanted to decode a TIFF container with JPEG compressed image. That behavior has changed, there i

Re: Unexpected EOFException in ImageReaderSpi.canDecodeInput

2022-05-17 Thread Philip Race
Why is it unexpected ? The method declares that it throws IOException .. which if thrown clearly means the stream can't be de-coded. Perhaps your point is that this then prevents control reaching the reset, so that the next plugin doesn't get its turn to also reject the truncated file. I supp

Client-Libs Wiki page on writing regression tests

2022-04-16 Thread Philip Race
I have added a sub-page to the client-libs OpenJDK wiki on writing jtreg tests. https://wiki.openjdk.java.net/display/ClientLibs/Creating+Client+jtreg+tests A good part of it is about stable automated tests. I'm sure there are things I forgot to say. Please look at it and if there any speci

Client Libraries now has an OpenJDK Wiki Page

2022-03-10 Thread Philip Race
https://wiki.openjdk.java.net/display/ClientLibs is the new group wiki page. Although we do have a  Group page at : https://openjdk.java.net/groups/client-libs/ that web content only editable by Oracle employees whereas the wiki is editable by ANY member of the Client Libraries group listed at

Result: CFV: New Client Libraries Group Member : Dmitry Markov (dmarkov)

2022-02-23 Thread Philip Race
The vote for Dmitry Markov [1] is now closed. Yes: 6 Veto: 0 Abstain: 0 According to the OpenJDK Bylaws definition of Lazy Consensus [2], this is sufficient to approve the nomination. -phil. [1] https://mail.openjdk.java.net/pipermail/client-libs-dev/2022-February/002357.html [2] http://op

Result: CFV: New Client Libraries Group Member : Alexey Ivanov (aivanov)

2022-02-23 Thread Philip Race
The vote for Alexey Ivanov [1] is now closed. Yes: 7 Veto: 0 Abstain: 0 According to the OpenJDK Bylaws definition of Lazy Consensus [2], this is sufficient to approve the nomination. -phil. [1] https://mail.openjdk.java.net/pipermail/client-libs-dev/2022-February/002356.html [2] http://op

Re: RFR: 8047749: javadoc for getPathBounds() in TreeUI and BasicTreeUI is incorrect

2022-02-14 Thread Philip Race
component in path is currently "valid", which is wrong. The getPathBounds() in BasicTreeUI returns null if tree or treeState is null. Fixed the javadoc. _Mailing list message from [Philip Race](mailto:philip.r...@oracle.com) on [client-libs-dev](mailto:client-libs-...@mail.openjdk.java.ne

Re: Area#add(Area) Optimization

2022-02-12 Thread Philip Race
I suppose this could be added but it is something an application also can easily do for itself. >     curves = rhs.curves; The straight reference, rather than a copy surprised me, but I suppose (I am not familiar with the working of the Area class) that all mutations must create a new Vector

Re: Integrated: 8047749: javadoc for getPathBounds() in TreeUI and BasicTreeUI is incorrect

2022-02-11 Thread Philip Race
This should have had a CSR. Valid -> Invalid is fixing a typo for sure but a very significant one in the context. Please retroactively submit the CSR. -phil. On 2/11/22 1:43 AM, Prasanta Sadhukhan wrote: On Thu, 10 Feb 2022 08:11:04 GMT, Prasanta Sadhukhan wrote: The javadoc descriptions

Re: CFV: New Client Libraries Group Member : Dmitry Markov (dmarkov)

2022-02-09 Thread Philip Race
Vote: yes -phil.

Re: CFV: New Client Libraries Group Member : Alexey Ivanov (aivanov)

2022-02-09 Thread Philip Race
Vote: yes -phil.

CFV: New Client Libraries Group Member : Dmitry Markov (dmarkov)

2022-02-09 Thread Philip Race
I hereby nominate Dmitry Markov (dmarkov) to Membership in the Client Libraries Group. Dmitry has worked in the client libraries sustaining team at Oracle since 2013 and in that time has contributed 61 client fixes [1], [2]. He has been active on the old client lists, awt-dev [3], swing-dev[4]

CFV: New Client Libraries Group Member : Alexey Ivanov (aivanov)

2022-02-09 Thread Philip Race
I hereby nominate Alexey Ivanov (aivanov) to Membership in the Client Libraries Group. Alexey has worked in the client libraries sustaining team at Oracle since 2014 and in that time has contributed 60 client fixes [1], [2]. He has been active on the old client lists, awt-dev [3], swing-dev[4]

Re: Allow overriding lp and lpr binary paths in PSPrintJob

2021-10-22 Thread Philip Race
Well .. 1) Please read the comment the bots added to your PR. There are steps you need to take before we can even look at your contribution. 2) PRs need a JBS bug ID else the bots will  still reject it. You'll need to submit an RFE at bugreport.java.com and go from there. 3) I understand your

Re: RasterFormatException thrown when drawing a tiled image made of non-writable rasters

2021-10-15 Thread Philip Race
Now https://bugs.openjdk.java.net/browse/JDK-8275345 -phil On 10/15/21 1:11 PM, Martin Desruisseaux wrote: Hello Philip Le 15/10/2021 à 18:28, Philip Race a écrit : I don't see that you have a JBS (https://bugs.openjdk.java.net/) account so I can submit the bug for you if needed or (b

Re: RasterFormatException thrown when drawing a tiled image made of non-writable rasters

2021-10-15 Thread Philip Race
Hi Martin, You  do show up on the list of folks who have signed the OCA so the process is to submit a bug and then a PR referencing it at https://github.com/openjdk/jdk following the process at https://openjdk.java.net/guide/ I don't see that you have a JBS (https://bugs.openjdk.java.net/) acco

Result: CFV: New Client Libraries Group Member : Pankaj Bansal (pbansal)

2021-10-14 Thread Philip Race
The vote for Pankaj Bansal  [1] is now closed. Yes: 4 Veto: 0 Abstain: 0 According to the OpenJDK Bylaws definition of Lazy Consensus [2], this is sufficient to approve the nomination. -phil. [1] https://mail.openjdk.java.net/pipermail/client-libs-dev/2021-September/000503.html [2] http://op

Result : CFV: New Client Libraries Group Member : Prasanta Sadhukhan (psadhukhan)

2021-10-14 Thread Philip Race
The vote for Prasanta Sadhukhan [1] is now closed. Yes: 4 Veto: 0 Abstain: 0 According to the OpenJDK Bylaws definition of Lazy Consensus [2], this is sufficient to approve the nomination. -phil. [1] https://mail.openjdk.java.net/pipermail/client-libs-dev/2021-September/000502.html [2] http:

Re: Possibility of backporting fix for JDK-6986863

2021-10-13 Thread Philip Race
I think it would be good to backport and I suspect Sergey may well do so .. although generally the place to ask about backports to older releases is one of the update release mailing lists. phil. On 10/13/21 11:02 AM, Harald Kuhr wrote: Hi all, I just signed up for the client-libs-dev mailin

Re: CFV: New Client Libraries Group Member : Pankaj Bansal (pbansal)

2021-09-30 Thread Philip Race
Vote: yes -phil.

Re: CFV: New Client Libraries Group Member : Prasanta Sadhukhan (psadhukhan)

2021-09-30 Thread Philip Race
Vote:  yes -phil

Re: CFV: New Client Libraries Group Member : Prasanta Sadhukhan (psadhukhan)

2021-09-30 Thread Philip Race
Vote: yes -phil

CFV: New Client Libraries Group Member : Pankaj Bansal (pbansal)

2021-09-30 Thread Philip Race
I hereby nominate Pankaj Bansal (pbansal) to Membership in the Client Libraries Group. Pankaj has worked in the client team at Oracle since 2017 and in that time has contributed approximately 70-80 fixes [1], [2]. He has been active on the old client lists, awt-dev [3], swing-dev[4] and 2d-dev

CFV: New Client Libraries Group Member : Prasanta Sadhukhan (psadhukhan)

2021-09-30 Thread Philip Race
I hereby nominate Prasanta Sadhukhan (psadhukhan) to Membership in the Client Libraries Group. Prasanta has worked in the client team at Oracle since 2015 and in that time has contributed approximately 460 fixes [1], [2]. He has been active on the old client lists, awt-dev [3], swing-dev[4] an

One (client) list to rule them all

2021-09-30 Thread Philip Race
As per previous notice to this list [1],  the old 2d, awt, swing, beans and sound list have been retired as of 12pm PDT today, 30th September. Their archives will remain available indefinitely. All client-libs related discussions, notices, etc should be here from now on. -Phil. [1] https:/

Re: HiDPI Fractional Scaling on Linux/GTK

2021-09-30 Thread Philip Race
I don't have a succinct answer to your question without doing a bunch of research. Probably start by just updating the code that forces it to be an int and see what breaks :-) Maybe one of the folks who worked on it for windows could say what is missing but I'd guess shared Swing code is probabl

Re: RFR: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux [v3]

2021-09-15 Thread Philip Race
You are right there's no check. One could be added by a motivated party .. The minimum for Linux may be as old as 1.2.3  but safer is 2.3.1 since we rely on that for AAT font support. I can't (quickly) speak to any important bug fixes in later releases we may need, just API / functionality. -p

Retiring 2d, awt, beans, sound and swing mailing lists on 30th September 2021

2021-09-15 Thread Philip Race
Since : 1) The old client groups mailing lists were consolidated into client-libs-dev at openjdk dot java dot net [1], including subscribing all subscribers to the old invividual lists to the new consolidated list, and 2) The skara github tooling has also migrated to that new list and 3) Folks

Re: Loading FontManager from sun.font.fontmanager property

2021-09-09 Thread Philip Race
I think it can be, although the problem with the other cases was that they were set by the launcher and always appeared in the enumeration of system properties. This case is not documented and isn't set .. but is an effective waste of code since any kind of external replacement isn't possible w

Re: JDK-8269888: Thai text rendered incorrectly using some AffineTransform-derived fonts

2021-09-08 Thread Philip Race
JDK-8145901 isn't accessible because some confidential information is in the description and attachments .. and in fact it was JCK failure so we need to be careful not to regress that But I guess you found the changeset for it. The problem we were trying to solve there was === The font interface

Fwd: Project Wakefield announcement and welcome

2021-09-01 Thread Philip Race
FYI -phil Forwarded Message Subject:Project Wakefield announcement and welcome Date: Wed, 1 Sep 2021 14:59:30 -0700 From: Philip Race To: wakefield-...@openjdk.java.net Hi all, The project has been recorded in the OpenJDK census : https

Welcome to the client-libs-dev mailing list

2021-07-15 Thread Philip Race
Hello, Per the approval of consolidation of the client groups [1], a new group (client-libs) is being created and this is its mailing list. All subscribers to the swing, 2d, and awt group mailing lists have been added as the initial step. Those mailing lists will eventually be archived and ma