Re: RFR: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails [v3]

2021-10-24 Thread Sergey Bylokhov
On Fri, 22 Oct 2021 12:05:24 GMT, Alexander Zvegintsev wrote: >> Looks like the test does not fail anymore. >> >> However some cleanup was made: >> >> - fixed wildcard imports >> - frame centered and explicitly disposed at the end >> - removed unused `setAutoDelay()` call (no key/mouse key eve

Re: RFR: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails [v3]

2021-10-23 Thread Alexander Zvegintsev
On Fri, 22 Oct 2021 12:05:24 GMT, Alexander Zvegintsev wrote: >> Looks like the test does not fail anymore. >> >> However some cleanup was made: >> >> - fixed wildcard imports >> - frame centered and explicitly disposed at the end >> - removed unused `setAutoDelay()` call (no key/mouse key eve

Re: RFR: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails [v3]

2021-10-22 Thread Sergey Bylokhov
On Fri, 22 Oct 2021 12:05:24 GMT, Alexander Zvegintsev wrote: >> Looks like the test does not fail anymore. >> >> However some cleanup was made: >> >> - fixed wildcard imports >> - frame centered and explicitly disposed at the end >> - removed unused `setAutoDelay()` call (no key/mouse key eve

Re: RFR: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails [v2]

2021-10-22 Thread Alexander Zvegintsev
On Fri, 22 Oct 2021 19:11:56 GMT, Sergey Bylokhov wrote: > Please clarify, did the updated test fail before that fix, and pass after? Unfortunately I could not find a correct repo location for jdk6 containing the original fix changeset. All I've found is a bunch of mercurial repos `jdk6u*/j2s

Re: RFR: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails [v2]

2021-10-22 Thread Sergey Bylokhov
On Fri, 22 Oct 2021 12:14:20 GMT, Alexander Zvegintsev wrote: > > Did you check the possibility to verify JDK-4140484, I think it should be > > possible but just in case. > > Original test cases from JDK-4140484 description are still have no issues. Please clarify, did the updated test fail b

Re: RFR: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails [v2]

2021-10-22 Thread Alexander Zvegintsev
On Fri, 22 Oct 2021 02:03:26 GMT, Sergey Bylokhov wrote: > Did you check the possibility to verify JDK-4140484, I think it should be > possible but just in case. Original test cases from JDK-4140484 description are still have no issues. Hundreds of runs of this test on mach5 has not a single f

Re: RFR: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails [v3]

2021-10-22 Thread Alexander Zvegintsev
> Looks like the test does not fail anymore. > > However some cleanup was made: > > - fixed wildcard imports > - frame centered and explicitly disposed at the end > - removed unused `setAutoDelay()` call (no key/mouse key events generated) > - improved variable naming > > Testing still green. A

Re: RFR: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails [v2]

2021-10-21 Thread Sergey Bylokhov
On Thu, 21 Oct 2021 10:57:28 GMT, Alexander Zvegintsev wrote: >> Looks like the test does not fail anymore. >> >> However some cleanup was made: >> >> - fixed wildcard imports >> - frame centered and explicitly disposed at the end >> - removed unused `setAutoDelay()` call (no key/mouse key eve

Re: RFR: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails [v2]

2021-10-21 Thread Alexander Zvegintsev
> Looks like the test does not fail anymore. > > However some cleanup was made: > > - fixed wildcard imports > - frame centered and explicitly disposed at the end > - removed unused `setAutoDelay()` call (no key/mouse key events generated) > - improved variable naming > > Testing still green. A

Re: RFR: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails

2021-10-21 Thread Sergey Bylokhov
On Thu, 21 Oct 2021 02:04:01 GMT, Alexander Zvegintsev wrote: > Looks like the test does not fail anymore. > > However some cleanup was made: > > - fixed wildcard imports > - frame centered and explicitly disposed at the end > - removed unused `setAutoDelay()` call (no key/mouse key events gen

RFR: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails

2021-10-20 Thread Alexander Zvegintsev
Looks like the test does not fail anymore. However some cleanup was made: - fixed wildcard imports - frame centered and explicitly disposed at the end - removed unused `setAutoDelay()` call (no key/mouse key events generated) - improved variable naming Testing still green. - Commit