Re: RFR: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails [v3]

2021-10-22 Thread Alexander Zvegintsev
> Looks like the test does not fail anymore. > > However some cleanup was made: > > - fixed wildcard imports > - frame centered and explicitly disposed at the end > - removed unused `setAutoDelay()` call (no key/mouse key events generated) > - improved variable naming > > Testing still green. A

Re: RFR: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails [v2]

2021-10-22 Thread Alexander Zvegintsev
On Fri, 22 Oct 2021 02:03:26 GMT, Sergey Bylokhov wrote: > Did you check the possibility to verify JDK-4140484, I think it should be > possible but just in case. Original test cases from JDK-4140484 description are still have no issues. Hundreds of runs of this test on mach5 has not a single f

RFR: 8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak

2021-10-22 Thread Anton Tarasov
This is a reimplementation of the `isWrapped` logic in the method: `+[CommonComponentAccessibility createWithParent:accessible:role:index:withEnv:withView:isWrapped:]` The `isWrapped` arg was used to create an a11y element which is wrapped into an object that does not have direct peer in Java (

Re: RFR: 8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak

2021-10-22 Thread Anton Tarasov
On Fri, 22 Oct 2021 16:02:32 GMT, Anton Tarasov wrote: > This is a reimplementation of the `isWrapped` logic in the method: > > `+[CommonComponentAccessibility > createWithParent:accessible:role:index:withEnv:withView:isWrapped:]` > > The `isWrapped` arg was used to create an a11y element whic

ARMv7A Sound Not Working On OpenJDK-11

2021-10-22 Thread John Cummings
Hello all, I have been attempting to build OpenJDK-11 for an ARMv7-A system using Cortex-A7 that currently runs Java 8. After resolving my build issues with the build-dev mailing list (who sent me here for this issue), I'm able to make it run on the system, but it cannot play sound and I have been

Allow overriding lp and lpr binary paths in PSPrintJob

2021-10-22 Thread Rolf van Kleef
I am not sure about whether this is the correct list for this, or whether this is an appropriate message for this list, but I have been told to send an email here regarding a PR I submitted on GitHub. I recently ran into trouble with printing on Linux, where the lpr binary was on a non-standard

RFR: 8275809: crash in [CommonComponentAccessibility getCAccessible:withEnv:]

2021-10-22 Thread Anton Tarasov
Adding a JNI weak ref check. There's a couple of other similar places in the code where a JNI weak ref is checked for null, in the rest of the code we pass such refs to java where they are checked for null. So, I was not able to eye catch any other similar place in the a11y code where such check

Re: Allow overriding lp and lpr binary paths in PSPrintJob

2021-10-22 Thread Philip Race
Well .. 1) Please read the comment the bots added to your PR. There are steps you need to take before we can even look at your contribution. 2) PRs need a JBS bug ID else the bots will  still reject it. You'll need to submit an RFE at bugreport.java.com and go from there. 3) I understand your

Integrated: 8198336: java/awt/FontMetrics/FontCrash.java fails in headless mode

2021-10-22 Thread Phil Race
On Wed, 20 Oct 2021 04:12:46 GMT, Phil Race wrote: > The code this test exercises is very obsolete. So this removes the test that > triggers it along with that code. This pull request has now been integrated. Changeset: 6523c558 Author:Phil Race URL: https://git.openjdk.java.net/jd

Re: RFR: 8262945: [macos] Regression Manual Test for Key Events Fails [v3]

2021-10-22 Thread Alexander Zuev
On Mon, 27 Sep 2021 16:19:21 GMT, Alisen Chung wrote: >> Added a check for active keyboard language and added support for Russian >> NSEvent keyCodes to JavaVirtualKeyCode translation. Originally, only English >> characters were checked for even if other languages were in native >> letterChara

Re: RFR: 8275809: crash in [CommonComponentAccessibility getCAccessible:withEnv:]

2021-10-22 Thread Victor Dyakov
On Fri, 22 Oct 2021 16:47:24 GMT, Anton Tarasov wrote: > Adding a JNI weak ref check. There's a couple of other similar places in the > code where a JNI weak ref is checked for null, in the rest of the code we > pass such refs to java where they are checked for null. So, I was not able to > ey

Re: RFR: 8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak

2021-10-22 Thread Victor Dyakov
On Fri, 22 Oct 2021 16:02:32 GMT, Anton Tarasov wrote: > This is a reimplementation of the `isWrapped` logic in the method: > > `+[CommonComponentAccessibility > createWithParent:accessible:role:index:withEnv:withView:isWrapped:]` > > The `isWrapped` arg was used to create an a11y element whic

Re: RFR: 8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak

2021-10-22 Thread Alexander Zuev
On Fri, 22 Oct 2021 18:02:28 GMT, Victor Dyakov wrote: > @azuev-java @pankaj-bansal please review Note that this change can be applied only after the https://github.com/openjdk/jdk/pull/6020 so i'm testing that change at the moment and will report on it first. - PR: https://git.o

RFR: 8275819: [TableRowAccessibility accessibilityChildren] method is ineffective

2021-10-22 Thread Anton Tarasov
Retrieve only cells for a particular table row when requested, not the whole table. - Commit messages: - 8275819: [TableRowAccessibility accessibilityChildren] method is ineffective Changes: https://git.openjdk.java.net/jdk/pull/6085/files Webrev: https://webrevs.openjdk.java.net/

Re: RFR: 8273678 TableAccessibility and TableRowAccessibility miss autorelease

2021-10-22 Thread Anton Tarasov
On Tue, 19 Oct 2021 17:11:18 GMT, Artem Semenov wrote: > The TableAccessibility obj-c class should call [autorelease] on an object it > allocates (see: [TableRowAccessibility alloc] and [ColumnAccessibility > alloc]). > > The TableRowAccessibility obj-c class should not call [retain] on an >

Re: RFR: 8273678 TableAccessibility and TableRowAccessibility miss autorelease

2021-10-22 Thread Alexander Zuev
On Tue, 19 Oct 2021 17:11:18 GMT, Artem Semenov wrote: > The TableAccessibility obj-c class should call [autorelease] on an object it > allocates (see: [TableRowAccessibility alloc] and [ColumnAccessibility > alloc]). > > The TableRowAccessibility obj-c class should not call [retain] on an >

RFR: 8275170: Some jtreg sound tests should be marked headful

2021-10-22 Thread Phil Race
This fix adds "headful sound" keywords to a number of javax/sound jtreg tests The jtreg javax.sound tests are written in such a way that if a needed audio device or other platform resource is not available, they just exit with a "pass" for the test. It is as if headful tests just swallowed Headl

Re: RFR: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails [v2]

2021-10-22 Thread Sergey Bylokhov
On Fri, 22 Oct 2021 12:14:20 GMT, Alexander Zvegintsev wrote: > > Did you check the possibility to verify JDK-4140484, I think it should be > > possible but just in case. > > Original test cases from JDK-4140484 description are still have no issues. Please clarify, did the updated test fail b

RFR: 8273704: DrawStringWithInfiniteXform.java failed : drawString with InfiniteXform transform takes long time

2021-10-22 Thread Phil Race
This test has only failed once - for reasons that are not clear. I wanted to just increase the timeout but the test was written such that it always waited as long as the timeout since it had an un-canceled scheduled task. So I've also made the test cancel the task once it is complete and made the

RFR: 8196440: Regression automated Test 'java/awt/TrayIcon/PopupMenuLeakTest/PopupMenuLeakTest.java' fails

2021-10-22 Thread Alexander Zvegintsev
The test doesn't take into account that SystemTray may not be supported. In case of Ubuntu this happens when `_NET_SYSTEM_TRAY` is not present. - Commit messages: - initial Changes: https://git.openjdk.java.net/jdk/pull/6088/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&

Re: RFR: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails [v2]

2021-10-22 Thread Alexander Zvegintsev
On Fri, 22 Oct 2021 19:11:56 GMT, Sergey Bylokhov wrote: > Please clarify, did the updated test fail before that fix, and pass after? Unfortunately I could not find a correct repo location for jdk6 containing the original fix changeset. All I've found is a bunch of mercurial repos `jdk6u*/j2s

Re: ARMv7A Sound Not Working On OpenJDK-11

2021-10-22 Thread John Cummings
Nevermind! I found the solution shortly after: it turns out there was a discrepancy between the libasound.so.2.0.0 on the system and the one in my buildroot. For some reason snd_pcm_hw_params_get_channels_min in src/java.desktop/linux/native/libjsound/PLATFORM_API_LinuxOS_ALSA_PCM.c at 156 would al

Re: RFR: 8196440: Regression automated Test 'java/awt/TrayIcon/PopupMenuLeakTest/PopupMenuLeakTest.java' fails

2021-10-22 Thread Sergey Bylokhov
On Fri, 22 Oct 2021 19:59:31 GMT, Alexander Zvegintsev wrote: > The test doesn't take into account that SystemTray may not be supported. > In case of Ubuntu this happens when `_NET_SYSTEM_TRAY` is not present. Marked as reviewed by serb (Reviewer). - PR: https://git.openjdk.java.n

Re: RFR: 8275170: Some jtreg sound tests should be marked headful

2021-10-22 Thread Sergey Bylokhov
On Fri, 22 Oct 2021 19:01:27 GMT, Phil Race wrote: > This fix adds "headful sound" keywords to a number of javax/sound jtreg tests > > The jtreg javax.sound tests are written in such a way that if a needed audio > device > or other platform resource is not available, they just exit with a "pass

Re: RFR: 8273704: DrawStringWithInfiniteXform.java failed : drawString with InfiniteXform transform takes long time

2021-10-22 Thread Sergey Bylokhov
On Fri, 22 Oct 2021 19:25:28 GMT, Phil Race wrote: > This test has only failed once - for reasons that are not clear. > I wanted to just increase the timeout but the test was written such that it > always waited as long > as the timeout since it had an un-canceled scheduled task. > > So I've al

Re: RFR: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails [v3]

2021-10-22 Thread Sergey Bylokhov
On Fri, 22 Oct 2021 12:05:24 GMT, Alexander Zvegintsev wrote: >> Looks like the test does not fail anymore. >> >> However some cleanup was made: >> >> - fixed wildcard imports >> - frame centered and explicitly disposed at the end >> - removed unused `setAutoDelay()` call (no key/mouse key eve