On Tue, 26 Oct 2021 04:52:37 GMT, Sergey Bylokhov wrote:
>> Masanori Yano has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> com
On Thu, 28 Oct 2021 09:03:55 GMT, Sergey Bylokhov wrote:
>> Yes, this run() is called on "D3D Screen Updater" thread. It is reasonable
>> that a new PaintEvent is posted when SurfaceData is replaced on this thread.
>> I would limit posting new PaintEvent via createGraphics() only.
>
> Probably
On Wed, 10 Nov 2021 17:41:08 GMT, Ludvig Janiuk wrote:
>> This change introduces no visual difference, but improves a11y.
>> EDIT: There is a slight visual change regarding centering in a few cells.
>
> Ludvig Janiuk has updated the pull request incrementally with one additional
> commit since t
> This removes code that relied on consulting the Bezier control points to
> calculate the Rectangle2D bounding box. Instead it's pretty straight-forward
> to convert the Bezier control points into the x & y parametric equations. At
> their most complex these equations are cubic polynomials, so
On Wed, 10 Nov 2021 10:25:55 GMT, Laurent Bourgès wrote:
>> @prrace @mrserb what do you think on this bug in terms of precision
>> requirements?
>> - should bbox always include control points ?
>> - should ideal shape always fit in bbox ? So I propose to add a margin >
>> numerical inaccuracies
On Thu, 11 Nov 2021 09:40:07 GMT, Jeremy wrote:
>> Ideally jdk could provide new math methods:
>> - evalPoly(eqn[])
>> - find roots...
>> Based on compensated horner scheme and Math.fma() ~ 0.5 ulp
>
> I attempted to explore a numerical approach to pad the bounding box here
> 4b9d87d6d03e923bb26
On Thu, 11 Nov 2021 10:18:29 GMT, Laurent Bourgès wrote:
>> I attempted to explore a numerical approach to pad the bounding box here
>> 4b9d87d6d03e923bb2663fc8f4f77b7549df6e70 ... but I don't like the results so
>> far. Any suggestions? (Or if you have a better approach in mind we can
>> disc
On Thu, 11 Nov 2021 05:52:18 GMT, Jayathirth D V wrote:
> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in
> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set
> any deployment target when when we use xcrun to create .air file and this
> issue l
On Thu, 11 Nov 2021 13:52:13 GMT, Magnus Ihse Bursie wrote:
> We should not hard-code version numbers like that.
>
> Fortunately for you, there already exists a variable $(MACOSX_VERSION_MIN)
> that you can use.
Thanks for the review i have updated code to use the Macro.
-
PR: ht
> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in
> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set
> any deployment target when when we use xcrun to create .air file and this
> issue looks similar to https://developer.apple.com/forums/thread/
On Thu, 11 Nov 2021 13:53:05 GMT, Magnus Ihse Bursie wrote:
> Also, if you did not create this patch yourself, please make sure to use
> `/contributor` to give proper credits. Or maybe you mean that Vitaly
> submitted the bug report, not the patch?
By Submitter i meant submitter of bug in JBS.
On Wed, 10 Nov 2021 08:47:10 GMT, Matthias Baesken wrote:
>> I think Xcheck:jni raises a warning when two JNI calls are made in a row w/o
>> calling exception check in between. So it is not necessary to have an actual
>> exception to produce a warning.
>>
>> Probably it is reproduced there, be
On Thu, 11 Nov 2021 15:32:01 GMT, Jayathirth D V wrote:
>> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in
>> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set
>> any deployment target when when we use xcrun to create .air file and this
>> iss
On Mon, 8 Nov 2021 09:13:35 GMT, Ludvig Janiuk wrote:
> This change introduces no visual difference, but improves a11y.
> EDIT: There is a slight visual change regarding centering in a few cells.
This pull request has now been integrated.
Changeset: 5e98f993
Author:Ludvig Janiuk
Committer:
On Thu, 28 Oct 2021 13:24:41 GMT, Alexander Zvegintsev
wrote:
> This test does not fail on Windows and does fail on Linux.
>
> After de-iconification we expect to see the button focused:
> 