RFR: 8266435: WBMPImageReader.read() should not truncate the input stream

2021-11-23 Thread Jayathirth D V
If we use a custom stream and specify limit on stream.read() length, WBMPImageReader.read() doesnt verify whether we are decoded complete data or not. We can check the length of data decoded and rerun the stream.read() or use readFully(). In case of other decoders like BMP we are using readFully

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException [v4]

2021-11-23 Thread Jayathirth D V
On Fri, 19 Nov 2021 09:04:22 GMT, Masanori Yano wrote: >> Could you please review the 8262297 bug fixes? >> >> In this case, ImageIO.write() should throw java.io.IOException rather than >> java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and >> wrapped in IIOException i

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException [v4]

2021-11-23 Thread Jayathirth D V
On Fri, 19 Nov 2021 09:04:22 GMT, Masanori Yano wrote: >> Could you please review the 8262297 bug fixes? >> >> In this case, ImageIO.write() should throw java.io.IOException rather than >> java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and >> wrapped in IIOException i

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException [v4]

2021-11-23 Thread Jayathirth D V
On Tue, 23 Nov 2021 11:14:09 GMT, Jayathirth D V wrote: >> Masanori Yano has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8262297: ImageIO.write() method will throw IndexOutOfBoundsException >> - 8262297: ImageIO.write() method will th

RFR: 8272392 Lanai: SwingSet2. Black background on expanding tree node

2021-11-23 Thread Alexey Ushakov
Removed creation of the separate encoder depending on destination properties as we don't use this info to customize the encoder properties - Commit messages: - 8272392 Lanai: SwingSet2. Black background on expanding tree node Changes: https://git.openjdk.java.net/jdk/pull/6529/file

Re: RFR: 8274893: Update java.desktop classes to use try-with-resources [v4]

2021-11-23 Thread Andrey Turbanov
> 8274893: Update java.desktop classes to use try-with-resources Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8274893: Update java.desktop classes to use try-with-resources close nested streams too to unify code -

Re: RFR: 8274893: Update java.desktop classes to use try-with-resources [v4]

2021-11-23 Thread Andrey Turbanov
On Fri, 19 Nov 2021 19:24:50 GMT, Sergey Bylokhov wrote: >> updated > > What about "new InputStreamReader()" here and below? added it to `try` too - PR: https://git.openjdk.java.net/jdk/pull/5817

Re: RFR: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel [v4]

2021-11-23 Thread Sergey Bylokhov
On Fri, 19 Nov 2021 21:36:57 GMT, Alisen Chung wrote: >> test/jdk/java/awt/Scrollbar/AquaLFScrollbarTest/ScrollBarBorderTest.java >> line 114: >> >>> 112: = "\nINSTRUCTIONS:\n" >>> 113: + "\n Try to drag the thumb of the scrollbar into >>> the red zone." >>> 1

Re: RFR: 8266435: WBMPImageReader.read() should not truncate the input stream

2021-11-23 Thread Sergey Bylokhov
On Tue, 23 Nov 2021 11:05:27 GMT, Jayathirth D V wrote: > If we use a custom stream and specify limit on stream.read() length, > WBMPImageReader.read() doesnt verify whether we are decoded complete data or > not. We can check the length of data decoded and rerun the stream.read() or > use read