Re: RFR: 8278050: Armenian text isn't rendered on macOS if text layout is performed

2021-12-15 Thread Dmitry Batrak
On Wed, 15 Dec 2021 01:13:04 GMT, Sergey Bylokhov wrote: > I would like to clarify why we cannot merge the results of the > availableFontFamilies and availableFonts? We can do it, if everyone is OK with increasing the scope of the change, due to the following factors: * The number of fonts adv

[jdk18] RFR: 8278604 SwingSet2 table demo does not have accessible description set for images

2021-12-15 Thread Artem Semenov
SwingSet2 demo is often used to check accessibility for different Swing components and has some shortcomings. The major one is that images within the table demo do not have accessible description set which makes accessibility perform differently on different platforms when navigating the table w

Re: [jdk18] RFR: 8278604 SwingSet2 table demo does not have accessible description set for images

2021-12-15 Thread Anton Tarasov
On Wed, 15 Dec 2021 12:43:40 GMT, Artem Semenov wrote: > SwingSet2 demo is often used to check accessibility for different Swing > components and has some shortcomings. The major one is that images within the > table demo do not have accessible description set which makes accessibility > perfo

Re: RFR: 8278612: test/jdk/java/awt/dnd/RemoveDropTargetCrashTest crashes with VoiceOver on macOS

2021-12-15 Thread Victor Dyakov
On Mon, 13 Dec 2021 16:50:00 GMT, Anton Tarasov wrote: > … VoiceOver on macOS @forantar please re-submit at 18 forked - PR: https://git.openjdk.java.net/jdk/pull/6816

Re: RFR: 6465404: some problems in CellEditor related API docs [v5]

2021-12-15 Thread Alexey Ivanov
On Wed, 15 Dec 2021 01:36:38 GMT, Sergey Bylokhov wrote: >> @prrace Shall we update `TableCellEditor` Javadoc to _“Adds to CellEditor >> the extensions necessary to configure an editor in a table.”_ to make it >> similar to `TreeCellEditor`? > > Isn't this is another way around? The doc says th

Re: RFR: 8278348: [macos12] javax/swing/JTree/4908142/bug4908142.java fails in macos12

2021-12-15 Thread Prasanta Sadhukhan
On Tue, 14 Dec 2021 05:44:17 GMT, Prasanta Sadhukhan wrote: > Test seem to be failing in macos12.0.1 (although it does not seem to affect > 12.1) due to keypresses of "a", "a", "d" is not selecting "aad" but "ade" > which seems to point to the fact that 2 exclusive "a" keypress are considered

Re: RFR: 8274898: Cleanup usages of StringBuffer in jdk tools modules

2021-12-15 Thread Andrey Turbanov
On Thu, 9 Sep 2021 06:53:13 GMT, Andrey Turbanov wrote: > StringBuffer is a legacy synchronized class. StringBuilder is a direct > replacement to StringBuffer which generally have better performance > @turbanoff Only [Committers](https://openjdk.java.net/bylaws#committer) are > allowed to spon

Integrated: 8274898: Cleanup usages of StringBuffer in jdk tools modules

2021-12-15 Thread Andrey Turbanov
On Thu, 9 Sep 2021 06:53:13 GMT, Andrey Turbanov wrote: > StringBuffer is a legacy synchronized class. StringBuilder is a direct > replacement to StringBuffer which generally have better performance This pull request has now been integrated. Changeset: 04dbdd36 Author:Andrey Turbanov Comm

Re: RFR: 8274898: Cleanup usages of StringBuffer in jdk tools modules

2021-12-15 Thread David Holmes
On Wed, 15 Dec 2021 17:59:54 GMT, Andrey Turbanov wrote: > > @turbanoff Only [Committers](https://openjdk.java.net/bylaws#committer) are > > allowed to sponsor changes. > > But I am a Committer 😢 You can't "sponsor" your own change. I suspect your Committer status changed after the bot initia

Re: RFR: 8277463: JFileChooser with Metal L&F doesn't show non-canonical UNC path in - Look in

2021-12-15 Thread Sergey Bylokhov
On Fri, 10 Dec 2021 08:59:55 GMT, Masanori Yano wrote: > I would like to fix the bug reported in JDK-8277463. > > As reporter's investigation, ShellFolder.getNormalizedFile() returns > incorrect value for non-canonical Windows UNC path. getNormalizedFile() is > used for symbolic link path, but

Re: RFR: 8278828 : java/awt/a11y/AccessibleTextTest.java's createTextArea() just shows instructions on the UI

2021-12-15 Thread Sergey Bylokhov
On Wed, 15 Dec 2021 02:21:35 GMT, lawrence.andrews wrote: > 1) Test scenario was just showing test instruction with JTextArea. So added > the JTextArea as the instruction and method says. > 2) JTextArea is filled with contents so that and an Emoji character making > sure that screen reader ca

Re: RFR: 8278348: [macos12] javax/swing/JTree/4908142/bug4908142.java fails in macos12

2021-12-15 Thread Sergey Bylokhov
On Tue, 14 Dec 2021 05:44:17 GMT, Prasanta Sadhukhan wrote: > Test seem to be failing in macos12.0.1 (although it does not seem to affect > 12.1) due to keypresses of "a", "a", "d" is not selecting "aad" but "ade" > which seems to point to the fact that 2 exclusive "a" keypress are considered

Re: RFR: 6496103: isFileHidingEnabled return false by default [v2]

2021-12-15 Thread Sergey Bylokhov
On Wed, 15 Dec 2021 06:25:54 GMT, Tejesh R wrote: >> src/java.desktop/share/classes/javax/swing/JFileChooser.java line 1416: >> >>> 1414: * Returns true if hidden files are not shown in the file chooser; >>> 1415: * otherwise, returns false. The default value of this property >>> is d

Re: RFR: 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control points in bounding box [v10]

2021-12-15 Thread Phil Race
On Fri, 19 Nov 2021 19:09:54 GMT, Jeremy wrote: >> This removes code that relied on consulting the Bezier control points to >> calculate the Rectangle2D bounding box. Instead it's pretty straight-forward >> to convert the Bezier control points into the x & y parametric equations. At >> their m

Re: RFR: 8277817: java/awt/dnd/BadSerializationTest/BadSerializationTest.java failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy [v9]

2021-12-15 Thread Sergey Bylokhov
On Mon, 13 Dec 2021 17:54:19 GMT, Liam Miller-Cushon wrote: > I'm happy to update this change to scrap the test if there's agreement that's > the best resolution. I disagree to do that. First, the test is quite important to check the broken serialization form, see the initial bug report. Secon

Re: RFR: 8277817: java/awt/dnd/BadSerializationTest/BadSerializationTest.java failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy [v9]

2021-12-15 Thread Liam Miller-Cushon
On Fri, 10 Dec 2021 17:03:49 GMT, Liam Miller-Cushon wrote: >> This change updates the serialized objects used by >> `java/awt/dnd/BadSerializationTest/BadSerializationTest.java` using a >> similar approach to the previous fix in >> [JDK-8039082](https://bugs.openjdk.java.net/browse/JDK-803908

Re: RFR: 6465404: some problems in CellEditor related API docs [v5]

2021-12-15 Thread Sergey Bylokhov
On Wed, 15 Dec 2021 16:46:17 GMT, Alexey Ivanov wrote: > The object that implements the interface is not necessarily the editor for > values. DefaultCellEditor is the perfect example: it's not an editor itself, > it's not even a component, all it does is configures a delegate, a > JComponent,

Re: RFR: 8278050: Armenian text isn't rendered on macOS if text layout is performed

2021-12-15 Thread Sergey Bylokhov
On Wed, 1 Dec 2021 10:52:38 GMT, Dmitry Batrak wrote: > The problem is related to the implementation of font fallback on macOS, > specifically to the path used when text layout > is performed, i.e. the one using `FontSubstitution` and cascade lists. > `CTFontCopyDefaultCascadeListForLanguages`'

Re: RFR: 8278050: Armenian text isn't rendered on macOS if text layout is performed

2021-12-15 Thread Sergey Bylokhov
On Wed, 15 Dec 2021 08:49:04 GMT, Dmitry Batrak wrote: >> src/java.desktop/macosx/classes/sun/font/CFontManager.java line 337: >> >>> 335: // These fonts are present in [NSFontManager >>> availableFonts] output though, >>> 336: // and can be accessed in the same way as o

Re: RFR: 6496103: isFileHidingEnabled return false by default [v2]

2021-12-15 Thread Tejesh R
On Wed, 15 Dec 2021 23:11:34 GMT, Sergey Bylokhov wrote: >> Sure @mrserb , updated the PR. > > Not sure the "native" is needed in the new version, any other thoughts from > anyone? Yeah, "native OS" and "OS" gives same meaning I guess.. - PR: https://git.openjdk.java.net/jdk/pull/

Integrated: 8278050: Armenian text isn't rendered on macOS if text layout is performed

2021-12-15 Thread Dmitry Batrak
On Wed, 1 Dec 2021 10:52:38 GMT, Dmitry Batrak wrote: > The problem is related to the implementation of font fallback on macOS, > specifically to the path used when text layout > is performed, i.e. the one using `FontSubstitution` and cascade lists. > `CTFontCopyDefaultCascadeListForLanguages`'