[jdk18] RFR: 8278472: Invalid value set to CANDIDATEFORM structure

2021-12-21 Thread Alexey Ivanov
According to the Windows API reference, `dwStyle` of [`CANDIDATEFORM`](https://docs.microsoft.com/en-us/windows/win32/api/imm/ns-imm-candidateform) structure should be set to `CFS_CANDIDATEPOS` or `CFS_EXCLUDE`. So, `CFS_POINT` is wrong here. There are two instances in `AwtComponent::SetCandida

RFR: Merge jdk18

2021-12-21 Thread Jesper Wilhelmsson
Forwardport JDK 18 -> JDK 19 - Commit messages: - Merge - 8278627: Shenandoah: TestHeapDump test failed - 8279074: ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macosx-aarch64 - 8278044: ObjectInputStream methods invoking the OIF.CFG.getSerialFilterFactory() s

Re: RFR: 6496103: isFileHidingEnabled return false by default [v3]

2021-12-21 Thread Alexey Ivanov
On Mon, 20 Dec 2021 06:54:56 GMT, Tejesh R wrote: >> The default value of this property is derived from native platform. The same >> is updated in the documentation. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > 6496103: isF

Re: RFR: 6465404: some problems in CellEditor related API docs [v5]

2021-12-21 Thread Alexey Ivanov
On Tue, 21 Dec 2021 02:00:32 GMT, Sergey Bylokhov wrote: >>> After going on through the example, what I felt is "Adds to CellEditor the >>> extensions necessary to configure an editor in a tree" is little generic >>> description than the updated PR Definition. >> >> The interface is generic, s

Re: RFR: 6465404: some problems in CellEditor related API docs [v5]

2021-12-21 Thread Alexey Ivanov
On Fri, 17 Dec 2021 22:19:46 GMT, Phil Race wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 6465404: some problems in CellEditor related API docs > > src/java.desktop/share/classes/javax/swing/table/TableCellEditor.jav

Re: RFR: 6465404: some problems in CellEditor related API docs [v5]

2021-12-21 Thread Alexey Ivanov
On Tue, 21 Dec 2021 21:01:32 GMT, Alexey Ivanov wrote: >>> No, they don't. At the same time `TableCellEditor` interface can't be used >>> to return a cell editor for `JComboBox` and for `JTree` components. These >>> components use `ComboBoxEditor` and `TreeCellEditor` correspondingly. >> >> Ri

Re: RFR: 6465404: some problems in CellEditor related API docs [v5]

2021-12-21 Thread Alexey Ivanov
On Tue, 21 Dec 2021 21:12:57 GMT, Alexey Ivanov wrote: >> src/java.desktop/share/classes/javax/swing/table/TableCellEditor.java line >> 34: >> >>> 32: /** >>> 33: * This interface defines the method any object that would like to be >>> 34: * an editor of values for the {@code JTable} componen

Re: RFR: 6465404: some problems in CellEditor related API docs [v5]

2021-12-21 Thread Alexey Ivanov
On Thu, 9 Dec 2021 13:31:38 GMT, Tejesh R wrote: >> JListBox is invalid component. CellTableEditor Interface doesn't support >> JComboBox and JTree components. Hence its removed from Documentation. > > Tejesh R has updated the pull request incrementally with one additional > commit since the la

Re: RFR: Merge jdk18 [v2]

2021-12-21 Thread Jesper Wilhelmsson
> Forwardport JDK 18 -> JDK 19 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 96 commits: - Merge - 8279043: Some Security Exception Messages Miss Spaces Reviewed-by: weijun - 8278793: Interpreter(x64) in

Integrated: Merge jdk18

2021-12-21 Thread Jesper Wilhelmsson
On Tue, 21 Dec 2021 19:50:51 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 18 -> JDK 19 This pull request has now been integrated. Changeset: 803cb8a7 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/803cb8a76827a21fcf9e033b4ca6a777c509169b Stats: 1086

Re: RFR: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled [v3]

2021-12-21 Thread Toshio Nakamura
On Thu, 21 Oct 2021 00:57:47 GMT, Toshio Nakamura wrote: >> Hi, >> >> Could you review the fix? >> When non-English characters were printed from JTable on MacOS, >> CTextPipe.doDrawGlyphs was called by OSXSurfaceData.drawGlyphs. However, >> CTextPipe seems not support glyph with slot number of