On Tue, 11 Jan 2022 05:51:10 GMT, Sergey Bylokhov wrote:
> Just to clarify, according to your investigation the "CFStringNormalize" is
> not needed to use for the file names?
I didn't state that. AFAIU, in most typical cases, file names come from OS in
NFD form, and `CFStringNormalize` does co
> Hello, please review this adjustment for recent SUSE Linux 15.
> The font coding on UNIX, see setOsNameAndVersion in files
>
> src/java.desktop/unix/classes/sun/font/FcFontConfiguration.java
> src/java.desktop/unix/classes/sun/font/MFontConfiguration.java
>
> uses the file /etc/SuSE-release to
On Tue, 4 Jan 2022 14:14:46 GMT, Matthias Baesken wrote:
> Hello, please review this adjustment for recent SUSE Linux 15.
> The font coding on UNIX, see setOsNameAndVersion in files
>
> src/java.desktop/unix/classes/sun/font/FcFontConfiguration.java
> src/java.desktop/unix/classes/sun/font/MFon
> Hello, please review this adjustment for recent SUSE Linux 15.
> The font coding on UNIX, see setOsNameAndVersion in files
>
> src/java.desktop/unix/classes/sun/font/FcFontConfiguration.java
> src/java.desktop/unix/classes/sun/font/MFontConfiguration.java
>
> uses the file /etc/SuSE-release to
On Tue, 11 Jan 2022 08:35:58 GMT, Matthias Baesken wrote:
>> Hello, please review this adjustment for recent SUSE Linux 15.
>> The font coding on UNIX, see setOsNameAndVersion in files
>>
>> src/java.desktop/unix/classes/sun/font/FcFontConfiguration.java
>> src/java.desktop/unix/classes/sun/fon
Fix the typo in the constructor for BasicFileChooserUI.DoubleClickListener:
‘Constucts’ → ‘Constructs’.
Also fixed the typo in the parameter of the constructor: ‘the lsit’ → ‘the
list’.
I also organised the imports which replaced all wildcard imports with specific
class imports.
-
A number of methods in BasicTabbedPaneUI uses the imperative form of the verb
in the documentation instead of the third-person form which describes what the
method does.
For consistency, I updated such descriptions to use the third-person form of
the verb.
I fixed a couple of typos as well.
I
Fixed the typo in the layout methods: “Laysouts a…” → “Lays out a…”.
The doc for `layoutHScrollbar` incorrectly referred to _vertical_ scroll bar
rather than horizontal one.
I also expanded the wildcard imports.
-
Commit messages:
- 8279794: Fix typos in BasicScrollBarUI: Laysout
On Tue, 11 Jan 2022 12:13:49 GMT, Matthias Baesken wrote:
>> Hello, please review this adjustment for recent SUSE Linux 15.
>> The font coding on UNIX, see setOsNameAndVersion in files
>>
>> src/java.desktop/unix/classes/sun/font/FcFontConfiguration.java
>> src/java.desktop/unix/classes/sun/fon
The protected methods `paintTab` and `paintFocusIndicator` accept the `rect`
parameter which is documented as _“rectangles”_. I suggest updating this
description to a more descriptive: _“the tab rectangles”_ as the array contains
the coordinates of the tabs.
Similarly, the documentation for `as
On Tue, 11 Jan 2022 07:04:51 GMT, Phil Race wrote:
> An initial question, which look and feel are we expected to test? Do we need
> to cover the default one, or it is up to someone to pass the correct L&F?
This current implementation does not do anything to support different LAFs.
A test execu
fixed test bug, removed extra ActionEvent from TrayIcon
-
Commit messages:
- 8279879: [TESTBUG] [macos] ActionEvent triggered when right-clicking TrayIcon
Changes: https://git.openjdk.java.net/jdk/pull/7035/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7035&range=00
On Tue, 11 Jan 2022 19:29:11 GMT, Alisen Chung wrote:
> fixed test bug, removed extra ActionEvent from TrayIcon
Hi @prrace, please review
-
PR: https://git.openjdk.java.net/jdk/pull/7035
On Mon, 10 Jan 2022 16:59:28 GMT, Alisen Chung wrote:
>> Adjusted the AquaLF scrollbar to account for border inset settings when
>> dragging the thumb and clicking on the track.
>
> Alisen Chung has updated the pull request with a new target base due to a
> merge or a rebase. The incremental we
On Mon, 10 Jan 2022 16:59:28 GMT, Alisen Chung wrote:
>> Adjusted the AquaLF scrollbar to account for border inset settings when
>> dragging the thumb and clicking on the track.
>
> Alisen Chung has updated the pull request with a new target base due to a
> merge or a rebase. The incremental we
On Tue, 11 Jan 2022 19:29:11 GMT, Alisen Chung wrote:
> fixed test bug, removed extra ActionEvent from TrayIcon
@azvegint please review
-
PR: https://git.openjdk.java.net/jdk/pull/7035
> Adjusted the AquaLF scrollbar to account for border inset settings when
> dragging the thumb and clicking on the track.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
updated copyright dates, updated test and fix to also check ver
On Tue, 11 Jan 2022 19:29:11 GMT, Alisen Chung wrote:
> fixed test bug, removed extra ActionEvent from TrayIcon
Why it is marked as a test bug if the JDK code changed?
-
PR: https://git.openjdk.java.net/jdk/pull/7035
On Tue, 11 Jan 2022 15:25:37 GMT, Alexey Ivanov wrote:
> Fix the typo in the constructor for BasicFileChooserUI.DoubleClickListener:
> ‘Constucts’ → ‘Constructs’.
> Also fixed the typo in the parameter of the constructor: ‘the lsit’ → ‘the
> list’.
>
> I also organised the imports which replac
On Tue, 11 Jan 2022 19:04:42 GMT, Alexandre Iline
wrote:
> This current implementation does not do anything to support different LAFs.
Even if it is do nothing for the L&F by itself it is expected that these test
passed on the
-
PR: https://git.openjdk.java.net/jdk/pull/6993
On Tue, 11 Jan 2022 19:29:11 GMT, Alisen Chung wrote:
> fixed test bug, removed extra ActionEvent from TrayIcon
test/jdk/java/awt/TrayIcon/RightClickWhenBalloonDisplayed/RightClickWhenBalloonDisplayed.java
line 113:
> 111: robot.mouseRelease(InputEvent.BUTTON3_DOWN_MASK);
> 112:
On Thu, 16 Dec 2021 15:53:26 GMT, Dmitry Batrak wrote:
> The fix just removes the explicit normalization of text obtained from system
> clipboard in JDK code, as I've found no
> good justification for such a normalization, at least for the latest macOS
> version.
> The same fix was performed in
On Mon, 20 Dec 2021 06:54:56 GMT, Tejesh R wrote:
>> The default value of this property is derived from native platform. The same
>> is updated in the documentation.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 6496103: isF
On Thu, 9 Dec 2021 09:40:38 GMT, Tejesh R wrote:
> The default value of this property is derived from native platform. The same
> is updated in the documentation.
This pull request has now been integrated.
Changeset: 13bfb497
Author:TejeshR13
Committer: Jayathirth D V
URL:
https:/
On Tue, 26 Oct 2021 04:52:37 GMT, Sergey Bylokhov wrote:
>> Masanori Yano has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> com
On Thu, 28 Oct 2021 08:27:44 GMT, Masanori Yano wrote:
>> Could you please review the 8275715 bug fixes?
>>
>> I think D3DScreenUpdateManager posts unnecessary PaintEvent during
>> processing PaintEvent. When the validate method is called from
>> createGraphics, repaintPeerTarget should not be
On Fri, 10 Dec 2021 08:59:55 GMT, Masanori Yano wrote:
> I would like to fix the bug reported in JDK-8277463.
>
> As reporter's investigation, ShellFolder.getNormalizedFile() returns
> incorrect value for non-canonical Windows UNC path. getNormalizedFile() is
> used for symbolic link path, but
27 matches
Mail list logo
