Re: RFR: JDK-8279641: Create manual JTReg tests for Swing accessibility

2022-01-12 Thread Alexandre Iline
On Wed, 12 Jan 2022 03:03:41 GMT, Sergey Bylokhov wrote: > > This current implementation does not do anything to support different LAFs. > > Even if the tests do nothing it is expected that these tests will pass on the > default L&Fs like Aqua/Metal. If it is expected to pass on all L&F why not

Re: RFR: 8279879: [macos] ActionEvent triggered when right-clicking TrayIcon

2022-01-12 Thread Alisen Chung
On Wed, 12 Jan 2022 03:25:53 GMT, Sergey Bylokhov wrote: >> fixed test bug, removed extra ActionEvent from TrayIcon > > test/jdk/java/awt/TrayIcon/RightClickWhenBalloonDisplayed/RightClickWhenBalloonDisplayed.java > line 113: > >> 111: robot.mouseRelease(InputEvent.BUTTON3_DOWN_MASK); >

Re: RFR: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel [v13]

2022-01-12 Thread Alisen Chung
On Tue, 11 Jan 2022 20:58:05 GMT, Alisen Chung wrote: >> Adjusted the AquaLF scrollbar to account for border inset settings when >> dragging the thumb and clicking on the track. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8277817: java/awt/dnd/BadSerializationTest/BadSerializationTest.java failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy [v10]

2022-01-12 Thread Liam Miller-Cushon
> This change updates the serialized objects used by > `java/awt/dnd/BadSerializationTest/BadSerializationTest.java` using a similar > approach to the previous fix in > [JDK-8039082](https://bugs.openjdk.java.net/browse/JDK-8039082). Liam Miller-Cushon has updated the pull request with a new ta

Re: RFR: 8277817: java/awt/dnd/BadSerializationTest/BadSerializationTest.java failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy [v9]

2022-01-12 Thread Liam Miller-Cushon
On Fri, 10 Dec 2021 17:03:49 GMT, Liam Miller-Cushon wrote: >> This change updates the serialized objects used by >> `java/awt/dnd/BadSerializationTest/BadSerializationTest.java` using a >> similar approach to the previous fix in >> [JDK-8039082](https://bugs.openjdk.java.net/browse/JDK-803908

Re: RFR: 8279879: [macos] ActionEvent triggered when right-clicking TrayIcon

2022-01-12 Thread Alexander Zvegintsev
On Wed, 12 Jan 2022 16:53:00 GMT, Alisen Chung wrote: >> test/jdk/java/awt/TrayIcon/RightClickWhenBalloonDisplayed/RightClickWhenBalloonDisplayed.java >> line 113: >> >>> 111: robot.mouseRelease(InputEvent.BUTTON3_DOWN_MASK); >>> 112: robot.delay(1000); >>> 113: robot.wa

Re: RFR: JDK-8279641: Create manual JTReg tests for Swing accessibility

2022-01-12 Thread Sergey Bylokhov
On Sat, 8 Jan 2022 00:42:18 GMT, Alexandre Iline wrote: > Tests are based on SwingSet2 application. > Test instructions are loaded from HTML files. > > See readme for more info. Marked as reviewed by serb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6993

Re: RFR: 8277817: java/awt/dnd/BadSerializationTest/BadSerializationTest.java failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy [v10]

2022-01-12 Thread Liam Miller-Cushon
On Wed, 12 Jan 2022 18:14:45 GMT, Liam Miller-Cushon wrote: >> This change updates the serialized objects used by >> `java/awt/dnd/BadSerializationTest/BadSerializationTest.java` using a >> similar approach to the previous fix in >> [JDK-8039082](https://bugs.openjdk.java.net/browse/JDK-803908

Re: RFR: 8277817: java/awt/dnd/BadSerializationTest/BadSerializationTest.java failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy [v10]

2022-01-12 Thread Sergey Bylokhov
On Wed, 12 Jan 2022 18:14:45 GMT, Liam Miller-Cushon wrote: >> This change updates the serialized objects used by >> `java/awt/dnd/BadSerializationTest/BadSerializationTest.java` using a >> similar approach to the previous fix in >> [JDK-8039082](https://bugs.openjdk.java.net/browse/JDK-803908

Re: RFR: 8277817: java/awt/dnd/BadSerializationTest/BadSerializationTest.java failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy [v10]

2022-01-12 Thread Liam Miller-Cushon
On Thu, 13 Jan 2022 02:41:05 GMT, Sergey Bylokhov wrote: > just regenerate the data in this test Based on https://github.com/openjdk/jdk/pull/6603#issuecomment-991295599 and https://github.com/openjdk/jdk/pull/6603#issuecomment-991311158, I thought we didn't want to rely on checking in the ser

RFR: 8279894: javax/swing/JInternalFrame/8020708/bug8020708.java timeouts on Windows 11

2022-01-12 Thread Prasanta Sadhukhan
Test is timing out on slower windows11 CI system. Increased the timeout and also adjusted autodelay time to more consistent time with other headful tests which makes test pass in windows11. Test job link in JBS. - Commit messages: - 8279894: javax/swing/JInternalFrame/8020708/bug80