On Tue, 4 Jan 2022 14:14:46 GMT, Matthias Baesken wrote:
> Hello, please review this adjustment for recent SUSE Linux 15.
> The font coding on UNIX, see setOsNameAndVersion in files
>
> src/java.desktop/unix/classes/sun/font/FcFontConfiguration.java
> src/java.desktop/unix/classes/sun/font/MFon
On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, ` ` in ImageInputSt
On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, ` ` in ImageInputSt
On Mon, 10 Jan 2022 20:46:36 GMT, Andrey Turbanov wrote:
> `Properties.load` uses `java.util.Properties.LineReader`. LineReader already
> buffers input stream. Hence wrapping InputStream in BufferedInputStream is
> redundant.
The code change looks fine, but can you please check the actual perf
`Properties.load` uses `java.util.Properties.LineReader`. LineReader already
buffers input stream. Hence wrapping InputStream in BufferedInputStream is
redundant.
-
Commit messages:
- [PATCH] Remove double buffering of InputStream for Properties.load
- [PATCH] Remove double buffer
On Mon, 10 Jan 2022 20:46:36 GMT, Andrey Turbanov wrote:
> `Properties.load` uses `java.util.Properties.LineReader`. LineReader already
> buffers input stream. Hence wrapping InputStream in BufferedInputStream is
> redundant.
Checked. `BufferedInputStream` add a bit of overhead.
Benchmark
@B
On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, ` ` in ImageInputSt
On Mon, 10 Jan 2022 20:46:36 GMT, Andrey Turbanov wrote:
> `Properties.load` uses `java.util.Properties.LineReader`. LineReader already
> buffers input stream. Hence wrapping InputStream in BufferedInputStream is
> redundant.
Marked as reviewed by amenkov (Reviewer).
-
PR: https:
On Mon, 10 Jan 2022 20:46:36 GMT, Andrey Turbanov wrote:
> `Properties.load` uses `java.util.Properties.LineReader`. LineReader already
> buffers input stream. Hence wrapping InputStream in BufferedInputStream is
> redundant.
Changes to `java.util.logging` look fine.
-
PR: https:
On Tue, 24 Aug 2021 15:49:00 GMT, Alexander Scherbatiy
wrote:
>> The issue is reproduced on macOS Big Sur 11.0.1 with jdk 16.0.1+9.
>>
>> Create a native macOS app from the Hello.java file, sign and run it in
>> sandbox:
>>
>> import javax.print.*;
>> import javax.swing.*;
>>
>> public class
On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, ` ` in ImageInputSt
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, ` ` in ImageInputStream
> Perform scaling while converting sizes and coordinates to provide correct
> positions of accessible elements on HiDPI screen and make hit-test work
> properly. It uses FontRenderContext to receive display scale without API
> changes.
Aleksandr Veselov has updated the pull request incrementall
On Fri, 14 Jan 2022 17:31:09 GMT, Aleksandr Veselov
wrote:
>> Perform scaling while converting sizes and coordinates to provide correct
>> positions of accessible elements on HiDPI screen and make hit-test work
>> properly. It uses FontRenderContext to receive display scale without API
>> cha
On Mon, 10 Jan 2022 20:46:36 GMT, Andrey Turbanov wrote:
> `Properties.load` uses `java.util.Properties.LineReader`. LineReader already
> buffers input stream. Hence wrapping InputStream in BufferedInputStream is
> redundant.
Marked as reviewed by sspitsyn (Reviewer).
-
PR: https
Method `Class.isAssignableFrom` is often used in form of:
if (clazz.isAssignableFrom(obj.getClass())) {
Such condition could be simplified to more shorter and performarnt code
if (clazz.isInstance(obj)) {
Replacement is equivalent if it's known that `obj != null`.
In JDK codebase the
On Thu, 13 Jan 2022 08:25:22 GMT, Andrey Turbanov wrote:
> Method `Class.isAssignableFrom` is often used in form of:
>
> if (clazz.isAssignableFrom(obj.getClass())) {
> Such condition could be simplified to more shorter and performarnt code
>
> if (clazz.isInstance(obj)) {
>
> Repl
Some more signal handler related warning strings from the VM need to be
excluded from what this test considers a failure
See the bug for more info.
-
Commit messages:
- 8279878: java/awt/font/JNICheck/JNICheck.sh test fails on Ubuntu 21.10
Changes: https://git.openjdk.java.net/jd
On Mon, 13 Sep 2021 11:32:37 GMT, Masanori Yano wrote:
> Could you please review the 7001973 fixes?
>
> On Windows, CopyAreaOOB.java fails with a blank window. The cause of this
> problem is that paint() works one time only. Painting area is not guaranteed
> when showing a window.
>
> I think
On Fri, 14 Jan 2022 19:09:53 GMT, Phil Race wrote:
> Some more signal handler related warning strings from the VM need to be
> excluded from what this test considers a failure
>
> See the bug for more info.
Maybe we can ask some ppl from the hotspot team about this issue, is it a
critical th
On Thu, 13 Jan 2022 07:44:48 GMT, Prasanta Sadhukhan
wrote:
> Test is timing out on slower windows11 CI system. Increased the timeout and
> also adjusted autodelay time to more consistent time with other headful tests
> which makes test pass in windows11.
> Test job link in JBS.
Marked as rev
On Mon, 10 Jan 2022 20:46:36 GMT, Andrey Turbanov wrote:
> `Properties.load` uses `java.util.Properties.LineReader`. LineReader already
> buffers input stream. Hence wrapping InputStream in BufferedInputStream is
> redundant.
Marked as reviewed by serb (Reviewer).
-
PR: https://g
Missing comma in test/jdk/java/awt/Graphics2D/CopyAreaOOB.java after
JDK-7001973.
-
Commit messages:
- Update CopyAreaOOB.java
Changes: https://git.openjdk.java.net/jdk/pull/7095/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7095&range=00
Issue: https://bugs.openjd
On Sat, 15 Jan 2022 03:14:33 GMT, Mikael Vidstedt wrote:
> Missing comma in test/jdk/java/awt/Graphics2D/CopyAreaOOB.java after
> JDK-7001973.
This pull request has now been integrated.
Changeset: 9a18190a
Author:Mikael Vidstedt
URL:
https://git.openjdk.java.net/jdk/commit/9a18190a
On Sat, 15 Jan 2022 03:14:33 GMT, Mikael Vidstedt wrote:
> Missing comma in test/jdk/java/awt/Graphics2D/CopyAreaOOB.java after
> JDK-7001973.
Marked as reviewed by prr (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7095
On Fri, 14 Jan 2022 19:09:53 GMT, Phil Race wrote:
> Some more signal handler related warning strings from the VM need to be
> excluded from what this test considers a failure
>
> See the bug for more info.
In hotspot, we want to explicitly ignore SIGPIPE and SIGXFSZ (see
https://bugs.openjd
26 matches
Mail list logo
