Re: RFR: 8275715: D3D pipeline processes multiple PaintEvent at initial drawing [v2]

2022-02-01 Thread Masanori Yano
On Thu, 28 Oct 2021 08:27:44 GMT, Masanori Yano wrote: >> Could you please review the 8275715 bug fixes? >> >> I think D3DScreenUpdateManager posts unnecessary PaintEvent during >> processing PaintEvent. When the validate method is called from >> createGraphics, repaintPeerTarget should not be

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS [v2]

2022-02-01 Thread Sergey Bylokhov
> In JDK 9 the native code for the robot class was reworked to get an access to > the HiDPI quality screenshots. So we allocate the data storage for the HiDPI > quality and then request the best quality from the macOS. > > It works fine if the user request the screenshot of some area, since we

Re: RFR: 8279586: [macos] custom JCheckBox and JRadioBox with custom icon set: focus is still displayed after unchecking

2022-02-01 Thread Alexander Zvegintsev
On Mon, 31 Jan 2022 09:44:43 GMT, Alexander Zuev wrote: > Make border painting for the check boxes and radio buttons with custom icons > take into account the property that enables or disables the focus painting. > Add that case to the test. Marked as reviewed by azvegint (Reviewer). --

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v7]

2022-02-01 Thread Prasanta Sadhukhan
> The changes done under JDK-8278175 suppress on a per-file basis various > missing comments that would otherwise trigger doclint warnings. Fixed them so > as to remove the doclint:missing warnings. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since t

Re: RFR: 8279586: [macos] custom JCheckBox and JRadioBox with custom icon set: focus is still displayed after unchecking

2022-02-01 Thread Alexander Zuev
On Tue, 1 Feb 2022 03:11:38 GMT, Sergey Bylokhov wrote: > Looks fine, BTW we can improve this test by checking all installed L&Fs. Not this time. I created separate bug JDK-8281033 and will improve that test in nearest future, right now i'm trying to fix the accessibility issue to remove it fr

Integrated: 8279586: [macos] custom JCheckBox and JRadioBox with custom icon set: focus is still displayed after unchecking

2022-02-01 Thread Alexander Zuev
On Mon, 31 Jan 2022 09:44:43 GMT, Alexander Zuev wrote: > Make border painting for the check boxes and radio buttons with custom icons > take into account the property that enables or disables the focus painting. > Add that case to the test. This pull request has now been integrated. Changeset:

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v7]

2022-02-01 Thread Alexey Ivanov
On Tue, 1 Feb 2022 09:40:10 GMT, Prasanta Sadhukhan wrote: >> The changes done under JDK-8278175 suppress on a per-file basis various >> missing comments that would otherwise trigger doclint warnings. Fixed them >> so as to remove the doclint:missing warnings. > > Prasanta Sadhukhan has update

Re: RFR: 8277817: java/awt/dnd/BadSerializationTest/BadSerializationTest.java failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy [v10]

2022-02-01 Thread Liam Miller-Cushon
On Wed, 12 Jan 2022 18:14:45 GMT, Liam Miller-Cushon wrote: >> This change updates the serialized objects used by >> `java/awt/dnd/BadSerializationTest/BadSerializationTest.java` using a >> similar approach to the previous fix in >> [JDK-8039082](https://bugs.openjdk.java.net/browse/JDK-803908

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS [v2]

2022-02-01 Thread Sergey Bylokhov
On Tue, 1 Feb 2022 08:15:53 GMT, Sergey Bylokhov wrote: >> In JDK 9 the native code for the robot class was reworked to get an access >> to the HiDPI quality screenshots. So we allocate the data storage for the >> HiDPI quality and then request the best quality from the macOS. >> >> It works f

RFR: 8185261: Font fallback sometimes doesn't work in Swing text components

2022-02-01 Thread Dmitry Batrak
The proposed fix makes fonts with and without fallback components distinguishable (in terms of `equals` method), so that font metrics cache (and other similar code) can handle them separately. This is achieved by adding a new boolean field to `Font` class, specifically denoting fonts with fallbac

Re: RFR: 8280913: Create a regression test for JRootPane.setDefaultButton() method [v3]

2022-02-01 Thread Artem Semenov
On Tue, 1 Feb 2022 07:01:54 GMT, Manukumar V S wrote: >> Manukumar V S has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8280913: Create a regression test for JRootPane.setDefaultButton() method > > @savoptik Can you please review it. @ma

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components

2022-02-01 Thread Sergey Bylokhov
On Tue, 1 Feb 2022 18:38:39 GMT, Dmitry Batrak wrote: > The proposed fix makes fonts with and without fallback components > distinguishable (in terms of `equals` method), so that > font metrics cache (and other similar code) can handle them separately. This > is achieved by adding a new boolean

Re: RFR: 8277817: java/awt/dnd/BadSerializationTest/BadSerializationTest.java failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy [v10]

2022-02-01 Thread Sergey Bylokhov
On Wed, 12 Jan 2022 18:14:45 GMT, Liam Miller-Cushon wrote: >> This change updates the serialized objects used by >> `java/awt/dnd/BadSerializationTest/BadSerializationTest.java` using a >> similar approach to the previous fix in >> [JDK-8039082](https://bugs.openjdk.java.net/browse/JDK-803908

Re: RFR: 8277817: java/awt/dnd/BadSerializationTest/BadSerializationTest.java failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy [v10]

2022-02-01 Thread Liam Miller-Cushon
On Tue, 1 Feb 2022 21:09:55 GMT, Sergey Bylokhov wrote: > I guess the discussion above suggests extracting the "big" change to the > Swing package you did to the separate fix, I missed in what PR that change > was moved? The larger fix is tracked by [JDK-8278620: properties installed by javax

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components

2022-02-01 Thread Dmitry Batrak
On Tue, 1 Feb 2022 19:47:59 GMT, Sergey Bylokhov wrote: >> The proposed fix makes fonts with and without fallback components >> distinguishable (in terms of `equals` method), so that >> font metrics cache (and other similar code) can handle them separately. This >> is achieved by adding a new b

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components

2022-02-01 Thread Dmitry Batrak
On Tue, 1 Feb 2022 19:50:47 GMT, Sergey Bylokhov wrote: >> The proposed fix makes fonts with and without fallback components >> distinguishable (in terms of `equals` method), so that >> font metrics cache (and other similar code) can handle them separately. This >> is achieved by adding a new b

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components [v2]

2022-02-01 Thread Dmitry Batrak
> The proposed fix makes fonts with and without fallback components > distinguishable (in terms of `equals` method), so that > font metrics cache (and other similar code) can handle them separately. This > is achieved by adding a new boolean field > to `Font` class, specifically denoting fonts wi

Re: RFR: 8279878: java/awt/font/JNICheck/JNICheck.sh test fails on Ubuntu 21.10

2022-02-01 Thread Sergey Bylokhov
On Fri, 14 Jan 2022 19:09:53 GMT, Phil Race wrote: > Some more signal handler related warning strings from the VM need to be > excluded from what this test considers a failure > > See the bug for more info. So can we file a bug against someone? We should do something about it. -

Re: RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader [v4]

2022-02-01 Thread Harshitha Onkar
On Tue, 1 Feb 2022 04:19:55 GMT, Prasanta Sadhukhan wrote: >> I now see it fail locally in windows system also along with ubuntu. windows >> screenshot here where the border is white which is why it fails >> ![JTheaderBorder](https://user-images.githubusercontent.com/43534309/151753660-92d6021a

Re: RFR: 8280913: Create a regression test for JRootPane.setDefaultButton() method [v3]

2022-02-01 Thread Manukumar V S
On Sun, 30 Jan 2022 06:30:43 GMT, Manukumar V S wrote: >> This tests the behaviour of the method JRootPane.setDefaultButton() in >> different platforms with different LAFs. >> As per the spec >> https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/JRootPane.html#setDefaul