Re: RFR: 8280913: Create a regression test for JRootPane.setDefaultButton() method [v3]

2022-02-03 Thread Abdul Kolarkunnu
On Sun, 30 Jan 2022 06:30:43 GMT, Manukumar V S wrote: >> This tests the behaviour of the method JRootPane.setDefaultButton() in >> different platforms with different LAFs. >> As per the spec >> https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/JRootPane.html#setDefaul

Re: RFR: 8280913: Create a regression test for JRootPane.setDefaultButton() method [v3]

2022-02-03 Thread Abdul Kolarkunnu
On Sun, 30 Jan 2022 06:30:43 GMT, Manukumar V S wrote: >> This tests the behaviour of the method JRootPane.setDefaultButton() in >> different platforms with different LAFs. >> As per the spec >> https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/JRootPane.html#setDefaul

Re: RFR: 8280913: Create a regression test for JRootPane.setDefaultButton() method [v3]

2022-02-03 Thread Abdul Kolarkunnu
On Sun, 30 Jan 2022 06:30:43 GMT, Manukumar V S wrote: >> This tests the behaviour of the method JRootPane.setDefaultButton() in >> different platforms with different LAFs. >> As per the spec >> https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/JRootPane.html#setDefaul

Re: RFR: 8280948: [TESTBUG] Write a regression test for JDK-4659800

2022-02-03 Thread Abdul Kolarkunnu
On Tue, 1 Feb 2022 06:40:17 GMT, Manukumar V S wrote: > Write a regression test for JDK-4659800. > This test checks whether typing 'Space' key generates ActionEvent on focused > Button or not, in all Look And Feels in all platforms. > This test is run 10 times per platform(mac,linux,windows) and

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components [v2]

2022-02-03 Thread Dmitry Batrak
On Wed, 2 Feb 2022 21:29:28 GMT, Sergey Bylokhov wrote: >> src/java.desktop/share/classes/java/awt/Font.java line 1861: >> >>> 1859: pointSize == font.pointSize && >>> 1860: withFallback == font.withFallback && >>> 1861: name.equals(font.name)) { >

Re: RFR: 8280913: Create a regression test for JRootPane.setDefaultButton() method [v4]

2022-02-03 Thread Manukumar V S
> This tests the behaviour of the method JRootPane.setDefaultButton() in > different platforms with different LAFs. > As per the spec > https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/JRootPane.html#setDefaultButton(javax.swing.JButton), > "The default button is the b

Re: RFR: 8280913: Create a regression test for JRootPane.setDefaultButton() method [v3]

2022-02-03 Thread Manukumar V S
On Wed, 2 Feb 2022 16:19:16 GMT, Alexey Ivanov wrote: >> Manukumar V S has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8280913: Create a regression test for JRootPane.setDefaultButton() method > > Changes requested by aivanov (Reviewer).

Re: RFR: 8280913: Create a regression test for JRootPane.setDefaultButton() method [v4]

2022-02-03 Thread Alexey Ivanov
On Thu, 3 Feb 2022 11:20:50 GMT, Manukumar V S wrote: >> This tests the behaviour of the method JRootPane.setDefaultButton() in >> different platforms with different LAFs. >> As per the spec >> https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/JRootPane.html#setDefault

Re: RFR: 8280913: Create a regression test for JRootPane.setDefaultButton() method [v3]

2022-02-03 Thread Alexey Ivanov
On Thu, 3 Feb 2022 09:44:04 GMT, Abdul Kolarkunnu wrote: > Some grammatical mistake in summary @akolarkunnu Could you please clarify where there's a grammatical mistake or suggest a correct summary text? - PR: https://git.openjdk.java.net/jdk/pull/7278

Re: RFR: 8280913: Create a regression test for JRootPane.setDefaultButton() method [v4]

2022-02-03 Thread Alexey Ivanov
On Thu, 3 Feb 2022 11:20:50 GMT, Manukumar V S wrote: >> This tests the behaviour of the method JRootPane.setDefaultButton() in >> different platforms with different LAFs. >> As per the spec >> https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/JRootPane.html#setDefault

Re: RFR: 8280948: [TESTBUG] Write a regression test for JDK-4659800

2022-02-03 Thread Alexey Ivanov
On Tue, 1 Feb 2022 06:40:17 GMT, Manukumar V S wrote: > Write a regression test for JDK-4659800. > This test checks whether typing 'Space' key generates ActionEvent on focused > Button or not, in all Look And Feels in all platforms. > This test is run 10 times per platform(mac,linux,windows) and

Re: RFR: 8280948: [TESTBUG] Write a regression test for JDK-4659800

2022-02-03 Thread Alexey Ivanov
On Tue, 1 Feb 2022 06:40:17 GMT, Manukumar V S wrote: > Write a regression test for JDK-4659800. > This test checks whether typing 'Space' key generates ActionEvent on focused > Button or not, in all Look And Feels in all platforms. > This test is run 10 times per platform(mac,linux,windows) and

Re: RFR: 8280948: [TESTBUG] Write a regression test for JDK-4659800

2022-02-03 Thread Manukumar V S
On Thu, 3 Feb 2022 15:24:25 GMT, Alexey Ivanov wrote: > I must be missing something but > [JDK-4659800](https://bugs.openjdk.java.net/browse/JDK-4659800) talks about > the Enter key, not the Space key: _Hitting enter on focused JButton no longer > causes action_. > > It looks you're testing a

Re: RFR: 8280948: [TESTBUG] Write a regression test for JDK-4659800

2022-02-03 Thread Alexey Ivanov
On Tue, 1 Feb 2022 06:40:17 GMT, Manukumar V S wrote: > Write a regression test for JDK-4659800. > This test checks whether typing 'Space' key generates ActionEvent on focused > Button or not, in all Look And Feels in all platforms. > This test is run 10 times per platform(mac,linux,windows) and

Re: RFR: 8280948: [TESTBUG] Write a regression test for JDK-4659800 [v2]

2022-02-03 Thread Manukumar V S
> Write a regression test for JDK-4659800. > This test checks whether typing 'Space' key generates ActionEvent on focused > Button or not, in all Look And Feels in all platforms. > This test is run 10 times per platform(mac,linux,windows) and it passed all > the times(30/30). Manukumar V S has u

Re: RFR: 8280913: Create a regression test for JRootPane.setDefaultButton() method [v5]

2022-02-03 Thread Manukumar V S
> This tests the behaviour of the method JRootPane.setDefaultButton() in > different platforms with different LAFs. > As per the spec > https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/JRootPane.html#setDefaultButton(javax.swing.JButton), > "The default button is the b

Re: RFR: 8280913: Create a regression test for JRootPane.setDefaultButton() method [v4]

2022-02-03 Thread Manukumar V S
On Thu, 3 Feb 2022 14:27:57 GMT, Alexey Ivanov wrote: >> Manukumar V S has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8280913: Create a regression test for JRootPane.setDefaultButton() method > > test/jdk/javax/swing/JRootPane/DefaultBu

Re: RFR: 8280948: [TESTBUG] Write a regression test for JDK-4659800 [v3]

2022-02-03 Thread Manukumar V S
> Write a regression test for JDK-4659800. > This test checks whether typing 'Enter' key generates ActionEvent on focused > Button or not, in Windows and Windows Classic Look And Feels in Windows > platform. > This test is run 10 times on windows and it passed all the times. Manukumar V S has up

Re: RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails

2022-02-03 Thread lawrence . andrews
On Tue, 1 Feb 2022 03:16:28 GMT, Sergey Bylokhov wrote: >> 1) Removed =yesno that was causing the test to fail with following exception >> test result: Error. Parse Exception: Arguments to `manual' option not >> supported: yesno >> After removing =yesno, test was just passing without user intera

Re: RFR: 8280913: Create a regression test for JRootPane.setDefaultButton() method [v5]

2022-02-03 Thread Alexey Ivanov
On Thu, 3 Feb 2022 19:06:42 GMT, Manukumar V S wrote: >> This tests the behaviour of the method JRootPane.setDefaultButton() in >> different platforms with different LAFs. >> As per the spec >> https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/JRootPane.html#setDefault

Re: RFR: 8280948: [TESTBUG] Write a regression test for JDK-4659800 [v3]

2022-02-03 Thread Alexey Ivanov
On Thu, 3 Feb 2022 19:10:49 GMT, Manukumar V S wrote: >> Write a regression test for JDK-4659800. >> This test checks whether typing 'Enter' key generates ActionEvent on focused >> Button or not, in Windows and Windows Classic Look And Feels in Windows >> platform. >> This test is run 10 times

Re: RFR: 8015854: [macosx] JButton's HTML ImageView adding unwanted padding [v2]

2022-02-03 Thread DamonGuy
> Html does not fit in JButton at certain sizes because default Insets cause > html to be displayed off-center. > > Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable > clipping if html does not fit, similar to regular text. AquaButtonUI.java now > detects when html d

Re: RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader [v5]

2022-02-03 Thread Harshitha Onkar
> Previously, the JTableHeader Bottom line wasn't visible on MacOS LAF (Aqua). > With the fix the bottom line (light grey) is visible. > > Changes were made to AquaTableHeaderBorder.paintBorder method and the height > of the component+border was adjusted in paint method. > > A new test case (J

Re: RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails

2022-02-03 Thread Phil Race
On Fri, 28 Jan 2022 21:03:48 GMT, lawrence.andrews wrote: > 1) Removed =yesno that was causing the test to fail with following exception > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yesno > After removing =yesno, test was just passing without user interac

Re: RFR: 8015854: [macosx] JButton's HTML ImageView adding unwanted padding [v2]

2022-02-03 Thread DamonGuy
On Thu, 3 Feb 2022 23:35:42 GMT, DamonGuy wrote: >> Html does not fit in JButton at certain sizes because default Insets cause >> html to be displayed off-center. >> >> Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable >> clipping if html does not fit, similar to re

Re: RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader [v5]

2022-02-03 Thread Harshitha Onkar
On Thu, 27 Jan 2022 09:31:21 GMT, Prasanta Sadhukhan wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changed the test case condition and marked the test as mac-only > > test/jdk/javax/swing/JTableHeader/8016524