Integrated: 7017094: ParsedSynthStyle: parameter name "direction" should be changed to "tabIndex"

2022-03-10 Thread Prasanta Sadhukhan
On Mon, 21 Feb 2022 04:59:34 GMT, Prasanta Sadhukhan wrote: > [SynthPainter](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthPainter.java#L1759) > and > [SynthPainterImpl](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/cla

Integrated: 6218162: DefaultTableColumnModel.getColumn() method should mention ArrayIndexOutOfBoundsException

2022-03-10 Thread Prasanta Sadhukhan
On Wed, 23 Feb 2022 11:20:55 GMT, Prasanta Sadhukhan wrote: > If invalid ie 0 or > getColumnCount() index is passed to > DefaultTableColumnModel.getColumn() then it returns AIOBE in current > implementation which should be documented in the spec. Fixed the spec to > mention the exception. Th

Re: RFR: 8282270: java/awt/Robot Screen Capture tests fail after 8280861 [v3]

2022-03-10 Thread Maxim Kartashev
On Wed, 9 Mar 2022 13:35:44 GMT, Maxim Kartashev wrote: >> The two tests `ScreenCaptureGtkTest.java` and >> `HiDPIRobotScreenCaptureTest.java` under `java/awt/Robot/HiDPIScreenCapture` >> started to intermittently fail under Windows and Linux after the [recent >> changes](https://github.com/op

Re: RFR: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled

2022-03-10 Thread Toshio Nakamura
On Fri, 23 Apr 2021 06:49:10 GMT, Sergey Bylokhov wrote: >> Hi, >> >> Could you review the fix? >> When non-English characters were printed from JTable on MacOS, >> CTextPipe.doDrawGlyphs was called by OSXSurfaceData.drawGlyphs. However, >> CTextPipe seems not support glyph with slot number of

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10

2022-03-10 Thread Daniel Fuchs
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote: > msg drop for jdk19, Mar 9, 2022 For simple webserver resource files - should the copyright year be 2022? - PR: https://git.openjdk.java.net/jdk/pull/7765

Re: RFR: 8282270: java/awt/Robot Screen Capture tests fail after 8280861 [v3]

2022-03-10 Thread Alexey Ivanov
On Thu, 10 Mar 2022 09:30:33 GMT, Maxim Kartashev wrote: > The `ScreenCaptureGtkTest` is not supposed to be run with > `-Dsun.java2d.uiScale=3` anymore as we've discovered the problem with precise > window positioning. Let's try this test from [my > branch](https://github.com/mkartashev/jdk/tr

Re: RFR: 8282270: java/awt/Robot Screen Capture tests fail after 8280861 [v3]

2022-03-10 Thread Maxim Kartashev
On Wed, 9 Mar 2022 13:35:44 GMT, Maxim Kartashev wrote: >> The two tests `ScreenCaptureGtkTest.java` and >> `HiDPIRobotScreenCaptureTest.java` under `java/awt/Robot/HiDPIScreenCapture` >> started to intermittently fail under Windows and Linux after the [recent >> changes](https://github.com/op

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-10 Thread Prasanta Sadhukhan
On Wed, 9 Mar 2022 10:04:09 GMT, Tejesh R wrote: > Removed the println() line from the Interrupted catch block. Since > waitForID() Interrupt indicates completion of Image Loading, println as > Interrupt handling was not required. src/java.desktop/share/classes/javax/swing/ImageIcon.java line

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-10 Thread Alexey Ivanov
On Thu, 10 Mar 2022 12:59:47 GMT, Prasanta Sadhukhan wrote: >> Removed the println() line from the Interrupted catch block. Since >> waitForID() Interrupt indicates completion of Image Loading, println as >> Interrupt handling was not required. > > src/java.desktop/share/classes/javax/swing/Im

Re: RFR: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge [v3]

2022-03-10 Thread Anton Litvinov
On Wed, 9 Mar 2022 23:00:37 GMT, Alexey Ivanov wrote: >> Anton Litvinov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> The third version of the fix for JDK-8277922 > > src/java.desktop/share/classes/javax/swing/JTable.java line 8417: >

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-10 Thread Tejesh R
On Thu, 10 Mar 2022 13:19:22 GMT, Alexey Ivanov wrote: >> src/java.desktop/share/classes/javax/swing/ImageIcon.java line 331: >> >>> 329: mTracker.waitForID(id, 0); >>> 330: } catch (InterruptedException e) { >>> 331: System.out.println("INTERRUPTED wh

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-10 Thread Alexey Ivanov
On Thu, 10 Mar 2022 15:30:51 GMT, Tejesh R wrote: >> That was my concern too. In fact, `InterruptedException` is not in the >> regular flow, it indicates a somewhat error condition which isn't actually >> handled. >> >> If `loadStatus` of the image is not `COMPLETE` or `ERRORED`, we should >>

Re: RFR: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge [v3]

2022-03-10 Thread Alexey Ivanov
On Wed, 9 Mar 2022 16:11:02 GMT, Anton Litvinov wrote: >> Hello, >> >> Could you please review the following fix for the bug. The bug consists in >> the fact that When an assistive technology software by means of Java Access >> Bridge API executes "AccessibleAction" "click" on "AccessibleConte

Re: RFR: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge [v3]

2022-03-10 Thread Alexey Ivanov
On Thu, 10 Mar 2022 15:10:42 GMT, Anton Litvinov wrote: >> src/java.desktop/share/classes/javax/swing/JTable.java line 8417: >> >>> 8415: if (ac != null) { >>> 8416: return ac.getAccessibleAction(); >>> 8417: } >> >> This is the fix for possib

Integrated: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge

2022-03-10 Thread Anton Litvinov
On Thu, 10 Feb 2022 04:59:33 GMT, Anton Litvinov wrote: > Hello, > > Could you please review the following fix for the bug. The bug consists in > the fact that When an assistive technology software by means of Java Access > Bridge API executes "AccessibleAction" "click" on "AccessibleContext"

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10

2022-03-10 Thread Naoto Sato
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote: > msg drop for jdk19, Mar 9, 2022 IIRC, localized resource files should have the same copyright year as the base English one. That's what I was told by the l10n engineer when I had the same comment. - PR: https://git.openjdk.ja

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10

2022-03-10 Thread Daniel Fuchs
On Thu, 10 Mar 2022 17:00:09 GMT, Naoto Sato wrote: > IIRC, localized resource files should have the same copyright year as the > base English one. That's what I was told by the l10n engineer when I had the > same comment. Thanks Naoto! I have no objection then. - PR: https://git

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v2]

2022-03-10 Thread Alisen Chung
> msg drop for jdk19, Mar 9, 2022 Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: moved CurrencyNames changes to jdk.localedata - Changes: - all: https://git.openjdk.java.net/jdk/pull/7765/files - new: https://git.op

Re: RFR: 7124282: [macosx] Can't see table cell highlighter when the highlight border is the same color as the cell. [v2]

2022-03-10 Thread Harshitha Onkar
> Previously while tabbing through the JTable cell, the cell highlighter/focus > ring was not visible against the selection background. > > Changes are made to Aqua LAF to derive a brighter focus ring color by > changing hue, saturation and brightness of selection background color so that > it

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v2]

2022-03-10 Thread Chris Plummer
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote: >> msg drop for jdk19, Mar 9, 2022 > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > moved CurrencyNames changes to jdk.localedata src/jdk.jdi/share/classes/com/sun/tools

Re: RFR: 7124282: [macosx] Can't see table cell highlighter when the highlight border is the same color as the cell. [v2]

2022-03-10 Thread Harshitha Onkar
On Thu, 10 Mar 2022 18:23:18 GMT, Harshitha Onkar wrote: >> Previously while tabbing through the JTable cell, the cell highlighter/focus >> ring was not visible against the selection background. >> >> Changes are made to Aqua LAF to derive a brighter focus ring color by >> changing hue, satur

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v2]

2022-03-10 Thread Naoto Sato
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote: >> msg drop for jdk19, Mar 9, 2022 > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > moved CurrencyNames changes to jdk.localedata src/jdk.localedata/share/classes/sun/ut

Client Libraries now has an OpenJDK Wiki Page

2022-03-10 Thread Philip Race
https://wiki.openjdk.java.net/display/ClientLibs is the new group wiki page. Although we do have a  Group page at : https://openjdk.java.net/groups/client-libs/ that web content only editable by Oracle employees whereas the wiki is editable by ANY member of the Client Libraries group listed at

RFR: 8282978: Wrong parameter passed to GetStringXXXChars in various places

2022-03-10 Thread Zhengyu Gu
Another trivial cleanup to fix the last parameter of `GetStringXXXChars` calls, should be a `jboolean*` instead of a `jboolean`. - Commit messages: - Fix - 8282978: Wrong parameter passed to GetStringXXXChars in various places Changes: https://git.openjdk.java.net/jdk/pull/7779/fi

Re: RFR: 7124282: [macosx] Can't see table cell highlighter when the highlight border is the same color as the cell. [v3]

2022-03-10 Thread Harshitha Onkar
> Previously while tabbing through the JTable cell, the cell highlighter/focus > ring was not visible against the selection background. > > Changes are made to Aqua LAF to derive a brighter focus ring color by > changing hue, saturation and brightness of selection background color so that > it

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v3]

2022-03-10 Thread Phil Race
On Fri, 4 Mar 2022 05:07:44 GMT, Prasanta Sadhukhan wrote: >> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced >> Gulim korean font so it needs to be updated to show korean fonts > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional comm

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v3]

2022-03-10 Thread Phil Race
On Fri, 4 Mar 2022 05:07:44 GMT, Prasanta Sadhukhan wrote: >> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced >> Gulim korean font so it needs to be updated to show korean fonts > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional comm

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v3]

2022-03-10 Thread Phil Race
On Fri, 4 Mar 2022 05:07:44 GMT, Prasanta Sadhukhan wrote: >> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced >> Gulim korean font so it needs to be updated to show korean fonts > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional comm

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v3]

2022-03-10 Thread Phil Race
On Sat, 5 Mar 2022 10:35:12 GMT, Dmitry Batrak wrote: >> But serif.plain.korean isn't used unless it is a Korean locale .. so what's >> the point ? >> >> And this one line already added >> allfonts.korean=Malgun Gothic >> will provide it as a fall back so I don't see the need. >> If I am an En

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v3]

2022-03-10 Thread Dmitry Batrak
On Fri, 11 Mar 2022 03:33:38 GMT, Phil Race wrote: > So if you remove the allfonts entry, does it pick up serif.plain.korean (etc) > ? JDK picks up `..korean` entries regardless of whether `allfonts.korean` entry is present - the former take precedence over the latter. Yes, it goes against th

Re: RFR: 8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale

2022-03-10 Thread Ichiroh Takiguchi
On Sat, 26 Feb 2022 16:24:07 GMT, Ichiroh Takiguchi wrote: > On AIX ko_KR locale, I could see following exception after JTable.print() was > called > > java.nio.charset.UnsupportedCharsetException: sun.font.X11KSC5601 > at java.base/java.nio.charset.Charset.forName(Charset.java:527) >