AccessibleJTableCell.isShowing() returns false when the cell is actually on
the screen.
The test validates the fix for the above issue by verifying that the isShowing
call returns true when invoked via the accessiblity context.
-
Commit messages:
- 8282933:Create a test for JDK-452
On Thu, 10 Mar 2022 21:12:46 GMT, Zhengyu Gu wrote:
> Another trivial cleanup to fix the last parameter of `GetStringXXXChars`
> calls, should be a `jboolean*` instead of a `jboolean`.
The changes to the usages in src/java.base look okay.
-
Marked as reviewed by alanb (Reviewer).
On Thu, 10 Mar 2022 21:12:46 GMT, Zhengyu Gu wrote:
> Another trivial cleanup to fix the last parameter of `GetStringXXXChars`
> calls, should be a `jboolean*` instead of a `jboolean`.
Marked as reviewed by dfuchs (Reviewer).
The `libnet` changes look good to me - but please get someone from t
On Thu, 3 Mar 2022 07:46:27 GMT, Prasanta Sadhukhan
wrote:
>> There's no chaining mechanism in the way you describe it .. it would have to
>> be in our fallback list.
>>
>> Batang and Gulim are the fonts that have been available since .. well at
>> least XP.
>>
>> https://docs.microsoft.com/
On Fri, 4 Mar 2022 05:07:44 GMT, Prasanta Sadhukhan
wrote:
>> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced
>> Gulim korean font so it needs to be updated to show korean fonts
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional comm
On Fri, 11 Mar 2022 12:47:28 GMT, Prasanta Sadhukhan
wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert dialogInput. Add Bolditalic
>
> I tested with this test and I got the following output which seems
On Fri, 11 Mar 2022 12:47:28 GMT, Prasanta Sadhukhan
wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert dialogInput. Add Bolditalic
>
> I tested with this test and I got the following output which seems
On Fri, 11 Mar 2022 10:33:29 GMT, Alan Bateman wrote:
>> Another trivial cleanup to fix the last parameter of `GetStringXXXChars`
>> calls, should be a `jboolean*` instead of a `jboolean`.
>
> The changes to the usages in src/java.base look okay.
Thanks, @AlanBateman @dfuch
-
PR:
On Thu, 10 Mar 2022 21:12:46 GMT, Zhengyu Gu wrote:
> Another trivial cleanup to fix the last parameter of `GetStringXXXChars`
> calls, should be a `jboolean*` instead of a `jboolean`.
This pull request has now been integrated.
Changeset: 0fd09d38
Author:Zhengyu Gu
URL:
https://git
On Fri, 11 Mar 2022 10:33:29 GMT, Alan Bateman wrote:
>> Another trivial cleanup to fix the last parameter of `GetStringXXXChars`
>> calls, should be a `jboolean*` instead of a `jboolean`.
>
> The changes to the usages in src/java.base look okay.
> Thanks, @AlanBateman @dfuch
but make sure to
On Mon, 28 Feb 2022 11:57:41 GMT, Srinivas Mandalika
wrote:
>> Create a regression test for CCC8000326
>>
>> Issue is identified by
>> [JDK-8000326](https://bugs.openjdk.java.net/browse/JDK-8000326), which
>> identifies that after focus moves into JMenuBar, whose focus traversal key
>> is di
On Fri, 4 Mar 2022 05:35:38 GMT, Srinivas Mandalika
wrote:
> Create a test for
> [JDK-4740761](https://bugs.openjdk.java.net/browse/JDK-4740761)
>
> The issue observed is in a JFrame with a JTextField and a JScrollPane which
> contains focused component. When the JScrollPane was
> is removed
Create a test for JDK-4715496
Issue observed in the above bug is that the
JTable.AccessibleJTableCell.getAccessible name returns the cell instance string
instead of the cell text.
The test is being added to verify the same.
This review is for migrating tests from a closed test suite to open.
--
> Create a regression test for CCC8000326
>
> Issue is identified by
> [JDK-8000326](https://bugs.openjdk.java.net/browse/JDK-8000326), which
> identifies that after focus moves into JMenuBar, whose focus traversal key is
> disabled by default, it never moves to other focusable component.
>
>
> Create a test for
> [JDK-4740761](https://bugs.openjdk.java.net/browse/JDK-4740761)
>
> The issue observed is in a JFrame with a JTextField and a JScrollPane which
> contains focused component. When the JScrollPane was
> is removed from its parent, focus stays with the the scroller
> of the re
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote:
>> msg drop for jdk19, Mar 9, 2022
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> moved CurrencyNames changes to jdk.localedata
The security related changes look fine,
> Create a Regression test for
> [JDK-4515031](https://bugs.openjdk.java.net/browse/JDK-4515031)
>
> The issue indicates the need for a a getAccessibleDescription being
> implemented for the JFileChooser.
> The test added verifies the same.
> This review is for migrating tests from a closed test
> Create a regression test for JDK-4699544
>
> The subclass of javax.swing.JRootPane (AccessibleJRootPane) that implements
> the accessibility interface javax.accessibility.AccessibleComponent is
> derived from java.awt.AccessibleAWTComponent, which returns null for
> getAccessibleAt() because
> Create a regression test for
> [JDK-4702690](https://bugs.openjdk.java.net/browse/JDK-4702690)
>
> In many cases in Swing it is possible to easily programatically determine
> that a JScrollBar (or two) is scrolling some JPanel (the cannonical case is a
> JScrollPane).
> In these cases, when a
On Fri, 11 Mar 2022 07:27:32 GMT, Dmitry Batrak wrote:
>> And the allfonts entry does (I am fairly sure) then apply to the fallback
>> sequence
>> if there are no "second form" entries, but regardless it seems odd that
>> fallback
>> entries are ignored because the second form is present, but i
On Fri, 11 Mar 2022 13:23:23 GMT, Zhengyu Gu wrote:
>> The changes to the usages in src/java.base look okay.
>
> Thanks, @AlanBateman @dfuch
@zhengyu123 - why did you ignore the request to wait for a client reviewer ?
Over half the files touched are in client ? Might I ask what tests you ran ?
A
On Fri, 11 Mar 2022 17:53:12 GMT, Phil Race wrote:
> Yes, the sequence.fallback but I am relaying my observation that adding
korean.allfonts=..
did not work even though sequence.fallback lists korean whereas adding
korean-foo.allfonts=..
and adding korean-foo into sequence.fallback DID work.
It'
On Thu, 10 Mar 2022 15:59:26 GMT, Alexey Ivanov wrote:
>> WaitForID() definition states that "If there is an error while loading or
>> scaling an image, then that image is considered to have finished loading".
>> Does this indicates that no error checking is required.?
>
> But in this case
On Wed, 9 Mar 2022 13:35:44 GMT, Maxim Kartashev wrote:
>> The two tests `ScreenCaptureGtkTest.java` and
>> `HiDPIRobotScreenCaptureTest.java` under `java/awt/Robot/HiDPIScreenCapture`
>> started to intermittently fail under Windows and Linux after the [recent
>> changes](https://github.com/op
On Fri, 4 Mar 2022 00:49:39 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - adjusted pixels to check f
On Fri, 11 Feb 2022 19:20:16 GMT, DamonGuy wrote:
> Updated Parser class doc by appending to the doc regarding lack of support
> for HTML script tags. Adding this information to the "parse" function did not
> seem as consistent for formatting as adding it to the Parser class doc.
What is the c
On Fri, 11 Mar 2022 18:35:21 GMT, Phil Race wrote:
>> But in this case it's the waiting thread that is interrupted. The
>> `MediaTracker` could complete loading the image successfully yet `ImageIcon`
>> instance wouldn't update its `loadStatus` because it removes itself from the
>> media track
On Fri, 11 Mar 2022 19:04:27 GMT, Phil Race wrote:
> What is the current status of this PR ? I can't work it out.
I spent time to double check script tag contents. The script tag's behavior Jay
mentioned is correct from the traces I made as well. So I wrote a test with a
JEditorPane loading HT
On Fri, 11 Feb 2022 19:20:16 GMT, DamonGuy wrote:
> Updated Parser class doc by appending to the doc regarding lack of support
> for HTML script tags. Adding this information to the "parse" function did not
> seem as consistent for formatting as adding it to the Parser class doc.
This pull req
Aqua L&F tables lacked support for `CTRL+ARROW`, `CTRL+PG_UP/DOWN`, and
`CTRL+SHIFT+PG_UP/DOWN` key bindings. This allows for navigation and selection
of table cells without the need of a mouse and without deselecting the current
selected cell group.
Those key bindings are added to Aqua's key
On Fri, 11 Mar 2022 23:13:15 GMT, DamonGuy wrote:
> Aqua L&F tables lacked support for `CTRL+ARROW`, `CTRL+PG_UP/DOWN`, and
> `CTRL+SHIFT+PG_UP/DOWN` key bindings. This allows for navigation and
> selection of table cells without the need of a mouse and without deselecting
> the current select
On Fri, 11 Feb 2022 19:20:16 GMT, DamonGuy wrote:
> Updated Parser class doc by appending to the doc regarding lack of support
> for HTML script tags. Adding this information to the "parse" function did not
> seem as consistent for formatting as adding it to the Parser class doc.
Ok. For futur
On Wed, 21 Jul 2021 15:45:55 GMT, Alexander Scherbatiy
wrote:
> The issue is reproduced on macOS Big Sur 11.0.1 with jdk 16.0.1+9.
>
> Create a native macOS app from the Hello.java file, sign and run it in
> sandbox:
>
> import javax.print.*;
> import javax.swing.*;
>
> public class Hello {
On Sat, 12 Mar 2022 00:07:45 GMT, Sergey Bylokhov wrote:
> What shortcuts are used by the native macOS applications for such navigation?
> Aqua should align bihaviour to the native app and not other cross platform
> L&F or windows/linux.
The only shortcuts that allow for non-adjacent cell sele
34 matches
Mail list logo
