Re: RFR: 7124282: [macosx] Can't see table cell highlighter when the highlight border is the same color as the cell. [v3]

2022-03-25 Thread Prasanta Sadhukhan
On Fri, 25 Mar 2022 00:02:21 GMT, Harshitha Onkar wrote: >> I guess using "color close to selection background color" seems wrong to >> me...either we need to use "blue" as used in native Numbers app...or if we >> need to use system color, then maybe use the accent color (as defined in >> Syst

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v5]

2022-03-25 Thread Tejesh R
On Wed, 23 Mar 2022 18:18:57 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > It looks good now. > > Is it possible to add a regression test? We have one now, don

Re: RFR: 8273355: Flickering on tooltip appearance IntelliJ IDEA 2021.2.1 [v3]

2022-03-25 Thread Alexey Ushakov
> Used setOpaque() method to set correct background of platform window > Extracted setting background to the particular method in PlatformWindow. > Provided appropriate implementation in CPlatformWindow. Alexey Ushakov has updated the pull request incrementally with one additional commit since t

Re: RFR: 8181571: printing to CUPS fails on mac sandbox app [v4]

2022-03-25 Thread Alexander Scherbatiy
> The issue is reproduced on macOS Big Sur 11.0.1 with jdk 16.0.1+9. > > Create a native macOS app from the Hello.java file, sign and run it in > sandbox: > > import javax.print.*; > import javax.swing.*; > > public class Hello { > > public static void main(String[] args) throws Exception

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v7]

2022-03-25 Thread Phil Race
On Thu, 24 Mar 2022 16:20:19 GMT, Alexey Ivanov wrote: > 1. @aivanov-jdk wrote (scroll up a lot) >When uiScale=1.25, you can see there's background color between the shadow > and highlight on the second panel. > > I have no idea where I should be seeing that. I see nothing like that. > Per

Re: RFR: 8181571: printing to CUPS fails on mac sandbox app [v5]

2022-03-25 Thread Alexander Scherbatiy
> The issue is reproduced on macOS Big Sur 11.0.1 with jdk 16.0.1+9. > > Create a native macOS app from the Hello.java file, sign and run it in > sandbox: > > import javax.print.*; > import javax.swing.*; > > public class Hello { > > public static void main(String[] args) throws Exception

Re: RFR: 8181571: printing to CUPS fails on mac sandbox app [v5]

2022-03-25 Thread Alexander Scherbatiy
On Tue, 24 Aug 2021 16:06:40 GMT, Alexander Scherbatiy wrote: >> src/java.desktop/unix/classes/sun/print/CUPSPrinter.java line 489: >> >>> 487: return domainSocketPathname; >>> 488: } >>> 489: >> >> You will need to suppress deprecation warnings here. > > Should I add `@SuppressWa

Integrated: 8274735: javax.imageio.IIOException: Unsupported Image Type while processing a valid JPEG image

2022-03-25 Thread Phil Race
On Thu, 17 Mar 2022 03:23:49 GMT, Phil Race wrote: > The JDK's built-in Image I/O JPEG plugin decodes JPEGs which are YCbCr and > RGb and Grayscale but rejects CMYK and YCCK JPEGs. > These would correspond to JFIF encapsulated JPEGs. > > This was a reasonable decision to limit support to what w

Re: RFR: 8282819: Deprecate Locale class constructors

2022-03-25 Thread Roger Riggs
On Thu, 24 Mar 2022 22:01:30 GMT, Naoto Sato wrote: > Proposing to deprecate the constructors in the `java.util.Locale` class. > There is already a factory method and a builder to return singletons, so > there is no need to have constructors anymore unless one purposefully wants > to create `i

Re: RFR: 8282819: Deprecate Locale class constructors

2022-03-25 Thread Naoto Sato
On Fri, 25 Mar 2022 15:37:36 GMT, Roger Riggs wrote: >> Proposing to deprecate the constructors in the `java.util.Locale` class. >> There is already a factory method and a builder to return singletons, so >> there is no need to have constructors anymore unless one purposefully wants >> to crea

Re: RFR: 8282819: Deprecate Locale class constructors

2022-03-25 Thread Roger Riggs
On Thu, 24 Mar 2022 22:01:30 GMT, Naoto Sato wrote: > Proposing to deprecate the constructors in the `java.util.Locale` class. > There is already a factory method and a builder to return singletons, so > there is no need to have constructors anymore unless one purposefully wants > to create `i

Re: RFR: 8181571: printing to CUPS fails on mac sandbox app [v5]

2022-03-25 Thread Phil Race
On Tue, 24 Aug 2021 15:57:40 GMT, Alexander Scherbatiy wrote: >> src/java.desktop/unix/native/common/awt/CUPSfuncs.c line 244: >> >>> 242: DPRINTF("CUPSfuncs::bad alloc new array\n", "") >>> 243: (*env)->ExceptionClear(env); >>> 244: JNU_ThrowOutOfMemoryError(env, "OutOf

Re: RFR: 8024624: [TEST_BUG] [macosx] CTRL+RIGHT(LEFT) doesn't move selection on next cell in JTable on Aqua L&F [v2]

2022-03-25 Thread DamonGuy
> Aqua L&F tables lacked support for `CTRL+ARROW`, `CTRL+PG_UP/DOWN`, and > `CTRL+SHIFT+PG_UP/DOWN` key bindings. This allows for navigation and > selection of table cells without the need of a mouse and without deselecting > the current selected cell group. > > Those key bindings are added to

client-libs-dev@openjdk.java.net

2022-03-25 Thread DamonGuy
On Fri, 11 Mar 2022 23:13:15 GMT, DamonGuy wrote: > Aqua L&F tables lacked support for `CTRL+ARROW`, `CTRL+PG_UP/DOWN`, and > `CTRL+SHIFT+PG_UP/DOWN` key bindings. This allows for navigation and > selection of table cells without the need of a mouse and without deselecting > the current select

Re: RFR: 8269806: Emoji rendering on Linux [v2]

2022-03-25 Thread Phil Race
On Thu, 24 Mar 2022 22:36:28 GMT, Nikita Gubarkov wrote: >> It was implemented in JetBrains Runtime a year ago and was ported & >> refactored for this PR >> It includes: >> - Bitmap glyph loading via Freetype >> - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or >> bili

Re: RFR: 8269806: Emoji rendering on Linux [v2]

2022-03-25 Thread Phil Race
On Thu, 24 Mar 2022 22:36:28 GMT, Nikita Gubarkov wrote: >> It was implemented in JetBrains Runtime a year ago and was ported & >> refactored for this PR >> It includes: >> - Bitmap glyph loading via Freetype >> - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or >> bili

RFR: 8283712 : Create a manual test framework class

2022-03-25 Thread lawrence . andrews
We need a common manual test framework code that can be shared across all the client manual test. This framework class should have the following 1) Frame which contains test instruction . 2) Pass & Fail button so that user can mark the test pass or fail 3) Upon failing the test user should be able

Re: RFR: 8024624: [TEST_BUG] [macosx] CTRL+RIGHT(LEFT) doesn't move selection on next cell in JTable on Aqua L&F [v2]

2022-03-25 Thread Phil Race
On Fri, 25 Mar 2022 19:20:43 GMT, DamonGuy wrote: >> Aqua L&F tables lacked support for `CTRL+ARROW`, `CTRL+PG_UP/DOWN`, and >> `CTRL+SHIFT+PG_UP/DOWN` key bindings. This allows for navigation and >> selection of table cells without the need of a mouse and without deselecting >> the current se

Re: RFR: 8283712 : Create a manual test framework class

2022-03-25 Thread Phil Race
On Fri, 25 Mar 2022 21:06:12 GMT, lawrence.andrews wrote: > We need a common manual test framework code that can be shared across all the > client manual test. This framework class should have the following > 1) Frame which contains test instruction . > 2) Pass & Fail button so that user can ma

Re: RFR: JDK-8280193: summary javadoc for java.awt.GraphicsEnvironment#preferProportionalFonts broken

2022-03-25 Thread Alexey Ivanov
On Tue, 18 Jan 2022 14:05:55 GMT, James Nord wrote: > https://bugs.openjdk.java.net/browse/JDK-8280193 > > > Javadoc broke the first sentence at the full stop space (newline) so it > rendered with `Indicates a preference for proportional over non-proportional > (e.g.` > > This is an incorrec

Re: RFR: JDK-8280193: summary javadoc for java.awt.GraphicsEnvironment#preferProportionalFonts broken

2022-03-25 Thread Alexey Ivanov
On Thu, 24 Mar 2022 02:46:03 GMT, Phil Race wrote: > I am fine with this but there's probably a javadoc way to escape this Yes, there is: use an HTML entity to avoid the sequence of the period followed by a space. See the example in the [First Sentence](https://www.oracle.com/technical-resourc

Re: RFR: JDK-8280193: summary javadoc for java.awt.GraphicsEnvironment#preferProportionalFonts broken

2022-03-25 Thread Alexey Ivanov
On Fri, 25 Mar 2022 21:55:37 GMT, Alexey Ivanov wrote: > > I am fine with this but there's probably a javadoc way to escape this > > Yes, there is: use an HTML entity to avoid the sequence of the period > followed by a space. See the example in the [First > Sentence](https://www.oracle.com/tec

Re: RFR: 8269806: Emoji rendering on Linux [v2]

2022-03-25 Thread Nikita Gubarkov
On Thu, 24 Mar 2022 22:36:28 GMT, Nikita Gubarkov wrote: >> It was implemented in JetBrains Runtime a year ago and was ported & >> refactored for this PR >> It includes: >> - Bitmap glyph loading via Freetype >> - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or >> bili

Re: RFR: 8269806: Emoji rendering on Linux [v2]

2022-03-25 Thread Phil Race
On Thu, 24 Mar 2022 22:36:28 GMT, Nikita Gubarkov wrote: >> It was implemented in JetBrains Runtime a year ago and was ported & >> refactored for this PR >> It includes: >> - Bitmap glyph loading via Freetype >> - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or >> bili

Re: RFR: 7124282: [macosx] Can't see table cell highlighter when the highlight border is the same color as the cell. [v3]

2022-03-25 Thread Harshitha Onkar
On Fri, 25 Mar 2022 07:57:33 GMT, Prasanta Sadhukhan wrote: >> @prsadhuk Thank you for mentioning >> [JDK-8261243](https://bugs.openjdk.java.net/browse/JDK-8261243) issue. It is >> similar to the JTable cell focus ring. >> >> If we decide to go with the blue focus ring it would cause the sam

Re: RFR: 8283712 : Create a manual test framework class

2022-03-25 Thread lawrence . andrews
On Fri, 25 Mar 2022 21:33:46 GMT, Phil Race wrote: >> We need a common manual test framework code that can be shared across all >> the client manual test. This framework class should have the following >> 1) Frame which contains test instruction . >> 2) Pass & Fail button so that user can mark t

Re: RFR: 8283712 : Create a manual test framework class [v2]

2022-03-25 Thread lawrence . andrews
On Fri, 25 Mar 2022 21:35:49 GMT, Phil Race wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed the review comments and fixed the test using PassFailJFrame.java > > test/jdk/java/awt/regtesthelpers/PassFailJF

Re: RFR: 8283712 : Create a manual test framework class [v2]

2022-03-25 Thread lawrence . andrews
> We need a common manual test framework code that can be shared across all the > client manual test. This framework class should have the following > 1) Frame which contains test instruction . > 2) Pass & Fail button so that user can mark the test pass or fail > 3) Upon failing the test user shou

Re: RFR: 8283712 : Create a manual test framework class [v3]

2022-03-25 Thread lawrence . andrews
> We need a common manual test framework code that can be shared across all the > client manual test. This framework class should have the following > 1) Frame which contains test instruction . > 2) Pass & Fail button so that user can mark the test pass or fail > 3) Upon failing the test user shou

Re: RFR: 8283712 : Create a manual test framework class [v2]

2022-03-25 Thread lawrence . andrews
On Sat, 26 Mar 2022 02:13:24 GMT, lawrence.andrews wrote: >> We need a common manual test framework code that can be shared across all >> the client manual test. This framework class should have the following >> 1) Frame which contains test instruction . >> 2) Pass & Fail button so that user ca

Re: RFR: 8283712 : Create a manual test framework class [v3]

2022-03-25 Thread Phil Race
On Sat, 26 Mar 2022 02:20:29 GMT, lawrence.andrews wrote: >> We need a common manual test framework code that can be shared across all >> the client manual test. This framework class should have the following >> 1) Frame which contains test instruction . >> 2) Pass & Fail button so that user ca