Re: RFR: 8284898 : Enhance PassFailJFrame [v8]

2022-04-17 Thread Alexey Ivanov
On Sat, 16 Apr 2022 23:02:13 GMT, lawrence.andrews wrote: >> Fixed the following issue. >> 1) Removed yes/no since test was failing due to "Parser error due to yesno >> in @run main/manual=yesno" >> 2) After removing yes/no test run( just shows the UI and gets dispose >> immediately). User can

Re: RFR: 8284898 : Enhance PassFailJFrame [v7]

2022-04-17 Thread Alexey Ivanov
On Sat, 16 Apr 2022 22:54:43 GMT, Phil Race wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update PrintGlyphVectorTest.java > > test/jdk/java/awt/print/PrinterJob/PrintGlyphVectorTest.java line 131: > >> 129:

Re: RFR: 8284898 : Enhance PassFailJFrame [v7]

2022-04-17 Thread Alexey Ivanov
On Sun, 17 Apr 2022 22:01:38 GMT, Alexey Ivanov wrote: >> test/jdk/java/awt/print/PrinterJob/PrintGlyphVectorTest.java line 131: >> >>> 129: PrinterJob pj = PrinterJob.getPrinterJob(); >>> 130: if (pj == null || pj.getPrintService() == null) { >>> 131: System.out.prin

Re: RFR: 8284898 : Enhance PassFailJFrame [v8]

2022-04-17 Thread Alexey Ivanov
On Sat, 16 Apr 2022 23:02:13 GMT, lawrence.andrews wrote: >> Fixed the following issue. >> 1) Removed yes/no since test was failing due to "Parser error due to yesno >> in @run main/manual=yesno" >> 2) After removing yes/no test run( just shows the UI and gets dispose >> immediately). User can

Re: RFR: 8284898 : Enhance PassFailJFrame [v8]

2022-04-17 Thread Alexey Ivanov
On Sat, 16 Apr 2022 23:02:13 GMT, lawrence.andrews wrote: >> Fixed the following issue. >> 1) Removed yes/no since test was failing due to "Parser error due to yesno >> in @run main/manual=yesno" >> 2) After removing yes/no test run( just shows the UI and gets dispose >> immediately). User can

Integrated: 8284699: Include all image types to the J2DBench.ColorConvertOpTests

2022-04-17 Thread Sergey Bylokhov
On Mon, 11 Apr 2022 21:06:08 GMT, Sergey Bylokhov wrote: > The J2DBench.ColorConvertOp tests are used to track the performance of the > littlecms library in the JDK. The new version of the littlecms will add > support for the premultiplied alpha. But right now the J2DBench does not test > the

Re: RFR: 8266246: Swing test PressedIconTest.java sometimes fails on macOS 11 ARM

2022-04-17 Thread Prasanta Sadhukhan
On Fri, 15 Apr 2022 09:57:53 GMT, Prasanta Sadhukhan wrote: > javax/swing/JButton/8151303/PressedIconTest.java was failing few times in > macos M1 system owing t color profile issue. > > java.lang.RuntimeException: Colors are different! > at PressedIconTest.main(PressedIconTest.java:88) > >

Re: RFR: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS

2022-04-17 Thread Prasanta Sadhukhan
On Thu, 14 Apr 2022 06:50:10 GMT, Prasanta Sadhukhan wrote: > JDK-4517214 was fixed for Metal L&F where JComboBox having TitledBorder used > to have double height compared to normal JComboBox. > The issue is still observed for macos for Aqua L&F where still double height > is seen. > Fix is to

Re: RFR: 8284189: Replace usages of 'a the' in java.desktop

2022-04-17 Thread Jayathirth D V
On Sat, 16 Apr 2022 17:45:16 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > I fixed a couple of other spelling mistakes. src/java.desktop/share/classes/java/awt/Graphics.java line 29: > 27: import java.io.*; >

Withdrawn: 8180276: JTextPane getText return extra when mixed with methods of Document

2022-04-17 Thread Tejesh R
On Wed, 6 Apr 2022 10:02:10 GMT, Tejesh R wrote: > getText function returned extra endOfLine when appended. The reason was in > `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)` > method, where translation happens from buffer to Out(Writer Object) if > endOfLine is o

Re: RFR: 8284189: Replace usages of 'a the' in java.desktop

2022-04-17 Thread Jayathirth D V
On Sat, 16 Apr 2022 17:45:16 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > I fixed a couple of other spelling mistakes. This PR has a lot of other changes than just correcting spelling mistakes and a/an combi