Re: RFR: 8286270: [java.desktop] Replace color search in XColors with a switch statement

2022-05-08 Thread ExE Boss
On Sun, 8 May 2022 02:44:24 GMT, Phil Race wrote: > > The current implementation creates ~750 new objects on load > > Whereas yours creates an un-bounded number .. and changes that two lookups > for the same name will return the same "==" object. That’s not what happens, since `XColors::lookup

Re: RFR: JDK-8255439: System Tray icons get corrupted when windows scaling changes [v2]

2022-05-08 Thread Harshitha Onkar
On Sat, 7 May 2022 13:01:53 GMT, Kevin Rushforth wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> resized instruction window and formatted line lengths > > The fix looks good to me, but someone more familiar with

Re: RFR: JDK-8255439: System Tray icons get corrupted when windows scaling changes [v3]

2022-05-08 Thread Harshitha Onkar
> In Windows, when desktop scaling is changed the tray icons was > distorted/blurred a bit each time scaling changes. > > With the proposed fix, the tray icon scales according to on-the-fly DPI scale > settings. A test case has been added which adds a MRI icon to system tray, to > observe the i

Integrated: 8284613: invalid use of @serial tag

2022-05-08 Thread Alisen Chung
On Wed, 27 Apr 2022 19:48:15 GMT, Alisen Chung wrote: > Removed serial tag in method documentation This pull request has now been integrated. Changeset: cdd1b0da Author:Alisen Chung Committer: Phil Race URL: https://git.openjdk.java.net/jdk/commit/cdd1b0da14837f4bf65a3450ab671ccc18

Re: RFR: JDK-8286348: incorrect use of `@serial`

2022-05-08 Thread Jonathan Gibbons
On Sun, 8 May 2022 02:19:09 GMT, Phil Race wrote: > Jon, all of the changes in java.desktop are already underway in > https://github.com/openjdk/jdk/pull/8432/files and > have been approved and even have an approved CSR .. just waiting for > @alisenchung to type /integrate .. Thanks for the he

Re: RFR: 8285867 : Convert applet manual tests SelectionVisible.java to Frame and automate [v2]

2022-05-08 Thread lawrence . andrews
> 1) Removed Applet dependent code and used Frame as top level. > 2) Automated the manual test. > > @shurymury lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision: Fixed disposing of frame with in EDT - Changes: - all:

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v3]

2022-05-08 Thread Prasanta Sadhukhan
On Fri, 6 May 2022 14:47:39 GMT, Tejesh R wrote: >> In Button ToolTip, Mnemonic key string was shown only in Metal Look and >> Feel, since the feature is implemented in it. In other L&F especially >> Windows L&F the feature is not available. In order to make it available for >> other L&F's, th

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v7]

2022-05-08 Thread Prasanta Sadhukhan
> Issue was when printing a JTable which sits inside a JScrollPane and the > table is scrolled down to the end to about 1000th row, only the first page is > printed. > This is because when the table is scrolled down to last page, the bounds.y > becomes -ve > [x=0,y=-15260,width=968,height=1600

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v6]

2022-05-08 Thread Prasanta Sadhukhan
On Fri, 8 Apr 2022 12:41:29 GMT, Prasanta Sadhukhan wrote: >> Issue was when printing a JTable which sits inside a JScrollPane and the >> table is scrolled down to the end to about 1000th row, only the first page >> is printed. >> This is because when the table is scrolled down to last page,

Re: RFR: JDK-8282772: JButton text set as HTML content has unwanted padding [v2]

2022-05-08 Thread Prasanta Sadhukhan
On Wed, 27 Apr 2022 18:52:46 GMT, DamonGuy wrote: >> The insets for buttons were incorrect for L&Fs except for Aqua when the text >> is set to HTML. This was fixed in Aqua by adding a conditional to check for >> the BasicHTML property key in the button component. This same logic can be >> used