> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a
> compound assignment is not assignment compatibl
> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on
> Fedora 36.
> As you can see, the warnings spreads several areas. Let me know if I should
> separate them by area.
>
> * -Wstringop-overflow
> * src/hotspot/share/oops/array.hpp
> *
> src/hotspot/share/jfr/
On Thu, 28 Apr 2022 14:58:28 GMT, Zhengyu Gu wrote:
>> During initializing native data of `X11GraphicsEnvironment`, a single
>> `AwtGraphicsConfigData` is used/reused, not only failed cases, but also
>> succeeded cases. So `AwtGraphicsConfigData` internal states need to be
>> cleanup properly
On Wed, 20 Apr 2022 13:48:19 GMT, Zhengyu Gu wrote:
> During initializing native data of `X11GraphicsEnvironment`, a single
> `AwtGraphicsConfigData` is used/reused, not only failed cases, but also
> succeeded cases. So `AwtGraphicsConfigData` internal states need to be
> cleanup properly to a
On Wed, 27 Apr 2022 17:59:01 GMT, Phil Race wrote:
>> Zhengyu Gu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Aleksey and Andrew's comments
>
> Marked as reviewed by prr (Reviewer).
Thanks for the reviews, @prrace @shipilev and @gnu
On Fri, 13 May 2022 10:02:30 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>> *
On Wed, 16 Mar 2022 06:02:28 GMT, Prasanta Sadhukhan
wrote:
>> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced
>> Gulim korean font so it needs to be updated to show korean fonts
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional com
> I ran `codespell` on the `src/java.desktop` directory, and accepted those
> changes where it indeed discovered real typos.
>
> I ignored typos in public methods and variables. Maybe they can be fixed
> later on without much fanfare, if they are in internal classes. Typos in
> exposed APIs are
On Thu, 28 Apr 2022 16:48:04 GMT, Alexey Ivanov wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with four
>> additional commits since the last revision:
>>
>> - Update src/java.desktop/share/classes/javax/swing/JLayeredPane.java
>>
>>Co-authored-by: Alexey Ivano
> I ran `codespell` on the `src/java.desktop` directory, and accepted those
> changes where it indeed discovered real typos.
>
> I ignored typos in public methods and variables. Maybe they can be fixed
> later on without much fanfare, if they are in internal classes. Typos in
> exposed APIs are
> I ran `codespell` on the `src/java.desktop` directory, and accepted those
> changes where it indeed discovered real typos.
>
> I ignored typos in public methods and variables. Maybe they can be fixed
> later on without much fanfare, if they are in internal classes. Typos in
> exposed APIs are
> I ran `codespell` on the `src/java.desktop` directory, and accepted those
> changes where it indeed discovered real typos.
>
> I ignored typos in public methods and variables. Maybe they can be fixed
> later on without much fanfare, if they are in internal classes. Typos in
> exposed APIs are
> I ran `codespell` on the `src/java.desktop` directory, and accepted those
> changes where it indeed discovered real typos.
>
> I ignored typos in public methods and variables. Maybe they can be fixed
> later on without much fanfare, if they are in internal classes. Typos in
> exposed APIs are
On Thu, 28 Apr 2022 20:37:22 GMT, Alexey Ivanov wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with 17
>> additional commits since the last revision:
>>
>> - Update src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java
>>
>>Co-authored-by: Alexey Iv
On Thu, 28 Apr 2022 21:25:02 GMT, Alexey Ivanov wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with 17
>> additional commits since the last revision:
>>
>> - Update src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java
>>
>>Co-authored-by: Alexey Iv
> In Windows, when desktop scaling is changed the tray icons was
> distorted/blurred a bit each time scaling changes.
>
> With the proposed fix, the tray icon scales according to on-the-fly DPI scale
> settings. A test case has been added which adds a MRI icon to system tray, to
> observe the i
On Fri, 13 May 2022 16:53:31 GMT, Magnus Ihse Bursie wrote:
>> Nearly 500 files are too many. Smaller chunks would be easier to review.
>>
>> Some of the native code files could come from upstream libraries.
>
> @aivanov-jdk While I approve of finding and fixing spelling mistakes,
> grammatical
> Moving cache invalidation from the clearCache method to a createRowWithIndex
> method
> eliminating race condition that causes crash. Now clearCache just notifies
> that cache
> is invalid and should be regenerated next time it is being accessed.
Alexander Zuev has updated the pull request inc
On Wed, 11 May 2022 10:03:59 GMT, Artem Semenov wrote:
> If possible, please add this case to the regression test
>
> test/jdk/java/awt/a11y/AccessibleJTableTest.java
Done.
-
PR: https://git.openjdk.java.net/jdk/pull/8636
On Fri, 13 May 2022 16:48:35 GMT, Magnus Ihse Bursie wrote:
>> src/java.desktop/share/classes/sun/swing/text/TextComponentPrintable.java
>> line 772:
>>
>>> 770: /*
>>> 771: * we do not store the same value as previous.
>>> in our
>>> 772:
On Fri, 13 May 2022 18:01:47 GMT, Harshitha Onkar wrote:
>> In Windows, when desktop scaling is changed the tray icons was
>> distorted/blurred a bit each time scaling changes.
>>
>> With the proposed fix, the tray icon scales according to on-the-fly DPI
>> scale settings. A test case has been
On Fri, 13 May 2022 18:01:47 GMT, Harshitha Onkar wrote:
>> In Windows, when desktop scaling is changed the tray icons was
>> distorted/blurred a bit each time scaling changes.
>>
>> With the proposed fix, the tray icon scales according to on-the-fly DPI
>> scale settings. A test case has been
On Fri, 13 May 2022 18:07:02 GMT, Kevin Rushforth wrote:
>> Harshitha Onkar has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> com
On Fri, 13 May 2022 18:08:23 GMT, Kevin Rushforth wrote:
>> Harshitha Onkar has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> com
On Wed, 27 Apr 2022 03:38:09 GMT, Phil Race wrote:
> Please exclude ALL 3rd party libraries from this PR.
Are these the only files to be excluded?
src/java.desktop/share/native/libfreetype/src/autofit/afcjk.c
src/java.desktop/share/native/libfreetype/src/autofit/aflatin.c
src/java.desktop/shar
On Fri, 13 May 2022 19:16:52 GMT, Alexey Ivanov wrote:
>> src/java.desktop/windows/classes/sun/awt/windows/WTrayIconPeer.java line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2005, 2022, Oracle and/or its affiliates. All rights
>>> reserved.
>>
>> You can revert this file, since the only remaining
On Thu, 12 May 2022 04:09:29 GMT, Prasanta Sadhukhan
wrote:
>> Issue was when printing a JTable which sits inside a JScrollPane and the
>> table is scrolled down to the end to about 1000th row, only the first page
>> is printed.
>> This is because when the table is scrolled down to last page,
On Thu, 12 May 2022 04:05:48 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/javax/swing/JTable/PrintAllPagesTest.java line 80:
>>
>>> 78: try {
>>> 79: if (!table.print()) {
>>> 80: throw new RuntimeException("Printing cancelled");
>>
>> When run out
On Fri, 13 May 2022 19:28:26 GMT, Kevin Rushforth wrote:
>> I'm for keeping the expanded imports in WTrayIconPeer.java, even it's the
>> only change left now.
>>
>> I'd probably remove the unused import from `TrayIcon.java` too. However, the
>> change in this case is too minor.
>
> My preferen
On Wed, 20 Apr 2022 05:10:23 GMT, Alexander Zuev wrote:
> Only check that insets of the fully expanded undecorated window is not bigger
> than device insets. They can be smaller, it is a normal situation.
This pull request has now been integrated.
Changeset: f56396f1
Author:Alexander Zuev
On Fri, 13 May 2022 18:01:47 GMT, Harshitha Onkar wrote:
>> In Windows, when desktop scaling is changed the tray icons was
>> distorted/blurred a bit each time scaling changes.
>>
>> With the proposed fix, the tray icon scales according to on-the-fly DPI
>> scale settings. A test case has been
On Mon, 9 May 2022 20:42:05 GMT, Alexey Ivanov wrote:
> This should be the first statement in main. If icons aren't supported,
> there's no need to create the instruction frame. The test will still wait for
> user's response but no tray icon is added.
It won't wait if you haven't created it ..
On Wed, 16 Mar 2022 06:02:28 GMT, Prasanta Sadhukhan
wrote:
>> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced
>> Gulim korean font so it needs to be updated to show korean fonts
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional com
On Fri, 13 May 2022 22:04:39 GMT, Phil Race wrote:
>> Harshitha Onkar has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> commits s
On Thu, 12 May 2022 07:25:22 GMT, Tejesh R wrote:
>> In Button ToolTip, Mnemonic key string was shown only in Metal Look and
>> Feel, since the feature is implemented in it. In other L&F especially
>> Windows L&F the feature is not available. In order to make it available for
>> other L&F's, t
On Wed, 27 Apr 2022 22:10:43 GMT, Dan Lutker wrote:
>> …xception: Index 4096 out of bounds for length 4096
>>
>> Adapted from
>> https://github.com/openjdk/jfx/commit/7b7050c46299c0e6771ae02fbb5ceaf22104d3e4
>>
>> # Testing done
>> Build locally on linux and ran jdk_imageio tests.
>
> Dan Lutk
On Wed, 4 May 2022 07:48:17 GMT, Dmitry Kulikov wrote:
>> Hello,
>> Please review this fix for JDK-8282863.
>>
>> The failing
>> `java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java` test
>> basically checks that full-screen window remains full-screen when a display
>> mode c
On Wed, 20 Apr 2022 05:10:23 GMT, Alexander Zuev wrote:
> Only check that insets of the fully expanded undecorated window is not bigger
> than device insets. They can be smaller, it is a normal situation.
That a mistake to consider that as a correct behavior even based on the amount
of bugs we
38 matches
Mail list logo
