Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v2]

2022-05-27 Thread Harshitha Onkar
On Wed, 25 May 2022 12:21:51 GMT, Tejesh R wrote: >> Added test for checking setMargin() of JRadioButton. > > Tejesh R has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pu

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v3]

2022-05-27 Thread Tejesh R
> Added test for checking setMargin() of JRadioButton. Tejesh R has updated the pull request incrementally with two additional commits since the last revision: - Updated based on review comments - Added headful key - Changes: - all: https://git.openjdk.java.net/jdk/pull/8721/fi

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v2]

2022-05-27 Thread Tejesh R
On Fri, 27 May 2022 17:03:08 GMT, Harshitha Onkar wrote: >> Tejesh R has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains ten additional commits >> s

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v3]

2022-05-27 Thread Harshitha Onkar
On Fri, 27 May 2022 17:21:29 GMT, Tejesh R wrote: >> Added test for checking setMargin() of JRadioButton. > > Tejesh R has updated the pull request incrementally with two additional > commits since the last revision: > > - Updated based on review comments > - Added headful key Marked as revi

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v5]

2022-05-27 Thread Phil Race
On Thu, 26 May 2022 08:49:42 GMT, Prasanta Sadhukhan wrote: >> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced >> Gulim korean font so it needs to be updated to show korean fonts > > Prasanta Sadhukhan has updated the pull request with a new target base due to > a merge

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v19]

2022-05-27 Thread Phil Race
On Wed, 25 May 2022 21:37:07 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > changed test to headless You

Re: Hairline strokes under fractional display metrics

2022-05-27 Thread Philip Race
Indeed .. something very close to that is what is being proposed in a current PR here : https://github.com/openjdk/jdk/pull/7449/files Just bear in mind some of the same constraints and that if printed on a 1200dpi printer with a scale of 16.67 .. your one pixel line might be too thin to be se

Re: RFR: 8282526: Default icon is not painted properly [v4]

2022-05-27 Thread Alexander Zuev
> Detect the situation where we do need to perform interpolation during > ImageIcon > painting and set a hint to the rendering to perform bicubic approximation so > image details are preserved during transition. Alexander Zuev has updated the pull request incrementally with one additional commit

Re: RFR: 8282526: Default icon is not painted properly [v4]

2022-05-27 Thread Alexander Zuev
On Fri, 27 May 2022 18:02:51 GMT, Alexander Zuev wrote: >> Detect the situation where we do need to perform interpolation during >> ImageIcon >> painting and set a hint to the rendering to perform bicubic approximation so >> image details are preserved during transition. > > Alexander Zuev has u

Re: Hairline strokes under fractional display metrics

2022-05-27 Thread Kirill Grouchnikov
I also found https://github.com/apache/netbeans/blob/master/platform/o.n.swing.plaf/src/org/netbeans/swing/plaf/windows8/DPIUnscaledBorder.java through that OpenJDK thread that I was reading yesterday, which looks to be taking a similar approach. Probably in a world of 4x+ monitors, I would indeed

RFR: 8287453: RenderPerfTest incorrectly measures performance

2022-05-27 Thread Alexey Ushakov
Improved RenderPerfTest: - removed RenderPerfLCD.java (we have LCD tests in RenderPerfTest.java) - corrected and simplified test logic - added timeout on low performant rendering - used several markers to recover from missing frames - protected measurements from multiple paint invocations

Re: RFR: 8213531: Test javax/swing/border/TestTitledBorderLeak.java fails [v2]

2022-05-27 Thread Phil Race
On Thu, 28 Apr 2022 13:34:31 GMT, Prasanta Sadhukhan wrote: >> Test was failing in linux citing `java.lang.RuntimeException: Expected Total >> TitledBorder to be freed : 10 Freed 9 ` >> As per the fix done in JDK-8204963 >> http://hg.openjdk.java.net/jdk/jdk/rev/cd7d2f9154fd >> there was no pl

Re: RFR: 8286663: Resolve IDE warnings in WTrayIconPeer and SystemTray [v3]

2022-05-27 Thread Alexey Ivanov
> **WTrayIconPeer**: removed duplicate call to `popupParent.dispose()` that > might cause NPE (it looks `popupParent` cannot be `null`); organised imports. > > **SystemTray**: removed redundant initialisers; replaced sized array with > empty array in `toArray` call; dropped `newValue != null` ch

Integrated: 8286562: GCC 12 reports some compiler warnings

2022-05-27 Thread Yasumasa Suenaga
On Wed, 11 May 2022 05:58:31 GMT, Yasumasa Suenaga wrote: > I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on > Fedora 36. > As you can see, the warnings spreads several areas. Let me know if I should > separate them by area. > > * -Wstringop-overflow > * src/ho

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v6]

2022-05-27 Thread Prasanta Sadhukhan
> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced Gulim > korean font so it needs to be updated to show korean fonts Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Added UTF-8 korean fallback -

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v5]

2022-05-27 Thread Prasanta Sadhukhan
On Fri, 27 May 2022 17:51:45 GMT, Phil Race wrote: > Good to know. I still believe we should add > sequence.allfonts.UTF-8.ko=alphabetic,korean,dingbats,symbol since UTF-8 is > now the default encoding. Added UTF-8 korean fallback. I get the same above rendering with the same commandline as a