On Fri, 26 Nov 2021 12:46:59 GMT, Сергей Цыпанов wrote:
> Instead of something like
>
> long x;
> long y;
> return (x < y) ? -1 : ((x == y) ? 0 : 1);
>
> we can use `return Long.compare(x, y);`
>
> All replacements are done with IDE.
Changes to java.net look good. Please obtain approval from
On Sat, 11 Dec 2021 14:56:23 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList javax/swing/JTree/4908142/bug4908142.java on
> macosx-x64.
LGTM
-
Marked as reviewed by dfuchs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/6805
On Mon, 10 Jan 2022 20:46:36 GMT, Andrey Turbanov wrote:
> `Properties.load` uses `java.util.Properties.LineReader`. LineReader already
> buffers input stream. Hence wrapping InputStream in BufferedInputStream is
> redundant.
Changes to `java.util.logging` look fine.
-
PR: https:
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote:
> Use presumed syntax that will be introduced by JDK-8280488.
Marked as reviewed by dfuchs (Reviewer).
LGTM. I hope in the future IDEs will pick that rule up and offer some help when
writing `{@link }` `@see`...
-
PR: https://git
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote:
> msg drop for jdk19, Mar 9, 2022
For simple webserver resource files - should the copyright year be 2022?
-
PR: https://git.openjdk.java.net/jdk/pull/7765
On Thu, 10 Mar 2022 17:00:09 GMT, Naoto Sato wrote:
> IIRC, localized resource files should have the same copyright year as the
> base English one. That's what I was told by the l10n engineer when I had the
> same comment.
Thanks Naoto! I have no objection then.
-
PR: https://git
On Thu, 10 Mar 2022 21:12:46 GMT, Zhengyu Gu wrote:
> Another trivial cleanup to fix the last parameter of `GetStringXXXChars`
> calls, should be a `jboolean*` instead of a `jboolean`.
Marked as reviewed by dfuchs (Reviewer).
The `libnet` changes look good to me - but please get someone from t
On Tue, 26 Apr 2022 22:24:26 GMT, Joe Darcy wrote:
> To enable more complete doclint checking (courtesy @jonathan-gibbons), please
> review this PR to add type-level @param tags where they are missing.
>
> To the maintainers of java.util.concurrent, those changes could be separated
> out in an
On Thu, 28 Apr 2022 01:34:19 GMT, Joe Darcy wrote:
>> To enable more complete doclint checking (courtesy @jonathan-gibbons),
>> please review this PR to add type-level @param tags where they are missing.
>>
>> To the maintainers of java.util.concurrent, those changes could be separated
>> out
On Thu, 31 Mar 2022 08:03:23 GMT, Andrey Turbanov wrote:
>> Method `Class.isAssignableFrom` is often used in form of:
>>
>> if (clazz.isAssignableFrom(obj.getClass())) {
>> Such condition could be simplified to more shorter and performarnt code
>>
>> if (clazz.isInstance(obj)) {
>>
On Tue, 10 May 2022 11:31:16 GMT, Andrey Turbanov wrote:
>> src/java.desktop/share/classes/javax/imageio/spi/ServiceRegistry.java line
>> 230:
>>
>>> 228: List l = new ArrayList<>();
>>> 229: for (Class c : categoryMap.keySet()) {
>>> 230: if (c.isInstance(provider))
11 matches
Mail list logo
