Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-04 Thread Julian Waters
On Fri, 25 Feb 2022 15:40:09 GMT, Matteo Baccan wrote: >> Hi >> >> I have reviewed the code for removing double semicolons at the end of lines >> >> all the best >> matteo > > Hi > > I have pushed this PR about 1 month ago. Only 3 days ago OCA was accepted. > Now: what is the next step? > > T

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-04 Thread Julian Waters
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Nice, good work matteo Should I change the JBS issue title to match the PR title, or is it preferred for the PR title to chang

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-07 Thread Julian Waters
On Mon, 7 Mar 2022 13:40:48 GMT, Erik Joelsson wrote: > > Should I change the JBS issue title to match the PR title, or is it > > preferred for the PR title to change? > > They need to match. You can either do it manually, or change the title to > just the bug number and the bot will change it

Re: RFR: 8286270: [java.desktop] Replace color search in XColors with a switch statement

2022-05-05 Thread Julian Waters
On Thu, 7 Apr 2022 15:27:11 GMT, SWinxy wrote: >> The current implementation creates ~750 new objects on load, and uses a >> binary array search with a Comparable implementation. This implementation is >> probably bad. Instead, we can use the enhanced switch feature to possibly >> save time, r

Re: RFR: 8286271: [java.desktop] Replace ternary operators with java.lang.Math min/max

2022-05-05 Thread Julian Waters
On Thu, 7 Apr 2022 15:27:56 GMT, SWinxy wrote: >> Delete `sun.java2d.marlin.FloatMath` class in favor of methods in >> `java.lang.Math`. The methods in `Math.java` are intrinsics and can gain >> from significant speedups. Hand-written min/max operations are also replaced >> with calls. 5 uses

Re: RFR: 8286271: [java.desktop] Replace ternary operators with java.lang.Math min/max

2022-05-05 Thread Julian Waters
On Sat, 15 Jan 2022 04:23:33 GMT, SWinxy wrote: > Delete `sun.java2d.marlin.FloatMath` class in favor of methods in > `java.lang.Math`. The methods in `Math.java` are intrinsics and can gain from > significant speedups. Hand-written min/max operations are also replaced with > calls. 5 uses of

Re: RFR: 8286269: [java.desktop] Use newer instanceof language feature wherever possible

2022-05-05 Thread Julian Waters
On Sat, 8 Jan 2022 18:13:45 GMT, SWinxy wrote: > The old java.desktop package needs dusting off. It hasn't been kept up to > pace with the Java language, but it should. The purpose of this PR is to > replace most or all `instanceof` checks with the new `instanceof` with a > variable. Some meth

Re: RFR: 8286269: [java.desktop] Use newer instanceof language feature wherever possible

2022-05-05 Thread Julian Waters
On Sat, 5 Feb 2022 03:35:10 GMT, SWinxy wrote: > > Try to merge instead of rebasing and force-pushing, it helps with later > > reviews. > > Good to know. I'm not a git master, and the purpose of the force push was to > consolidate some missed changes into a single commit, but I know it can mes

Re: RFR: 8286269: [java.desktop] Use newer instanceof language feature wherever possible

2022-05-05 Thread Julian Waters
On Fri, 6 May 2022 03:05:30 GMT, Julian Waters wrote: >> Keeping open. > > @SWinxy Gratz on getting the contributor status! I've created an issue on the > tracker for you, please rename the title of this PR to just 8286269 and the > automated system should take care of

Re: RFR: 8286269: [java.desktop] Use newer instanceof language feature wherever possible

2022-05-05 Thread Julian Waters
On Tue, 8 Mar 2022 18:22:23 GMT, SWinxy wrote: > The OCA process is back in my court, and I've been overwhelmed these past few > weeks to get it over with. Thank you, genuinely, for offering. If you have > time to create those issues on the JBS, I would greatly appreciate it. The OCA can be an

Re: RFR: 8286269: [java.desktop] Use newer instanceof language feature wherever possible

2022-05-05 Thread Julian Waters
On Sat, 8 Jan 2022 18:13:45 GMT, SWinxy wrote: > The old java.desktop package needs dusting off. It hasn't been kept up to > pace with the Java language, but it should. The purpose of this PR is to > replace most or all `instanceof` checks with the new `instanceof` with a > variable. Some meth