Re: RFR: 8272229: BasicSplitPaneDivider:oneTouchExpandableChanged() returns leftButton and rightButton as null with GTKLookAndFeel [v2]

2021-09-16 Thread Patrick Chen
You should review your patch I comment the last line do not merge Le jeu. 16 sept. 2021 à 11:01, Pankaj Bansal a écrit : > > The function documentation for oneTouchExpandableChanged states that the > function does couple of things, but in reality it only does those things > if the Look and Feel

Re: RFR: 8244681: Add a warning for possibly lossy conversion in compound assignments [v3]

2022-05-11 Thread Patrick Chen
I checked you pr look good to me @Roger Le mer. 11 mai 2022 à 15:35, Roger Riggs a écrit : > On Wed, 11 May 2022 13:27:38 GMT, Adam Sotona wrote: > > >> That's good to know. I think the tricky part is mostly about keeping > track of all these disabled warnings, so they are not kept around longe

Re: RFR: 8287148: Avoid redundant HashMap.containsKey calls in ExtendedKeyCodes.getExtendedKeyCodeForChar

2022-05-24 Thread Patrick Chen
"It's clearer and a bit faster." yeah totally agree Le lun. 23 mai 2022 à 11:03, Andrey Turbanov a écrit : > `sun.awt.ExtendedKeyCodes#regularKeyCodesMap` contains only non-null > values. It means we can replace containsKey+get with get+null check. > It's clearer and a bit faster. > > --