RFR: 6465404: some problems in CellEditor related API docs

2021-12-06 Thread Tejesh R
JListBox is invalid component. CellTableEditor Interface doesn't support JComboBox and JTree components. Hence its removed from Documentation. - Commit messages: - 6465404: some problems in CellEditor related API docs Changes: https://git.openjdk.java.net/jdk/pull/6608/files Webre

RFR: 6462028: MaskFormatter API documentation refers to getDisplayValue

2021-12-06 Thread Tejesh R
MaskFormatter API doesn't have getDisplayValue method, hence removed from Documentation. - Commit messages: - 6462028:MaskFormatter API documentation refers to getDisplayValue Changes: https://git.openjdk.java.net/jdk/pull/6556/files Webrev: https://webrevs.openjdk.java.net/?repo=

Re: RFR: 6462028: MaskFormatter API documentation refers to getDisplayValue

2021-12-06 Thread Tejesh R
On Mon, 6 Dec 2021 17:16:20 GMT, Phil Race wrote: >> src/java.desktop/share/classes/javax/swing/text/MaskFormatter.java line 103: >> >>> 101: * MaskFormatter formatter = new MaskFormatter("###-"); >>> 102: * formatter.setPlaceholderCharacter('_'); >>> 103: * formatter.getDisplayValu

Re: RFR: 6462028: MaskFormatter API documentation refers to getDisplayValue [v5]

2021-12-14 Thread Tejesh R
On Mon, 6 Dec 2021 17:16:20 GMT, Phil Race wrote: >> src/java.desktop/share/classes/javax/swing/text/MaskFormatter.java line 103: >> >>> 101: * MaskFormatter formatter = new MaskFormatter("###-"); >>> 102: * formatter.setPlaceholderCharacter('_'); >>> 103: * formatter.getDisplayValu

Re: RFR: 6496103: isFileHidingEnabled return false by default [v2]

2021-12-14 Thread Tejesh R
On Wed, 15 Dec 2021 01:20:45 GMT, Sergey Bylokhov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 6496103: isFileHidingEnabled return false by default > > src/java.desktop/share/classes

Re: RFR: 6496103: isFileHidingEnabled return false by default [v2]

2021-12-14 Thread Tejesh R
> The default value of this property is derived from native platform. The same > is updated in the documentation. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: 6496103: isFileHidingEnabled return false by d

Re: RFR: 6496103: isFileHidingEnabled return false by default [v2]

2021-12-15 Thread Tejesh R
On Wed, 15 Dec 2021 23:11:34 GMT, Sergey Bylokhov wrote: >> Sure @mrserb , updated the PR. > > Not sure the "native" is needed in the new version, any other thoughts from > anyone? Yeah, "native OS" and "OS" gives same meaning I guess.. - PR: https://git.openjdk.java.net/jdk/pull/

Re: RFR: 6465404: some problems in CellEditor related API docs [v5]

2021-12-16 Thread Tejesh R
On Thu, 16 Dec 2021 05:18:04 GMT, Sergey Bylokhov wrote: >> Hm… It's not the other way around. `DefaultCellEditor` implements >> `TableCellEditor`; the interface defines the `getTableCellEditorComponent` >> method that returns the _real component_ which will be used as the value >> editor. >>

Re: RFR: 6465404: some problems in CellEditor related API docs [v5]

2021-12-16 Thread Tejesh R
On Thu, 16 Dec 2021 10:04:49 GMT, Tejesh R wrote: >>> The object that implements the interface is not necessarily the editor for >>> values. DefaultCellEditor is the perfect example: it's not an editor >>> itself, it's not even a component, al

Re: RFR: 6496103: isFileHidingEnabled return false by default [v2]

2021-12-19 Thread Tejesh R
On Fri, 17 Dec 2021 21:42:57 GMT, Phil Race wrote: > If we REALLY will always get it from the O/S, including on Linux, macOS and > whatever else .. then it is OK otherwise the new wording would be better. Haven't checked in Linux or macOS.. Yeah, I think no need to explicitly mention about

Re: RFR: 6496103: isFileHidingEnabled return false by default [v3]

2021-12-19 Thread Tejesh R
> The default value of this property is derived from native platform. The same > is updated in the documentation. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: 6496103: isFileHidingEnabled return false by d

Integrated: 6462028: MaskFormatter API documentation refers to getDisplayValue

2021-12-20 Thread Tejesh R
On Thu, 25 Nov 2021 09:54:47 GMT, Tejesh R wrote: > MaskFormatter API doesn't have getDisplayValue method, hence removed from > Documentation. This pull request has now been integrated. Changeset: 31fbb872 Author:TejeshR13 Committer: Jayathirth D V URL:

Re: RFR: 6496103: isFileHidingEnabled return false by default [v3]

2021-12-22 Thread Tejesh R
On Tue, 21 Dec 2021 20:35:56 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 6496103: isFileHidingEnabled return false by default > > src/java.desktop/share/classes

Re: RFR: 6465404: some problems in CellEditor related API docs [v6]

2021-12-22 Thread Tejesh R
> JListBox is invalid component. CellTableEditor Interface doesn't support > JComboBox and JTree components. Hence its removed from Documentation. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: 6465404: some problems in

Re: RFR: 6465404: some problems in CellEditor related API docs [v5]

2021-12-22 Thread Tejesh R
On Tue, 21 Dec 2021 21:23:18 GMT, Alexey Ivanov wrote: >> Clear and to the point. > > I wonder if it makes sense to update the Javadoc for `TreeCellEditor` for > consistency. Yeah, this description is clear and to the point. Will updated the PR. - PR: https://git.openjdk.java.net/

Re: RFR: 6465404: some problems in CellEditor related API docs [v6]

2021-12-22 Thread Tejesh R
On Tue, 21 Dec 2021 21:21:01 GMT, Alexey Ivanov wrote: >> I agree it probably referred to components which can be used as an editor. >> `DefaultEditorCell` supports three components: `JCheckBox`, `JComboBox`, and >> `JTextField`. >> >>> But the objects implemented TableCellEditor interface can

Re: RFR: 6465404: some problems in CellEditor related API docs [v6]

2022-01-03 Thread Tejesh R
On Mon, 3 Jan 2022 19:28:54 GMT, Phil Race wrote: > I don't see the CSR yet. Create it from the "More" menu of the JBS issue. Yes, CSR is created from JBS.. - PR: https://git.openjdk.java.net/jdk/pull/6608

Re: RFR: 6465404: some problems in CellEditor related API docs [v6]

2022-01-03 Thread Tejesh R
On Wed, 22 Dec 2021 11:13:56 GMT, Tejesh R wrote: >> JListBox is invalid component. CellTableEditor Interface doesn't support >> JComboBox and JTree components. Hence its removed from Documentation. > > Tejesh R has updated the pull request incrementally with one additio

Re: RFR: 6496103: isFileHidingEnabled return false by default [v3]

2022-01-03 Thread Tejesh R
On Mon, 20 Dec 2021 06:54:56 GMT, Tejesh R wrote: >> The default value of this property is derived from native platform. The same >> is updated in the documentation. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last rev

Re: RFR: 6496103: isFileHidingEnabled return false by default [v3]

2022-01-11 Thread Tejesh R
On Mon, 20 Dec 2021 06:54:56 GMT, Tejesh R wrote: >> The default value of this property is derived from native platform. The same >> is updated in the documentation. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last rev

Integrated: 6496103: isFileHidingEnabled return false by default

2022-01-11 Thread Tejesh R
On Thu, 9 Dec 2021 09:40:38 GMT, Tejesh R wrote: > The default value of this property is derived from native platform. The same > is updated in the documentation. This pull request has now been integrated. Changeset: 13bfb497 Author:TejeshR13 Committer: Jayathirth D V URL:

Integrated: 6465404: some problems in CellEditor related API docs

2022-01-18 Thread Tejesh R
On Tue, 30 Nov 2021 08:49:19 GMT, Tejesh R wrote: > JListBox is invalid component. CellTableEditor Interface doesn't support > JComboBox and JTree components. Hence its removed from Documentation. This pull request has now been integrated. Changeset: 44fe958c Author:TejeshR13

RFR: 8236907: JTable added to nested panels does not paint last visible row

2022-02-11 Thread Tejesh R
Issue in painting last row of JTable due to decrement in `MaxRow `during computation. Differences in `MaxRow `computation between `TablePrintable` and `BasicTableUI `class. The Bug is fixed in both the classes. Test Case added to validate the same. - Commit messages: - 8236907: JT

Re: RFR: 8236907: JTable added to nested panels does not paint last visible row

2022-02-15 Thread Tejesh R
On Mon, 14 Feb 2022 06:53:18 GMT, Prasanta Sadhukhan wrote: >> Issue in painting last row of JTable due to decrement in `MaxRow `during >> computation. Differences in `MaxRow `computation between `TablePrintable` >> and `BasicTableUI `class. The Bug is fixed in both the classes. Test Case >>

Re: RFR: 8236907: JTable added to nested panels does not paint last visible row

2022-02-16 Thread Tejesh R
On Tue, 15 Feb 2022 08:28:58 GMT, Tejesh R wrote: >> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTableUI.java line >> 1903: >> >>> 1901: private void paintDropLines(Graphics g) { >>> 1902: JTable.DropLocation loc = table.getDropL

Re: RFR: 8236907: JTable added to nested panels does not paint last visible row

2022-02-18 Thread Tejesh R
On Fri, 18 Feb 2022 04:59:27 GMT, Prasanta Sadhukhan wrote: >> Issue in painting last row of JTable due to decrement in `MaxRow `during >> computation. Differences in `MaxRow `computation between `TablePrintable` >> and `BasicTableUI `class. The Bug is fixed in both the classes. Test Case >>

Re: RFR: 8236907: JTable added to nested panels does not paint last visible row

2022-02-18 Thread Tejesh R
On Fri, 18 Feb 2022 05:04:52 GMT, Prasanta Sadhukhan wrote: >> Issue in painting last row of JTable due to decrement in `MaxRow `during >> computation. Differences in `MaxRow `computation between `TablePrintable` >> and `BasicTableUI `class. The Bug is fixed in both the classes. Test Case >>

Re: RFR: 8236907: JTable added to nested panels does not paint last visible row [v2]

2022-02-18 Thread Tejesh R
> Issue in painting last row of JTable due to decrement in `MaxRow `during > computation. Differences in `MaxRow `computation between `TablePrintable` and > `BasicTableUI `class. The Bug is fixed in both the classes. Test Case added > to validate the same. Tejesh R has updated the

Re: RFR: 8236907: JTable added to nested panels does not paint last visible row [v2]

2022-02-18 Thread Tejesh R
On Fri, 18 Feb 2022 05:00:28 GMT, Prasanta Sadhukhan wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8236907: JTable added to nested panels does not paint last > > test/

Re: RFR: 8236907: JTable added to nested panels does not paint last visible row [v3]

2022-02-20 Thread Tejesh R
> Issue in painting last row of JTable due to decrement in `MaxRow `during > computation. Differences in `MaxRow `computation between `TablePrintable` and > `BasicTableUI `class. The Bug is fixed in both the classes. Test Case added > to validate the same. Tejesh R has updated the

Re: RFR: 8236907: JTable added to nested panels does not paint last visible row [v2]

2022-02-20 Thread Tejesh R
On Fri, 18 Feb 2022 12:54:07 GMT, Prasanta Sadhukhan wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8236907: JTable added to nested panels does not paint last > > test/

Re: RFR: 8236907: JTable added to nested panels does not paint last visible row [v4]

2022-02-20 Thread Tejesh R
> Issue in painting last row of JTable due to decrement in `MaxRow `during > computation. Differences in `MaxRow `computation between `TablePrintable` and > `BasicTableUI `class. The Bug is fixed in both the classes. Test Case added > to validate the same. Tejesh R has updated the

Re: RFR: 8236907: JTable added to nested panels does not paint last visible row [v5]

2022-02-21 Thread Tejesh R
> Issue in painting last row of JTable due to decrement in `MaxRow `during > computation. Differences in `MaxRow `computation between `TablePrintable` and > `BasicTableUI `class. The Bug is fixed in both the classes. Test Case added > to validate the same. Tejesh R has updated the

Re: RFR: 8236907: JTable added to nested panels does not paint last visible row [v4]

2022-02-21 Thread Tejesh R
On Mon, 21 Feb 2022 05:50:06 GMT, Prasanta Sadhukhan wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8236907: JTable added to nested panels does not paint last > > test/

Re: RFR: 8236907: JTable added to nested panels does not paint last visible row [v6]

2022-02-21 Thread Tejesh R
> Issue in painting last row of JTable due to decrement in `MaxRow `during > computation. Differences in `MaxRow `computation between `TablePrintable` and > `BasicTableUI `class. The Bug is fixed in both the classes. Test Case added > to validate the same. Tejesh R has updated the

Re: RFR: 8236907: JTable added to nested panels does not paint last visible row [v6]

2022-02-22 Thread Tejesh R
On Tue, 22 Feb 2022 04:38:21 GMT, Tejesh R wrote: >> Issue in painting last row of JTable due to decrement in `MaxRow `during >> computation. Differences in `MaxRow `computation between `TablePrintable` >> and `BasicTableUI `class. The Bug is fixed in both the classes. Test

Re: RFR: 8236907: JTable added to nested panels does not paint last visible row [v6]

2022-02-27 Thread Tejesh R
On Fri, 25 Feb 2022 22:26:30 GMT, Phil Race wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8236907: JTable added to nested panels does not paint last > > src/java.desktop/share/classes/j

Re: RFR: 8236907: JTable added to nested panels does not paint last visible row [v6]

2022-02-27 Thread Tejesh R
On Fri, 25 Feb 2022 22:27:57 GMT, Phil Race wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8236907: JTable added to nested panels does not paint last > > src/java.desktop/share/classes/j

Re: RFR: 8236907: JTable added to nested panels does not paint last visible row [v6]

2022-02-27 Thread Tejesh R
On Fri, 25 Feb 2022 22:35:04 GMT, Phil Race wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8236907: JTable added to nested panels does not paint last > > src/java.desktop/share/classes/j

Integrated: 8236907: JTable added to nested panels does not paint last visible row

2022-03-04 Thread Tejesh R
On Thu, 10 Feb 2022 09:49:41 GMT, Tejesh R wrote: > Issue in painting last row of JTable due to decrement in `MaxRow `during > computation. Differences in `MaxRow `computation between `TablePrintable` and > `BasicTableUI `class. The Bug is fixed in both the classes. Test Case ad

RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-09 Thread Tejesh R
Removed the println() line from the Interrupted catch block. Since waitForID() Interrupt indicates completion of Image Loading, println as Interrupt handling was not required. - Commit messages: - 8236987: Remove call to System.out.println from ImageIcon.loadImage - 8236987: Remov

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-10 Thread Tejesh R
On Thu, 10 Mar 2022 13:19:22 GMT, Alexey Ivanov wrote: >> src/java.desktop/share/classes/javax/swing/ImageIcon.java line 331: >> >>> 329: mTracker.waitForID(id, 0); >>> 330: } catch (InterruptedException e) { >>> 331: System.out.println("INTERRUPTED wh

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-14 Thread Tejesh R
On Fri, 11 Mar 2022 21:46:23 GMT, Alexey Ivanov wrote: >> We shouldn't be setting any MediaTracker status here - this is the caller ! >> It would be absolutely wrong. And it seems likely to me that this println >> was put there by the developer of this code who was him/herself not sure if >> t

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-14 Thread Tejesh R
On Fri, 11 Mar 2022 21:46:23 GMT, Alexey Ivanov wrote: >> We shouldn't be setting any MediaTracker status here - this is the caller ! >> It would be absolutely wrong. And it seems likely to me that this println >> was put there by the developer of this code who was him/herself not sure if >> t

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-15 Thread Tejesh R
On Tue, 15 Mar 2022 11:47:28 GMT, Tejesh R wrote: >> @TejeshR13, What kind of image do you load? >> >> If I load an image from the Internet, I get `LOADING` status. I've attached >> `ImageIconInterrupt.java` to >> [JDK-6421373](https://bugs.openjdk.java.n

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-15 Thread Tejesh R
On Tue, 15 Mar 2022 09:43:13 GMT, Alexey Ivanov wrote: >> @aivanov-jdk , even after interrupted the load status gets the "COMPLETE" >> status and I'm able to use the Imageicon for frame.. > > @TejeshR13, What kind of image do you load? > > If I load an image from the Internet, I get `LOADIN

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-15 Thread Tejesh R
On Tue, 15 Mar 2022 12:00:33 GMT, Alexey Ivanov wrote: >> For url image I'm getting "ERRORED" as output.. > > A small file from local storage loads fast enough. By the time you get to > read status, load could complete. > > For the url, do you use the same URL? If the connection can be esta

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-15 Thread Tejesh R
On Tue, 15 Mar 2022 12:09:12 GMT, Tejesh R wrote: >> A small file from local storage loads fast enough. By the time you get to >> read status, load could complete. >> >> For the url, do you use the same URL? If the connection can be established, >> it should loa

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-15 Thread Tejesh R
On Tue, 15 Mar 2022 12:00:33 GMT, Alexey Ivanov wrote: >> For url image I'm getting "ERRORED" as output.. > > A small file from local storage loads fast enough. By the time you get to > read status, load could complete. > > For the url, do you use the same URL? If the connection can be esta

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-20 Thread Tejesh R
On Tue, 15 Mar 2022 16:49:56 GMT, Alexey Ivanov wrote: >>> @aivanov-jdk , U r right, the status remains LOADING for url.. I was >>> getting "ERRORED" because I was showing a message using >>> `JOptionPane.showMessageDialog(null, "");` before setting ImageIcon. >> >> Ah, with the message di

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-21 Thread Tejesh R
On Mon, 21 Mar 2022 13:19:14 GMT, Alexey Ivanov wrote: >> How about setting the status to ABORTED only if it is Interrupted.? >> >>> try { >>> mTracker.waitForID(id, 0); >>> } catch (InterruptedException e) { >>> bIsInterrupted = true;

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v2]

2022-03-21 Thread Tejesh R
> Removed the println() line from the Interrupted catch block. Since > waitForID() Interrupt indicates completion of Image Loading, println as > Interrupt handling was not required. Tejesh R has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v2]

2022-03-22 Thread Tejesh R
On Tue, 22 Mar 2022 11:30:13 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > src/java.desktop/share/classes/javax/swing/Imag

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v3]

2022-03-23 Thread Tejesh R
> Removed the println() line from the Interrupted catch block. Since > waitForID() Interrupt indicates completion of Image Loading, println as > Interrupt handling was not required. Tejesh R has updated the pull request with a new target base due to a merge or a rebase. The increment

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v4]

2022-03-23 Thread Tejesh R
> Removed the println() line from the Interrupted catch block. Since > waitForID() Interrupt indicates completion of Image Loading, println as > Interrupt handling was not required. Tejesh R has updated the pull request incrementally with three additional commits since the last

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v5]

2022-03-23 Thread Tejesh R
> Removed the println() line from the Interrupted catch block. Since > waitForID() Interrupt indicates completion of Image Loading, println as > Interrupt handling was not required. Tejesh R has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v2]

2022-03-23 Thread Tejesh R
On Tue, 22 Mar 2022 11:30:31 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > Changes requested by aivanov (Reviewer). @aivanov-jdk

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v5]

2022-03-24 Thread Tejesh R
On Thu, 24 Mar 2022 19:18:31 GMT, Phil Race wrote: >> src/java.desktop/share/classes/javax/swing/ImageIcon.java line 338: >> >>> 336: mTracker.removeImage(image, id); >>> 337: >>> 338: if (interrupted && ((loadStatus & MediaTracker.LOADING )!= >>> 0)) { >> >> Suggestio

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v5]

2022-03-25 Thread Tejesh R
On Wed, 23 Mar 2022 18:18:57 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > It looks good now. > > Is it possible to ad

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v12]

2022-04-06 Thread Tejesh R
> Removed the println() line from the Interrupted catch block. Since > waitForID() Interrupt indicates completion of Image Loading, println as > Interrupt handling was not required. Tejesh R has updated the pull request incrementally with one additional commit since the last

RFR: 8180276: JTextPane getText return extra when mixed with methods of Document

2022-04-06 Thread Tejesh R
getText function returned extra endOfLine when appended. The reason was in `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)` method, where translation happens from buffer to Out(Writer Object) if endOfLine is other than '\n' ( which is '\r\n' in windows). In order to w

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v13]

2022-04-06 Thread Tejesh R
> Removed the println() line from the Interrupted catch block. Since > waitForID() Interrupt indicates completion of Image Loading, println as > Interrupt handling was not required. Tejesh R has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v2]

2022-04-07 Thread Tejesh R
haracter to > '\n' is '\r', if true then whole string except Carriage Return ('\r') is > written, else whole string till before '\n' is written. Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v2]

2022-04-07 Thread Tejesh R
On Thu, 7 Apr 2022 11:19:53 GMT, Alexey Ivanov wrote: > > Why can't the test be automatic? Actually had thought about automating the test case, but since endOfLine(Win - '\r\n', linux - '\n') is different for different OS, have made it manual. - PR: https://git.openjdk.java.ne

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v3]

2022-04-07 Thread Tejesh R
haracter to > '\n' is '\r', if true then whole string except Carriage Return ('\r') is > written, else whole string till before '\n' is written. Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v14]

2022-04-08 Thread Tejesh R
> Removed the println() line from the Interrupted catch block. Since > waitForID() Interrupt indicates completion of Image Loading, println as > Interrupt handling was not required. Tejesh R has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v3]

2022-04-08 Thread Tejesh R
On Fri, 8 Apr 2022 08:38:20 GMT, Prasanta Sadhukhan wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Java coding style fix > > src/java.desktop/share/classes/javax/swing/text/Def

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v4]

2022-04-08 Thread Tejesh R
haracter to > '\n' is '\r', if true then whole string except Carriage Return ('\r') is > written, else whole string till before '\n' is written. Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v3]

2022-04-08 Thread Tejesh R
On Fri, 8 Apr 2022 09:02:53 GMT, Prasanta Sadhukhan wrote: > ok, so you are telling out.write(array, last, counter - last - 1) will write > till \r\n and out.write(endOfLine) will write \r\n, is it? Yes. - PR: https://git.openjdk.java.net/jdk/pull/8122

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v3]

2022-04-08 Thread Tejesh R
On Fri, 8 Apr 2022 11:25:36 GMT, Prasanta Sadhukhan wrote: >>> ok, so you are telling out.write(array, last, counter - last - 1) will >>> write till \r\n and out.write(endOfLine) will write \r\n, is it? >> >> Yes. > > So, presently it was writing /r/n/r/n and with fix, it will write > /r/n, r

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v3]

2022-04-08 Thread Tejesh R
On Fri, 8 Apr 2022 11:43:26 GMT, Alexey Ivanov wrote: >> But should /r/r/n cause 2 line feeds? /r should be just carriage return to >> cause caret to move from last column to first, why it is inserting new line? > > It is common to treat `\r` as new line if it's not followed by `\n`. In a > vis

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v3]

2022-04-08 Thread Tejesh R
On Fri, 8 Apr 2022 11:56:36 GMT, Prasanta Sadhukhan wrote: >>> But should /r/r/n cause 2 line feeds? /r should be just carriage return to >>> cause caret to move from last column to first, why it is inserting new line? >> >> \r is converted to \n in setText method... To be specific, in >>

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v2]

2022-04-08 Thread Tejesh R
On Fri, 8 Apr 2022 11:48:24 GMT, Alexey Ivanov wrote: > > > > > > > > > > Why can't the test be automatic? > > > > > > Actually had thought about automating the test case, but since > > endOfLine(Win - '\r\n', linux - '\n') is different for different OS, have > > made it manual. > > It ju

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v3]

2022-04-08 Thread Tejesh R
On Fri, 8 Apr 2022 12:08:07 GMT, Prasanta Sadhukhan wrote: >> Initially it is /r/r/n from `getText()` of pane0, later it is /n/r/n from >> `setText()` > > When you do out.write(array, last, counter - last); in write(Writer out, > Document doc, int pos, int len) method, what is being writte

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v5]

2022-04-08 Thread Tejesh R
haracter to > '\n' is '\r', if true then whole string except Carriage Return ('\r') is > written, else whole string till before '\n' is written. Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v5]

2022-04-10 Thread Tejesh R
On Fri, 8 Apr 2022 12:37:36 GMT, Alexey Ivanov wrote: > What happens if you add `\r` to an arbitrary location in text? > > What happens if you read in such a text? It doesn't matter, since the data is appended only if '\n' is present when EndofLine is '\r\n'.. - PR: https://g

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v2]

2022-04-10 Thread Tejesh R
On Mon, 11 Apr 2022 04:51:18 GMT, Prasanta Sadhukhan wrote: > If this is true, then I guess we can remove `if (array[counter - 1] == '\r')` > check too as it is always true in windows. If user uses system line separator then it vll be '\r\n' and it vll enter this loop, but if user manually en

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v2]

2022-04-10 Thread Tejesh R
On Mon, 11 Apr 2022 05:21:49 GMT, Prasanta Sadhukhan wrote: > I guess in that case "else" part in l359 will be executed...I was talking > about requirement of "else" part in l345 I did a sample test for this case, it did entered l345, I added \n manually at the end of string, since it passes

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v5]

2022-04-11 Thread Tejesh R
On Fri, 8 Apr 2022 12:17:37 GMT, Tejesh R wrote: >> getText function returned extra endOfLine when appended. The reason was in >> `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)` >> method, where translation happens from buffer to Out(Writer Object

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v2]

2022-04-11 Thread Tejesh R
On Mon, 11 Apr 2022 10:07:40 GMT, Alexey Ivanov wrote: > The user explicitly added a text with Windows line end into the text model. > When such a text is written out on Windows, an extra `\r` gets added. Then > when this text is read in, the `\r` which is not followed by `\n` gets > converted

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v5]

2022-04-11 Thread Tejesh R
On Mon, 11 Apr 2022 10:10:07 GMT, Alexey Ivanov wrote: > > > What happens if you add `\r` to an arbitrary location in text? > > > What happens if you read in such a text? > > > > > > It doesn't matter, since the data is appended only if '\n' is present when > > EndofLine is '\r\n'.. > > I

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v5]

2022-04-11 Thread Tejesh R
On Fri, 8 Apr 2022 12:17:37 GMT, Tejesh R wrote: >> getText function returned extra endOfLine when appended. The reason was in >> `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)` >> method, where translation happens from buffer to Out(Writer Object

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v5]

2022-04-11 Thread Tejesh R
On Mon, 11 Apr 2022 10:20:52 GMT, Alexey Ivanov wrote: > Is it a bug then? It is not a bug I guess, it is as expected and as commented out about the logic in `read()` method.. The bug states this statement " But if we use append() first and then setText(pane.getText + newText), before ever

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v5]

2022-04-11 Thread Tejesh R
On Fri, 8 Apr 2022 12:17:37 GMT, Tejesh R wrote: >> getText function returned extra endOfLine when appended. The reason was in >> `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)` >> method, where translation happens from buffer to Out(Writer Object

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v11]

2022-04-14 Thread Tejesh R
On Tue, 12 Apr 2022 20:50:48 GMT, Phil Race wrote: >> This is intentional, it makes sure the image is in `LOADING` state to verify >> that the newly added resets it to `ABORTED`. >> >> I don't expect the image to load, we don't care. If it succeeds, the status >> is `COMPLETE`; if it times out

Integrated: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-04-14 Thread Tejesh R
On Wed, 9 Mar 2022 10:04:09 GMT, Tejesh R wrote: > Removed the println() line from the Interrupted catch block. Since > waitForID() Interrupt indicates completion of Image Loading, println as > Interrupt handling was not required. This pull request has now been integrated.

Withdrawn: 8180276: JTextPane getText return extra when mixed with methods of Document

2022-04-17 Thread Tejesh R
On Wed, 6 Apr 2022 10:02:10 GMT, Tejesh R wrote: > getText function returned extra endOfLine when appended. The reason was in > `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)` > method, where translation happens from buffer to Out(Writer Object) if >

RFR: 8233477: [Win LAF]The tooltip doesn't display correctly in Win LAF

2022-05-01 Thread Tejesh R
In Button ToolTip Mnemonic key string was shown only in Metal Look and Feel, since the feature is implemented in it. In other L&F especially Windows L&F the feature is not available. In order to make it available for other L&F's, the getAcceleratedString method and calculateAcceleratedStringSpac

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v2]

2022-05-01 Thread Tejesh R
t > BasicToolTipUI can make use of the feature available in ToolTipUI. Tejesh R has updated the pull request incrementally with two additional commits since the last revision: - Feature moved to ToolTipUI and updated MetalToolTipUI Accordingly - Feature moved to ToolTipUI and updated MetalTool

RFR: 8134640 ( Left Insets Margin Test ) moved to open repo from closed

2022-05-02 Thread Tejesh R
The Test had been updated to use all Supported Look and Feel in closed repo. The same has been moved to open repo. - Commit messages: - Moved Test Case 4380543 from closed to open - Feature moved to ToolTipUI and updated MetalToolTipUI Accordingly - Feature moved to ToolTipUI and

Re: RFR: 8134640 ( Left Insets Margin Test ) moved to open repo from closed [v2]

2022-05-02 Thread Tejesh R
> The Test had been updated to use all Supported Look and Feel in closed repo. > The same has been moved to open repo. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Copyright Added - Changes: - all:

Withdrawn: 8134640 ( Left Insets Margin Test ) moved to open repo from closed

2022-05-02 Thread Tejesh R
On Mon, 2 May 2022 08:07:49 GMT, Tejesh R wrote: > The Test had been updated to use all Supported Look and Feel in closed repo. > The same has been moved to open repo. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/8497

RFR: 8134640 ( Left Insets Margin Test ) moved to open repo from closed

2022-05-02 Thread Tejesh R
The Test had been updated to use all Supported Look and Feel in closed repo. The same has been moved to open repo. - Commit messages: - Moved Test Case 4380543 from closed to open - Merge branch 'master' of github.com:TejeshR13/jdk - Merge branch 'openjdk:master' into master - Me

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v2]

2022-05-02 Thread Tejesh R
On Mon, 2 May 2022 05:03:40 GMT, Prasanta Sadhukhan wrote: > I believe you can migrate the closed test to open and iterate through all > L&Fs and add that to the PR. Means to Iterate through all L&F's and wait for specific amount of time for user to validate and go on to next L&F...? Beca

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v2]

2022-05-02 Thread Tejesh R
On Mon, 2 May 2022 03:21:25 GMT, Tejesh R wrote: >> In Button ToolTip, Mnemonic key string was shown only in Metal Look and >> Feel, since the feature is implemented in it. In other L&F especially >> Windows L&F the feature is not available. In order to make it ava

Re: RFR: 8134640 ( Left Insets Margin Test ) moved to open repo from closed [v2]

2022-05-03 Thread Tejesh R
> The Test had been updated to use all Supported Look and Feel in closed repo. > The same has been moved to open repo. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Copyright Year updated - Changes: - all:

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v3]

2022-05-06 Thread Tejesh R
t > BasicToolTipUI can make use of the feature available in ToolTipUI. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Added Regression Test JToolTip/5047379/bug5047379.java - Changes: - all: https://git.o

Withdrawn: 8134640 ( Left Insets Margin Test ) moved to open repo from closed

2022-05-11 Thread Tejesh R
On Mon, 2 May 2022 11:31:17 GMT, Tejesh R wrote: > The Test had been updated to use all Supported Look and Feel in closed repo. > The same has been moved to open repo. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/8500

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v4]

2022-05-12 Thread Tejesh R
t > BasicToolTipUI can make use of the feature available in ToolTipUI. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Removed the test from open, updated in closed - Changes: - all: https://git.openjdk.java.net/jdk/pull/84

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v4]

2022-05-12 Thread Tejesh R
On Mon, 9 May 2022 05:27:54 GMT, Prasanta Sadhukhan wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed the test from open, updated in closed > > src/java.desktop/share/

  1   2   >