Re: RFR: 8205137: Remove Applet support from SwingSet2

2021-09-08 Thread Victor Dyakov
On Tue, 7 Sep 2021 22:08:58 GMT, Alisen Chung wrote: > removed support for running demo from applet for J2Ddemo and SwingSet2 > same PR as 8205137: Remove Applet support from SwingSet2 #5400 (changed > branch name) @azuev-java please review - PR: https://git.openjdk.java.net/jdk

Re: RFR: 8271071 accessibility of a table on macOS lacks cell navigation

2021-09-10 Thread Victor Dyakov
On Fri, 10 Sep 2021 15:11:20 GMT, Artem Semenov wrote: > We've extended the current implementation of TableAccessibility to make sure > that individual cells are voiced when navigating with the keyboard. @pankaj-bansal @azuev-java please review - PR: https://git.openjdk.java.net/

Re: RFR: 8262945: [macos] Regression Manual Test for Key Events Fails [v3]

2021-09-28 Thread Victor Dyakov
On Mon, 27 Sep 2021 16:19:21 GMT, Alisen Chung wrote: >> Added a check for active keyboard language and added support for Russian >> NSEvent keyCodes to JavaVirtualKeyCode translation. Originally, only English >> characters were checked for even if other languages were in native >> letterChar

Re: RFR: 8271071 accessibility of a table on macOS lacks cell navigation [v5]

2021-10-11 Thread Victor Dyakov
On Thu, 30 Sep 2021 12:02:08 GMT, Artem Semenov wrote: >> We've extended the current implementation of TableAccessibility to make sure >> that individual cells are voiced when navigating with the keyboard. > > Artem Semenov has refreshed the contents of this pull request, and previous > commits

Re: RFR: 8185429: [macos] After the dialog is closed, there is no window become active.

2021-10-14 Thread Victor Dyakov
On Sun, 10 Oct 2021 21:26:05 GMT, Alisen Chung wrote: > After a modal dialog is closed, its parent window should be pushed to the > front and made key. @prsadhuk please review @azuev-java please review this JBS ID is referenced in the problem list, so the problem list file should be update

Re: RFR: 8275809: crash in [CommonComponentAccessibility getCAccessible:withEnv:]

2021-10-22 Thread Victor Dyakov
On Fri, 22 Oct 2021 16:47:24 GMT, Anton Tarasov wrote: > Adding a JNI weak ref check. There's a couple of other similar places in the > code where a JNI weak ref is checked for null, in the rest of the code we > pass such refs to java where they are checked for null. So, I was not able to > ey

Re: RFR: 8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak

2021-10-22 Thread Victor Dyakov
On Fri, 22 Oct 2021 16:02:32 GMT, Anton Tarasov wrote: > This is a reimplementation of the `isWrapped` logic in the method: > > `+[CommonComponentAccessibility > createWithParent:accessible:role:index:withEnv:withView:isWrapped:]` > > The `isWrapped` arg was used to create an a11y element whic

Re: RFR: 8264293: Create implementation for NSAccessibilityMenu protocol peer

2021-11-16 Thread Victor Dyakov
On Tue, 16 Nov 2021 23:53:53 GMT, Alexander Zuev wrote: > Added implementation for all menu related protocol peers; > Native methods moved to CommonComponentAccessibility so they are called on > correct peers; @pankaj-bansal please review @forantar please review - PR: https://git

Re: RFR: 8275071: [macos] A11y cursor gets stuck when combobox is closed

2021-11-17 Thread Victor Dyakov
On Wed, 17 Nov 2021 00:57:47 GMT, Alexander Zuev wrote: > Before the new JList accessibility peer implementation sending popup closed > event to the combobox popup could trigger the native memory access error due > to the events arriving in the wrong order. After new implementation is done > it i

Re: RFR: 8264297: Create implementation for NSAccessibilityProgressIndicator protocol peer

2021-11-18 Thread Victor Dyakov
On Thu, 18 Nov 2021 19:04:05 GMT, Alexander Zuev wrote: > Add component accessibility peer @forantar please review @pankaj-bansal please review - PR: https://git.openjdk.java.net/jdk/pull/6462

Re: RFR: 8272392 Lanai: SwingSet2. Black background on expanding tree node [v2]

2021-11-29 Thread Victor Dyakov
On Fri, 26 Nov 2021 09:02:37 GMT, Alexey Ushakov wrote: >> Removed creation of the separate encoder depending on destination properties >> as we don't use this info to customize the encoder properties > > Alexey Ushakov has updated the pull request incrementally with one additional > commit sin

Re: RFR: 6465404: some problems in CellEditor related API docs

2021-12-06 Thread Victor Dyakov
On Tue, 30 Nov 2021 08:49:19 GMT, Tejesh R wrote: > JListBox is invalid component. CellTableEditor Interface doesn't support > JComboBox and JTree components. Hence its removed from Documentation. @azuev-java please review - PR: https://git.openjdk.java.net/jdk/pull/6608

Re: RFR: 8275843: Random crashes while the UI code is executed

2021-12-10 Thread Victor Dyakov
On Mon, 1 Nov 2021 20:03:42 GMT, Sergey Bylokhov wrote: > Please take a look to one more wagon in this train: > [JDK-8176795](https://bugs.openjdk.java.net/browse/JDK-8176795)->[JDK-8204931](https://bugs.openjdk.java.net/browse/JDK-8204931)->[JDK-8214579](https://bugs.openjdk.java.net/browse/JDK-

Re: RFR: 8278612: test/jdk/java/awt/dnd/RemoveDropTargetCrashTest crashes with VoiceOver on macOS

2021-12-15 Thread Victor Dyakov
On Mon, 13 Dec 2021 16:50:00 GMT, Anton Tarasov wrote: > … VoiceOver on macOS @forantar please re-submit at 18 forked - PR: https://git.openjdk.java.net/jdk/pull/6816

Re: RFR: 8278609: accessibility frame is misplaced on a secondary monitor on macOS

2021-12-17 Thread Victor Dyakov
On Mon, 13 Dec 2021 15:33:48 GMT, Aleksandr Veselov wrote: > Use primary screen instead of window main screen to properly convert mouse > position from screen coordinates to window ones. please re-submit against 18 repo - PR: https://git.openjdk.java.net/jdk/pull/6815

Re: RFR: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel [v11]

2022-01-05 Thread Victor Dyakov
On Wed, 5 Jan 2022 16:58:53 GMT, Alisen Chung wrote: >> Adjusted the AquaLF scrollbar to account for border inset settings when >> dragging the thumb and clicking on the track. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8279879: [TESTBUG] [macos] ActionEvent triggered when right-clicking TrayIcon

2022-01-11 Thread Victor Dyakov
On Tue, 11 Jan 2022 19:29:11 GMT, Alisen Chung wrote: > fixed test bug, removed extra ActionEvent from TrayIcon @azvegint please review - PR: https://git.openjdk.java.net/jdk/pull/7035

Re: RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader

2022-01-26 Thread Victor Dyakov
On Wed, 26 Jan 2022 00:12:17 GMT, Harshitha Onkar wrote: > A new test case was added to test the fix as there was no corresponding test > case present for this issue previously. @prsadhuk please review - PR: https://git.openjdk.java.net/jdk/pull/7219

Re: RFR: 8279586: [macos] custom JCheckBox and JRadioBox with custom icon set: focus is still displayed after unchecking

2022-01-31 Thread Victor Dyakov
On Mon, 31 Jan 2022 09:44:43 GMT, Alexander Zuev wrote: > Make border painting for the check boxes and radio buttons with custom icons > take into account the property that enables or disables the focus painting. > Add that case to the test. @azvegint @aivanov-jdk please review - P

Re: RFR: 8286266: [macos] Voice over moving JTable column to be the first column JVM crashes [v2]

2022-05-19 Thread Victor Dyakov
On Fri, 13 May 2022 18:36:37 GMT, Alexander Zuev wrote: >> Moving cache invalidation from the clearCache method to a createRowWithIndex >> method >> eliminating race condition that causes crash. Now clearCache just notifies >> that cache >> is invalid and should be regenerated next time it is b

Re: RFR: 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox

2022-05-23 Thread Victor Dyakov
On Fri, 20 May 2022 21:13:35 GMT, Alexander Zuev wrote: > Check for the available range on the document model and adjust text range > request accordingly. @prsadhuk please review - PR: https://git.openjdk.java.net/jdk/pull/8820

Re: RFR: 8282578: AIOOBE in javax.sound.sampled.Clip

2022-06-03 Thread Victor Dyakov
On Fri, 3 Jun 2022 15:43:39 GMT, Alexander Zuev wrote: > Add try/catch clause to ignore an exception since it is harmless for we > isolated > the massge data before passing it ro processor. > Add test case. @azvegint @prrace please review - PR: https://git.openjdk.java.net/jdk/pul