On m1 mac sometimes (in very rare instance) it takes a long time to get the
sequencer so increasing timeout helps with that.
Also on m1 mac sequencer got notified about the first MetaMessage twice. The
reason is unclear but watching for that fixes the problem. Also on Linux
sometimes process
On Mon, 14 Nov 2022 19:44:17 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have this update reviewed?
>>
>> The sprintf is deprecated in Xcode 14 because of security concerns, and the
>> use of it causing building failure. The build could pass if warnings are
>> disabled for codes that
On Fri, 11 Nov 2022 08:18:19 GMT, Tejesh R wrote:
> Observation found when JFileChooser is instantiated in WindowsLookAndFeel
> which invokes getSystemIcon() from WindowsFileChooserUI class. Could not find
> the exact root cause so predicting it to be an issue with icons not loaded
> where
On Mon, 14 Nov 2022 21:17:43 GMT, Phil Race wrote:
> So it now passes 100% of the time on the OCI systems ?
At least in my testing, links of those OCI jobs have been put in JBS too
-
PR: https://git.openjdk.org/jdk/pull/11057
On Mon, 14 Nov 2022 04:53:50 GMT, Abhishek Kumar wrote:
>> Existing test
>> `open/test/jdk/javax/swing/JRadioButton/4314194/bug4314194.java` was not
>> showing colored text for disabled checkbox and radiobutton in GTK LAF.
>>
>> The fix is to get the disabled state color for checkbox and
This test was problem listed with ["some tests that leave windows open on the
desktop"
reason](https://github.com/openjdk/jdk/commit/fd8df3adf13f5df8f5f95482b8e0a70bc519f39f)
The main issue with the test is that it may pass, but in fact the actual test
was not even performed. `jtreg` kills the
On Mon, 14 Nov 2022 19:09:40 GMT, Alisen Chung wrote:
>> These look to me like tabs have not been replaced by spaces..
>> I saw a lot of "shifts" and I spot-checked some of them but they looked like
>> ones where upstream had readily changed indentation.
>> This does not look like that.
>
> I'm
On Mon, 14 Nov 2022 06:56:20 GMT, Prasanta Sadhukhan
wrote:
>> Test intermittently fails in VM citing "Tree is not editing". Seems to be
>> problem with mouse clicks not getting registered properly..
>> Similar test test/jdk/javax/swing/JTable/6263446/bug6263446.java is not
>> affected, so
On Fri, 11 Nov 2022 08:18:19 GMT, Tejesh R wrote:
> Observation found when JFileChooser is instantiated in WindowsLookAndFeel
> which invokes getSystemIcon() from WindowsFileChooserUI class. Could not find
> the exact root cause so predicting it to be an issue with icons not loaded
> where
On Fri, 11 Nov 2022 08:18:19 GMT, Tejesh R wrote:
> Observation found when JFileChooser is instantiated in WindowsLookAndFeel
> which invokes getSystemIcon() from WindowsFileChooserUI class. Could not find
> the exact root cause so predicting it to be an issue with icons not loaded
> where
On Mon, 14 Nov 2022 18:39:46 GMT, Phil Race wrote:
> So - apart from the last change to use volatile - you found nothing
> functionally wrong with the test ? There's so much clean up I can't be sure
> I'm not missing some functional change you made. If there was nothing wrong
> with it, why
On Sat, 12 Nov 2022 20:29:39 GMT, Phil Race wrote:
> This was a closed test - simply because it hadn't been reviewed for moving to
> open
> so I am doing it now whilst fixing a problem that was observed on the OL 8.x
> (and
> by implication an RHEL 8.x) desktop due to the screen menu bar
> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14 because of security concerns, and the
> use of it causing building failure. The build could pass if warnings are
> disabled for codes that use sprintf method. For the long run, the sprintf
> could be
On Mon, 14 Nov 2022 19:27:44 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/share/native/common/awt/utility/sizecalc.h line 94:
>>
>>> 92:
>>> 93: #define SAFE_SIZE_NEW_ARRAY2(type, n, m) \
>>> 94: (IS_SAFE_SIZE_MUL((m), (n)) && IS_SAFE_SIZE_MUL(sizeof(type), (n) *
>>> (m)) ? \
>>
>>
On Mon, 14 Nov 2022 19:20:25 GMT, Sergey Bylokhov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed casting in SAFE_SIZE_NEW_ARRAY2
>
> src/java.desktop/share/native/common/awt/utility/sizecalc.h line 94:
>
On Tue, 8 Nov 2022 23:43:23 GMT, Alexander Zuev wrote:
>> Removed the additional multiplication overflow detection.
>> Instead cast all the parameters to type_t just the way they are treated in
>> the existing size check macro.
>> This way there is no possibility to accidentally provide
On Mon, 14 Nov 2022 10:21:07 GMT, Thomas Stuefe wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> include missing os head file
>
> src/hotspot/share/adlc/output_c.cpp line 2570:
>
>> 2568: int idx =
On Mon, 14 Nov 2022 19:05:16 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have this update reviewed?
>>
>> The sprintf is deprecated in Xcode 14 because of security concerns, and the
>> use of it causing building failure. The build could pass if warnings are
>> disabled for codes that
> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14 because of security concerns, and the
> use of it causing building failure. The build could pass if warnings are
> disabled for codes that use sprintf method. For the long run, the sprintf
> could be
On Thu, 10 Nov 2022 23:28:13 GMT, Phil Race wrote:
>> src/java.desktop/share/native/liblcms/cmscgats.c line 2389:
>>
>>> 2387:
>>> 2388: SetData(it8, i, idField, Buffer);
>>> 2389: }
>>
>> Are these shifts caused by
> Updating LCMS to newest release
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
fixed indentation problem in cmscgats.c
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11000/files
- new:
On Mon, 14 Nov 2022 18:26:21 GMT, Phil Race wrote:
>> This was a closed test - simply because it hadn't been reviewed for moving
>> to open
>> so I am doing it now whilst fixing a problem that was observed on the OL 8.x
>> (and
>> by implication an RHEL 8.x) desktop due to the screen menu bar
On Mon, 14 Nov 2022 14:38:38 GMT, Alexander Zvegintsev
wrote:
>> This test currently passing as it is on all platforms, but it was
>> problemlisted with ["Problem List some tests that leave windows open on the
>> desktop"
>>
> This was a closed test - simply because it hadn't been reviewed for moving to
> open
> so I am doing it now whilst fixing a problem that was observed on the OL 8.x
> (and
> by implication an RHEL 8.x) desktop due to the screen menu bar rendering over
> one
> line of the undecorated window.
>
On Thu, 10 Nov 2022 08:01:38 GMT, Abhishek Kumar wrote:
> It seems there was a typo inside function `installListeners(Component, int)`
> and `removeListeners(Component)` on case EventID.CELLEDITOR.
>
> Changed the string from "getCellEditorMethod" to "getCellEditor" in
> `protected void
On Mon, 7 Nov 2022 07:28:02 GMT, Srinivas Mandalika
wrote:
>> 8295707: Create a regression test for JDK-7184401
>>
>> JDK-7184401 - JDk7u6 : Missing main menu bar in Netbeans after fix for
>> 7162144
>> Above bug got introduced due to a fix for
>>
On Fri, 11 Nov 2022 08:20:55 GMT, ravi gupta wrote:
>> This testcase Verify the content changes of a TextArea for the following
>> assertions.
>>
>> a. TextListener get invoked when the content of a TextArea gets changed.
>> b. TextListener not get invoked during text selection or when Special
On Mon, 14 Nov 2022 00:23:09 GMT, Alexander Zvegintsev
wrote:
> This is an old issue, which is no longer reproducible.
> The test is slightly stabilized for slow machines.
>
> CI testing looks good.
This pull request has now been integrated.
Changeset: b0edfc11
Author:Alexander
On Mon, 14 Nov 2022 08:08:53 GMT, Sergey Bylokhov wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Addressing review comments
>
> test/jdk/java/awt/Robot/ModifierRobotKey/ModifierRobotKeyTest.java line 159:
> This test currently passing as it is on all platforms, but it was
> problemlisted with ["Problem List some tests that leave windows open on the
> desktop"
> reason](https://github.com/openjdk/jdk/commit/fd8df3adf13f5df8f5f95482b8e0a70bc519f39f)
>
> So this test is cleaned up and stabilized.
On Fri, 11 Nov 2022 21:40:40 GMT, Sergey Bylokhov wrote:
>> We tried to do this, it leads to an endless repetition of the selected line
>> until it freezes.
>
> Probably because of the endless notifications loop? implementation of
> addSelectionInterval looks similar to setSelectionInterval.
On Mon, 14 Nov 2022 05:32:20 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have this update reviewed?
>>
>> The sprintf is deprecated in Xcode 14 because of security concerns, and the
>> use of it causing building failure. The build could pass if warnings are
>> disabled for codes that
On Mon, 14 Nov 2022 05:32:20 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have this update reviewed?
>>
>> The sprintf is deprecated in Xcode 14 because of security concerns, and the
>> use of it causing building failure. The build could pass if warnings are
>> disabled for codes that
On Mon, 7 Nov 2022 07:28:02 GMT, Srinivas Mandalika
wrote:
>> 8295707: Create a regression test for JDK-7184401
>>
>> JDK-7184401 - JDk7u6 : Missing main menu bar in Netbeans after fix for
>> 7162144
>> Above bug got introduced due to a fix for
>>
On Mon, 14 Nov 2022 00:12:00 GMT, Alexander Zvegintsev
wrote:
> This test currently passing as it is on all platforms, but it was
> problemlisted with ["Problem List some tests that leave windows open on the
> desktop"
>
On Mon, 14 Nov 2022 00:23:09 GMT, Alexander Zvegintsev
wrote:
> This is an old issue, which is no longer reproducible.
> The test is slightly stabilized for slow machines.
>
> CI testing looks good.
Marked as reviewed by serb (Reviewer).
-
PR:
On Sun, 13 Nov 2022 22:55:52 GMT, Xue-Lei Andrew Fan wrote:
> Please don't add uses of `jio_snprintf` or `::snprintf` to hotspot. Use
> `os::snprintf`.
I did not know this was our policy now. Sorry for giving the wrong advice.
Maybe we should add this to the hotspot style guide since I'm
On Sat, 12 Nov 2022 09:18:57 GMT, Andrey Turbanov wrote:
>> The native method used to access the private method in the `ICC_Profile`
>> class is replaced by the accessor.
>
> src/java.desktop/share/classes/sun/awt/AWTAccessor.java line 891:
>
>> 889: */
>> 890: public static
38 matches
Mail list logo
