RFR: 8297676: DataBuffer.TYPE_SHORT/TYPE_FLOAT/TYPE_DOUBLE are not placeholders

2022-11-25 Thread Sergey Bylokhov
The specification for the DataBuffer.TYPE_SHORT/TYPE_FLOAT/TYPE_DOUBLE mentioned that all of them are "Placeholder for future use" which is not true. They are used and it is possible to create the ComponentColorModel for each of this transferType. Also, there is a specific data buffer for each:

Withdrawn: 4668290: unclear spec for Polygon.bounds field

2022-11-25 Thread duke
On Mon, 26 Sep 2022 02:27:53 GMT, SWinxy wrote: > New documentation replaces the `This value can be null.`: > > When created, {@link #invalidate() invalidated}, or {@link #reset() reset}, > this becomes {@code null}. To get out of the null state, > {@link #getBounds()} called with {@link #npoint

Withdrawn: 4756278: RFE: Insufficient API documentation for java.awt.Polygon constructor

2022-11-25 Thread duke
On Mon, 26 Sep 2022 02:49:36 GMT, SWinxy wrote: > Appends: `, copying the array contents of {@code xpoints} and {@code > ypoints}` to specify that the arrays in the constructor are explicitly copied. This pull request has been closed without being integrated. - PR: https://git.ope

Re: RFR: JDK-8297523 : Various GetPrimitiveArrayCritical miss result - NULL check

2022-11-25 Thread Matthias Baesken
On Fri, 25 Nov 2022 13:09:27 GMT, Thomas Stuefe wrote: > Hi Matthias, > > But all this is just theoretical, right, since GPAC does not allocate memory > in hotspot? Your patch is fine, though I would prefer OOMEs instead of > silently omitting code. > > Cheers, Thomas Hi Thomas, from what I

Re: RFR: JDK-8297523 : Various GetPrimitiveArrayCritical miss result - NULL check

2022-11-25 Thread Thomas Stuefe
On Fri, 25 Nov 2022 09:15:08 GMT, Matthias Baesken wrote: > There are still a few places where GetPrimitiveArrayCritical calls miss the > result check. This should be adjusted. > A similar case was recently adjusted here : > https://bugs.openjdk.org/browse/JDK-8297480 Hi Matthias, But all thi

RFR: JDK-8297523 : Various GetPrimitiveArrayCritical miss result - NULL check

2022-11-25 Thread Matthias Baesken
There are still a few places where GetPrimitiveArrayCritical calls miss the result check. This should be adjusted. A similar case was recently adjusted here : https://bugs.openjdk.org/browse/JDK-8297480 - Commit messages: - JDK-8297523 Changes: https://git.openjdk.org/jdk/pull/113

Re: RFR: 8297481: Create a regression test for JDK-4424517

2022-11-25 Thread Srinivas Mandalika
On Fri, 25 Nov 2022 06:35:54 GMT, Sergey Bylokhov wrote: >> 8297481: Create a regression test for JDK-4424517 > > Marked as reviewed by serb (Reviewer). @mrserb Can you please psonsor this request ? - PR: https://git.openjdk.org/jdk/pull/11313

Re: RFR: 8295707: Create a regression test for JDK-7184401 [v2]

2022-11-25 Thread Srinivas Mandalika
On Mon, 7 Nov 2022 07:28:02 GMT, Srinivas Mandalika wrote: >> 8295707: Create a regression test for JDK-7184401 >> >> JDK-7184401 - JDk7u6 : Missing main menu bar in Netbeans after fix for >> 7162144 >> Above bug got introduced due to a fix for >> [JDK-7162144](https://bugs.openjdk.java.net/b