Re: RFR: 6603771: Nimbus L&F: Ctrl+F7 keybinding for Jinternal Frame throws a NPE.

2022-12-11 Thread Prasanta Sadhukhan
On Fri, 9 Dec 2022 19:20:24 GMT, Sergey Bylokhov wrote: > It would be good to add a test case to make sure this bug will not happen > someday again. I tried but it seems AWT EventQueue is gobbling up the NPE and not throwing it to application which is why even though NPE is seen but test does

Re: RFR: 8218474: JComboBox display issue with GTKLookAndFeel

2022-12-11 Thread Tejesh R
On Wed, 7 Dec 2022 10:25:31 GMT, Abhishek Kumar wrote: > In case of GTK LAF, the current selected element was not visible due to > arrowbutton is rendered in entire display area of Combobox. > > The proposed fix is to set the `squareButton `property of combobox to `false > `so that the arrowbu

RFR: 8280359: Try to remove duplicate code for coordinate calculation

2022-12-11 Thread Sergey Bylokhov
The code from `AccessibilityGraphicsEnvironment` is moved/merged back to the `SunGraphicsEnvironment` from where it was initially [copied](https://github.com/openjdk/jdk18/pull/72#issuecomment-1001050200). The required API is exported from the `sun.java2d` to the `jdk.accessibility`(on WIndows

RFR: 4912623: GTK L&F: Folder list of the JFileChooser is allowing multiple selection unlike native

2022-12-11 Thread Abhishek Kumar
It is not possible to select all files on press of Ctrl+A in JFileChooser for GTK LAF where as all folders can be selected. In native side on press of Ctrl+A, able to select all files as well as folders. Proposed fix is to enable `multiselection `property by default for JFileChooser in GTK LAF

Re: RFR: 7030853: JDK 7 Serializable Swing classes not compatible with JDK 6 [v6]

2022-12-11 Thread Prasanta Sadhukhan
> The serialized form of the following classes in JDK 7 builds are not > compatible with prior versions of Java: > javax.swing.text.html.parser.ParserDelegator > javax.swing.LayoutComparator > They need to be declared as not compatible between releases in the API > documentation, as is th

Re: RFR: 7030853: JDK 7 Serializable Swing classes not compatible with JDK 6 [v5]

2022-12-11 Thread Prasanta Sadhukhan
> The serialized form of the following classes in JDK 7 builds are not > compatible with prior versions of Java: > javax.swing.text.html.parser.ParserDelegator > javax.swing.LayoutComparator > They need to be declared as not compatible between releases in the API > documentation, as is th

Re: RFR: JDK-8296661 : Typo Found In CSSParser.java [v3]

2022-12-11 Thread ScientificWare
> This is referenced in Java Bug Database as > - [JDK-8296661 : Typo Found In > CSSParser.java](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8296661) > > This is tracked in JBS as > - [JDK-8296661 : Typo Found In > CSSParser.java](https://bugs.openjdk.java.net/browse/JDK-8296661) > > I

Re: RFR: JDK-8296661 : Typo Found In CSSParser.java [v2]

2022-12-11 Thread ScientificWare
On Mon, 5 Dec 2022 18:56:40 GMT, Alexey Ivanov wrote: >> ScientificWare has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Another type. >> >> Replace one by once. > > src/java.desktop/share/classes/javax/swing/text/html/CSSParser.java

Re: RFR: JDK-8296661 : Typo Found In CSSParser.java [v2]

2022-12-11 Thread SWinxy
On Sat, 10 Dec 2022 12:37:42 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8296661 : Typo Found In >> CSSParser.java](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8296661) >> >> This is tracked in JBS as >> - [JDK-8296661 : Typo Found In >> CSSPars