Re: RFR: 8304912: Use OperatingSystem enum in java.desktop module [v6]

2023-04-10 Thread Andrey Turbanov
On Mon, 10 Apr 2023 16:56:43 GMT, Roger Riggs wrote: >> Update classes in the java.desktop module to use the >> jdk.internal.util.OperatingSystem enum instead of the `os.name` system >> property to select OS specific behaviors. > > Roger Riggs has updated the pull request incrementally with one

Integrated: 8304717: Declaration aliasing between boolean and jboolean is wrong

2023-04-10 Thread Julian Waters
On Wed, 22 Mar 2023 14:02:53 GMT, Julian Waters wrote: > A couple of spots wrongly refer to boolean and jboolean as the same thing. > While this does still compile thanks to a happy accident and implicit > conversions, they are not the same at all, and should be fixed before a > future compile

Re: RFR: 8305780: javax/swing/JTable/7068740/bug7068740.java fails on Ubunutu 20.04

2023-04-10 Thread Prasanta Sadhukhan
On Tue, 11 Apr 2023 03:47:04 GMT, Prasanta Sadhukhan wrote: > Although not able to reproduce this locally or in mach5, it can happen when > robot key movements start happening before frame is visible, > so added stability fixes like delay of 1s after frame is visible and key > movements are do

Re: RFR: 8305778: javax/swing/JTableHeader/6884066/bug6884066.java: Unexpected header's value; index = 4 value = E

2023-04-10 Thread Prasanta Sadhukhan
On Tue, 11 Apr 2023 05:04:02 GMT, Prasanta Sadhukhan wrote: > Although not reproducible locally or in mach5, some stability fixes have been > added in the test like > induce 1s delay after frame is made visible, increase autodelay time, move > frame to center of screen and also dispose frame a

RFR: 8305778: javax/swing/JTableHeader/6884066/bug6884066.java: Unexpected header's value; index = 4 value = E

2023-04-10 Thread Prasanta Sadhukhan
Although not reproducible locally or in mach5, some stability fixes have been added in the test like induce 1s delay after frame is made visible, increase autodelay time, move frame to center of screen and also dispose frame at end. Modified test pass for several iterations in all platforms. Lin

Re: RFR: 8303904: Transparent Windows Paint Wrong (Opaque) w/o Volatile Buffering [v2]

2023-04-10 Thread Jeremy
> The original write-up contains two complaints: > 1. The window is opaque, so pixels that should be transparent are black. > 2. The window is the wrong resolution. On a 200% resolution monitor it > renders as if it were 100% (so it looks pixelated). > > I recommend splitting this up into separat

Re: RFR: JDK-8303950: [macos]Translucent Windows Flicker on Repaint [v6]

2023-04-10 Thread Jeremy
> I'm confident about the new test case for this ticket, but the resolution is > more invasive than I'd like. (It works, though.) > > In short: > This introduces a new RenderingHint (in SunHints) to bypass the call in > Window to `gg2d.fillRect(0, 0, getWidth(), getHeight());` > > I left more d

RFR: 8305780: javax/swing/JTable/7068740/bug7068740.java fails on Ubunutu 20.04

2023-04-10 Thread Prasanta Sadhukhan
Although not able to reproduce this locally or in mach5, it can happen when robot key movements start happening before frame is visible, so added stability fixes like delay of 1s after frame is visible and key movements are done, added waitForIdle, increase autodelay time, added frame dispose al

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException

2023-04-10 Thread Jeremy
On Mon, 10 Apr 2023 16:16:32 GMT, Jeremy wrote: > This resolves a 25 year old P4 ticket: a NullPointerException is printed to > System.err needlessly. > > This resolution involves confirming that an ImageConsumer is still registered > before every notification. > > I'll understand if this is

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v2]

2023-04-10 Thread Jeremy
> This resolves a 25 year old P4 ticket: a NullPointerException is printed to > System.err needlessly. > > This resolution involves confirming that an ImageConsumer is still registered > before every notification. > > I'll understand if this is rejected as unimportant, but I stumbled across >

Re: RFR: 8304717: Declaration aliasing between boolean and jboolean is wrong [v4]

2023-04-10 Thread David Holmes
On Sat, 8 Apr 2023 13:26:36 GMT, Julian Waters wrote: >> A couple of spots wrongly refer to boolean and jboolean as the same thing. >> While this does still compile thanks to a happy accident and implicit >> conversions, they are not the same at all, and should be fixed before a >> future comp

Integrated: 8304501: Remove orphaned demo netbeans projects

2023-04-10 Thread Eirik Bjorsnos
On Mon, 20 Mar 2023 10:31:50 GMT, Eirik Bjorsnos wrote: > Please review this PR which suggests we remove the orhphaned `SwingApplet` > netbeans project directory. > > The `SwingApplet` demo was removed in > [JDK-8205119](https://bugs.openjdk.org/browse/JDK-8205119), but the netbeans > project

Re: RFR: 8305352: updateIconImages may lead to deadlock after JDK-8276849

2023-04-10 Thread Sergey Bylokhov
On Mon, 3 Apr 2023 09:55:40 GMT, Dmitry Cherepanov wrote: > Such notifications won't be ignored as isVisible() returns true for iconified > windows But it will be ignored if the window is invisible. It is better to fix the https://bugs.openjdk.org/browse/JDK-6995195 - PR Comment

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException

2023-04-10 Thread Sergey Bylokhov
On Mon, 10 Apr 2023 16:16:32 GMT, Jeremy wrote: > This resolves a 25 year old P4 ticket: a NullPointerException is printed to > System.err needlessly. > > This resolution involves confirming that an ImageConsumer is still registered > before every notification. > > I'll understand if this is

Re: RFR: 8305578: X11GraphicsDevice.pGetBounds() is slow in remote X11 sessions

2023-04-10 Thread Sergey Bylokhov
On Wed, 5 Apr 2023 08:19:50 GMT, Maxim Kartashev wrote: > Getting bounds of a `GraphicsDevice` and insets of a screen are fairly > frequent operations. When working over the network (remote X session), those > can take several *seconds* to complete, introducing repeated freezes even > when typ

Re: RFR: 8305578: X11GraphicsDevice.pGetBounds() is slow in remote X11 sessions

2023-04-10 Thread Sergey Bylokhov
On Wed, 5 Apr 2023 09:21:18 GMT, Maxim Kartashev wrote: > `X11GraphicsDevice.pGetBounds()`; I didn't measure further down. It would be good to know the exact function to check where it is used. - PR Comment: https://git.openjdk.org/jdk/pull/13346#issuecomment-1502492865

Re: RFR: 8279216: Investigate implementation of premultiplied alpha in the Little-CMS 2.13

2023-04-10 Thread Sergey Bylokhov
On Mon, 20 Mar 2023 01:07:25 GMT, Sergey Bylokhov wrote: > Support of premultiplied alpha is added to the "accelerated" code path of the > CMM. It is implemented on top of the new feature added to the littlecms > library in 2.13 and 2.15. > > The next formats are now "supported": TYPE_INT_ARGB

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException

2023-04-10 Thread Phil Race
On Mon, 10 Apr 2023 16:16:32 GMT, Jeremy wrote: > This resolves a 25 year old P4 ticket: a NullPointerException is printed to > System.err needlessly. > > This resolution involves confirming that an ImageConsumer is still registered > before every notification. > > I'll understand if this is

Re: RFR: 8304912: Use OperatingSystem enum in java.desktop module [v6]

2023-04-10 Thread Roger Riggs
> Update classes in the java.desktop module to use the > jdk.internal.util.OperatingSystem enum instead of the `os.name` system > property to select OS specific behaviors. Roger Riggs has updated the pull request incrementally with one additional commit since the last revision: Revert copyri

RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException

2023-04-10 Thread Jeremy
This resolves a 25 year old P4 ticket: a NullPointerException is printed to System.err needlessly. This resolution involves confirming that an ImageConsumer is still registered before every notification. I'll understand if this is rejected as unimportant, but I stumbled across this in the real

Re: RFR: 8304912: Use OperatingSystem enum in java.desktop module [v4]

2023-04-10 Thread Andrey Turbanov
On Sat, 8 Apr 2023 03:51:26 GMT, Phil Race wrote: >> Roger Riggs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >> commits sin

RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode()

2023-04-10 Thread Prasanta Sadhukhan
Two CSS AttributeSet-s can be compared using the AttributeSet.isEqual() method which can fail due to missing implementation of equals method in CSS subclasses. In this issue, even when two CSS AttributeSet has same 42 font size string value, Object equality fails. Fixed by implementing the equali

Re: RFR: 8305578: X11GraphicsDevice.pGetBounds() is slow in remote X11 sessions

2023-04-10 Thread Nikita Gubarkov
On Wed, 5 Apr 2023 08:19:50 GMT, Maxim Kartashev wrote: > Getting bounds of a `GraphicsDevice` and insets of a screen are fairly > frequent operations. When working over the network (remote X session), those > can take several *seconds* to complete, introducing repeated freezes even > when typ

Re: RFR: 8299713: Test javax/swing/JTableHeader/6889007/bug6889007.java failed: Wrong type of cursor

2023-04-10 Thread Prasanta Sadhukhan
On Wed, 25 Jan 2023 08:32:33 GMT, Prasanta Sadhukhan wrote: > Issue seems to be very old, very intermittent bug which is not reproducible > in repeated test run, > so added some stability fixes like accessing swing components in EDT, delay, > frame dispose and take a screenshot during fail. >

Integrated: 4825182: DefaultBoundedRangeModel.setMinimum() changes extent unnecessarily

2023-04-10 Thread Prasanta Sadhukhan
On Thu, 6 Apr 2023 14:15:37 GMT, Prasanta Sadhukhan wrote: > [DefaultBoundedRangeModel > spec](https://docs.oracle.com/en/java/javase/19/docs/api/java.desktop/javax/swing/DefaultBoundedRangeModel.html#%3Cinit%3E(int,int,int,int)) > set maximum, minimun., extent as per the constraint "min <= val

Re: RFR: 8305578: X11GraphicsDevice.pGetBounds() is slow in remote X11 sessions

2023-04-10 Thread Maxim Kartashev
On Fri, 7 Apr 2023 20:38:47 GMT, Phil Race wrote: > Multiple seconds seems out of bounds (so to speak :-)), for network latency > of an X11 round trip. Most certainly. What I actually measured was the time (min, max, and average) the AWT lock was being held by a method. In fact, the story beg