RFR: 8315834: Open source several Swing JSpinner related tests

2023-09-11 Thread Tejesh R
Open source these Swing JSpinner related tests: javax/swing/JSpinner/4522737/bug4522737.java javax/swing/JSpinner/4656590/bug4656590.java javax/swing/JSpinner/4680204/bug4680204.java javax/swing/JSpinner/4862257/bug4862257.java javax/swing/JSpinner/5104421/bug5104421.java - Commit me

Re: RFR: 8315663: Open source misc awt tests [v2]

2023-09-11 Thread Tejesh R
On Mon, 11 Sep 2023 05:44:27 GMT, Prasanta Sadhukhan wrote: >> Some closed awt tests are opensourced > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Test resource Marked as reviewed by tr (Committer). -

Re: RFR: 8315677: Open source few swing JFileChooser and other tests

2023-09-11 Thread Tejesh R
On Thu, 7 Sep 2023 18:57:50 GMT, Abhishek Kumar wrote: > Few closed JFileChooser and other swing tests are open sourced. test/jdk/javax/swing/JFileChooser/bug4624353.java line 55: > 53: fr.getContentPane().add(fc); > 54: fr.pack(); > 55: fr.setVis

Re: RFR: 8315761: Open source few swing JList and JMenuBar tests [v2]

2023-09-11 Thread Tejesh R
On Fri, 8 Sep 2023 10:14:20 GMT, Abhishek Kumar wrote: >> Few closed JList and JMenubar swing tests are open sourced. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Review comment update Marked as reviewed by tr (Commit

RFR: 8315986: javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location

2023-09-11 Thread Prasanta Sadhukhan
Test was run without waiting for UI to be made visible leading to IllegalComponentStateException. Used robot.delay consistent with other headful tests to made the test wait after UI is created and shown. Test passed in several iterations in all platforms. Link in JBS - Commit messa

Re: RFR: 8315990: Amend PL tests to proper category [v3]

2023-09-11 Thread Prasanta Sadhukhan
On Mon, 11 Sep 2023 13:34:28 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> PL amend > > test/jdk/ProblemList.txt line 471: > >> 469: java/awt/Mixing/AWT_Mixing/OpaqueOverlapping.java 829

Re: RFR: 8315990: Amend PL tests to proper category [v3]

2023-09-11 Thread Prasanta Sadhukhan
> Few awt problem listed tests are placed in swing category which should be > amended Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: PL amend - Changes: - all: https://git.openjdk.org/jdk/pull/15655/files - n

Re: RFR: 8315990: Amend PL tests to proper category [v2]

2023-09-11 Thread Prasanta Sadhukhan
> Few awt problem listed tests are placed in swing category which should be > amended Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: PL amend - Changes: - all: https://git.openjdk.org/jdk/pull/15655/files - n

Re: RFR: JDK-8315824: Open source several Swing Text/HTML related tests [v2]

2023-09-11 Thread Harshitha Onkar
> This PR open sources few Swing Text/HTML related tests. Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision: minor changes - Changes: - all: https://git.openjdk.org/jdk/pull/15675/files - new: https://git.openjdk.org

Re: RFR: 8316017: Refactor timeout handler in PassFailJFrame

2023-09-11 Thread lawrence . andrews
On Mon, 11 Sep 2023 18:18:28 GMT, Alexey Ivanov wrote: > Refactored timeout handling in PassFailJFrame: > > 1. Managing the timer and formatting the time left is inside `TimeoutHandler` > class. > 2. The class handles timer events and updates the label accordingly. > > This is implemented on t

RFR: JDK-8315824: Open source several Swing Text/HTML related tests

2023-09-11 Thread Harshitha Onkar
This PR open sources few Swing Text/HTML related tests. - Commit messages: - extra spacing - Text/HTML tests Changes: https://git.openjdk.org/jdk/pull/15675/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15675&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315824

RFR: 8315726: Open source several AWT applet tests

2023-09-11 Thread Alexander Zvegintsev
Some closed AWT test are open sourced. - Commit messages: - initial Changes: https://git.openjdk.org/jdk/pull/15671/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15671&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315726 Stats: 867 lines in 5 files changed: 867

Withdrawn: 8315882: Open some swing tests 2

2023-09-11 Thread Alisen Chung
On Thu, 7 Sep 2023 20:33:27 GMT, Alisen Chung wrote: > Opening some swing tests This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/15628

Withdrawn: 8315825: Open some swing tests

2023-09-11 Thread Alisen Chung
On Wed, 6 Sep 2023 23:19:58 GMT, Alisen Chung wrote: > Opening some closed swing tests This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/15606

Re: RFR: 8315825: Open some swing tests [v2]

2023-09-11 Thread Alisen Chung
> Opening some closed swing tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: named test frames - Changes: - all: https://git.openjdk.org/jdk/pull/15606/files - new: https://git.openjdk.org/jdk/pull/15606/files/9

Re: RFR: 8315882: Open some swing tests 2 [v3]

2023-09-11 Thread Alisen Chung
> Opening some swing tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: named test frames - Changes: - all: https://git.openjdk.org/jdk/pull/15628/files - new: https://git.openjdk.org/jdk/pull/15628/files/129bbf66

Re: RFR: 8315882: Open some swing tests 2 [v2]

2023-09-11 Thread Alisen Chung
> Opening some swing tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: finished updating SpringLayoutSetWidthTest - Changes: - all: https://git.openjdk.org/jdk/pull/15628/files - new: https://git.openjdk.org/jdk/

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI

2023-09-11 Thread Alexey Ivanov
On Thu, 31 Aug 2023 08:02:35 GMT, Prasanta Sadhukhan wrote: > After the first time a JTableHeader is serialized, it no longer will > uninstall its UI upon subsequent serializations. > This happens for classes that use the BasicTableHeaderUI class. Any LAF that > extends the BasicTableHeaderUI

RFR: 8316017: Refactor timeout handler in PassFailJFrame

2023-09-11 Thread Alexey Ivanov
Refactored timeout handling in PassFailJFrame: 1. Managing the timer and formatting the time left is inside `TimeoutHandler` class. 2. The class handles timer events and updates the label accordingly. This is implemented on top of #15665. - Depends on: https://git.openjdk.org/jdk/p

RFR: 8316025: Use testUI() method of PassFailJFrame.Builder in FileChooserSymLinkTest.java

2023-09-11 Thread Alexey Ivanov
This update to `FileChooserSymLinkTest.java` demonstrates the usage of the `testUI` method of the `PassFailJFrame.Builder` class to streamline creating the UI for manual tests. The [`main` method](https://github.com/aivanov-jdk/jdk/blob/cb1835527d718226f1c6fdd85ff5986703ea356f/test/jdk/javax/sw

RFR: 8294156: Allow PassFailJFrame.Builder to create test UI

2023-09-11 Thread Alexey Ivanov
This enhances the `Builder` pattern added in [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method `testUI` which allows passing a lambda expression or a method reference to create *the test UI window*. The `PassFailJFrame` will automatically call the method on the EDT to

Re: RFR: 8316003: Update FileChooserSymLinkTest.java to HTML instructions [v2]

2023-09-11 Thread Alexey Ivanov
> To demonstrate the functionality of HTML formatting in `PassFailJFrame`, I > updated the instructions for the > `test/jdk/javax/swing/JFileChooser/FileChooserSymLinkTest.java` test. The > commands to create the symbolic links are marked up with monospace font, > which makes them stand out. Th

Re: RFR: 8315990: Amend PL tests to proper category

2023-09-11 Thread Alexey Ivanov
On Mon, 11 Sep 2023 09:42:36 GMT, Prasanta Sadhukhan wrote: > Few awt problem listed tests are placed in swing category which should be > amended test/jdk/ProblemList.txt line 471: > 469: java/awt/Mixing/AWT_Mixing/OpaqueOverlapping.java 8294264 windows-x64 > 470: > 471: java/awt/dnd/Missing

RFR: 8316003: Update FileChooserSymLinkTest.java to HTML instructions

2023-09-11 Thread Alexey Ivanov
To demonstrate the functionality of HTML formatting in `PassFailJFrame`, I updated the instructions for the `test/jdk/javax/swing/JFileChooser/FileChooserSymLinkTest.java` test. The commands to create the symbolic links are marked up with monospace font, which makes them stand out. The test ins

Integrated: 8315611: Open source swing text/html and tree test

2023-09-11 Thread Prasanta Sadhukhan
On Thu, 7 Sep 2023 04:45:47 GMT, Prasanta Sadhukhan wrote: > Few closed swing text/html and tree tests are opensourced This pull request has now been integrated. Changeset: ae08143d Author:Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/commit/ae08143d3dd3aa559447623389a5b23c5d

Re: RFR: 8315611: Open source swing text/html and tree test [v2]

2023-09-11 Thread Prasanta Sadhukhan
> Few closed swing text/html and tree tests are opensourced Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Spacing - Changes: - all: https://git.openjdk.org/jdk/pull/15608/files - new: https://git.openjdk.org/

RFR: 8294158: HTML formatting for PassFailJFrame instructions

2023-09-11 Thread Alexey Ivanov
This enhancement provides HTML formatting for instructions in the manual test framework, `PassFailJFrame`. Some tests could benefit from rich-formatted instructions, especially when the instructions are long. - Commit messages: - Wrap createUI call - Revert changes to FileChooser

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-11 Thread Magnus Ihse Bursie
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

RFR: 8315990: Amend PL tests to proper category

2023-09-11 Thread Prasanta Sadhukhan
Few awt problem listed tests are placed in swing category which should be amended - Commit messages: - Amend PL tests to proper category Changes: https://git.openjdk.org/jdk/pull/15655/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15655&range=00 Issue: https://bugs.open

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-11 Thread David Holmes
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

Integrated: 8315609: Open source few more swing text/html tests

2023-09-11 Thread Prasanta Sadhukhan
On Thu, 7 Sep 2023 04:22:59 GMT, Prasanta Sadhukhan wrote: > Few closed swing text/html tests are open sourced This pull request has now been integrated. Changeset: a04c6c1a Author:Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/commit/a04c6c1ac663a1eab7d45913940cb6ac0af2c11c S

Re: RFR: 8315609: Open source few more swing text/html tests [v2]

2023-09-11 Thread Prasanta Sadhukhan
> Few closed swing text/html tests are open sourced Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Spacing issue - Changes: - all: https://git.openjdk.org/jdk/pull/15607/files - new: https://git.openjdk.org/jd