On Tue, 10 Oct 2023 06:42:23 GMT, Prasanta Sadhukhan
wrote:
> We call `enableEvents` in `JFileChooser.setup` so I guess we can call
> `disableEvents ` logically..
Ok, will work on it then.
-
PR Comment: https://git.openjdk.org/jdk/pull/16068#issuecomment-1754527503
On Tue, 10 Oct 2023 03:06:04 GMT, Prasanta Sadhukhan
wrote:
> > in the mean time, do you know why the checks are consistently failing for
> > this PR?
>
> No, this failure is in hotspot and it's ok to ignore thisnothing to do
> with the change in this PR ❌ [linux-x64 / test (hs/tier1
> s
On Fri, 6 Oct 2023 05:10:18 GMT, Tejesh R wrote:
> Invoking `setEnabled(false)` on an instance of `JFileChooser` the
> sub-components are unaffected since the sub-components didn't set/unset
> enabled explicitly. The fix address the issue and sets the Enabled flag to
> each sub-components. Alo
On Tue, 10 Oct 2023 06:22:29 GMT, Tejesh R wrote:
> Can't we call `disableEvents ` in JFileChooser.updateUI() if JFileChooser is
> disabled instead of changing in all *UI classes?
Also components disable is handled at UI classes (button, border etc), none of
the places `disableEvents ` is used.
On Tue, 10 Oct 2023 06:02:10 GMT, Prasanta Sadhukhan
wrote:
> Can't we call `disableEvents ` in JFileChooser.updateUI() if JFileChooser is
> disabled instead of changing in all *UI classes?
Not sure, haven't tried it.
-
PR Comment: https://git.openjdk.org/jdk/pull/16068#issuecomm
On Fri, 6 Oct 2023 05:10:18 GMT, Tejesh R wrote:
> Invoking `setEnabled(false)` on an instance of `JFileChooser` the
> sub-components are unaffected since the sub-components didn't set/unset
> enabled explicitly. The fix address the issue and sets the Enabled flag to
> each sub-components. Alo
On Tue, 10 Oct 2023 03:50:11 GMT, Prasanta Sadhukhan
wrote:
>> A JOptionPane message dialog owned by a JFrame which is not always on top
>> can be obscured behind an `"always on top" JFrame`. Since the option pane is
>> modal, one can't move the "always on top frame" to reveal it, so the
>> a
On Mon, 9 Oct 2023 16:46:36 GMT, Alisen Chung wrote:
> Would it be better to check if the JFrame is "always on top" before making
> the JOptionPane also always on top?
No..That's the issue this PR is trying to solve...
If a frame is not "always on top" and is hidden by a frame which is "always
> A JOptionPane message dialog owned by a JFrame which is not always on top can
> be obscured behind an `"always on top" JFrame`. Since the option pane is
> modal, one can't move the "always on top frame" to reveal it, so the
> application effectively hangs as we cannot dismiss the option pane d
> We should set the -permissive- flag for the Microsoft Visual C compiler, as
> was requested by the now backed out
> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
> the Visual C compiler much less accepting of ill formed code, which will
> improve code quality on W
> A JOptionPane message dialog owned by a JFrame which is not always on top can
> be obscured behind an `"always on top" JFrame`. Since the option pane is
> modal, one can't move the "always on top frame" to reveal it, so the
> application effectively hangs as we cannot dismiss the option pane d
On Thu, 28 Sep 2023 03:12:03 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less acceptin
On Mon, 9 Oct 2023 17:31:46 GMT, Andy Goryachev wrote:
> in the mean time, do you know why the checks are consistently failing for
> this PR?
No, this failure is in hotspot and it's ok to ignore thisnothing to do with
the change in this PR
❌ [linux-x64 / test (hs/tier1
serviceability)](ht
On Mon, 9 Oct 2023 23:24:35 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8292276 : Add named colors from CSS Color Module Level
>> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276)
>>
>> This is tracked in JBS as
>> - [JDK-8292276 : Add named c
> This is referenced in Java Bug Database as
> - [JDK-8292276 : Add named colors from CSS Color Module Level
> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276)
>
> This is tracked in JBS as
> - [JDK-8292276 : Add named colors from CSS Color Module Level
> 4](https://bugs.openjdk.ja
> This is referenced in Java Bug Database as
> - [JDK-8292276 : Add named colors from CSS Color Module Level
> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276)
>
> This is tracked in JBS as
> - [JDK-8292276 : Add named colors from CSS Color Module Level
> 4](https://bugs.openjdk.ja
I can't find any Apple docs saying anything like "invoke this only on
the Appkit thread",
perhaps because you don't have to, but nor do I see any caution about
using a consistent thread.
The JDK code to start a thread is
- (void) startDisplayLink {
if (!CVDisplayLinkIsRunning(self.displayLi
On Mon, 9 Oct 2023 03:20:17 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Observations :
>> 1. Without com initialize if we access Mixer for recording, library loaded
>> invalid GUID and clipped description in windows(ID not found in registry).
>> With com initialization libra
On Sun, 8 Oct 2023 22:15:59 GMT, Christoph Langer wrote:
> This test is failing on several Linux configurations (SLES 15), so it should
> be excluded.
Looks good to me.
-
Marked as reviewed by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16096#pullrequestreview
On Mon, 9 Oct 2023 15:01:41 GMT, Jan Kratochvil wrote:
>> `--with-toolchain-type=clang` fails the compilation for me with
>> `clang-16.0.6-3.fc38.x86_64`
>>
>> While the warnings can be disabled I find better to just fix them. The GTK
>> prototypes in JDK reported by clang are either missing o
On Mon, 9 Oct 2023 15:01:41 GMT, Jan Kratochvil wrote:
>> `--with-toolchain-type=clang` fails the compilation for me with
>> `clang-16.0.6-3.fc38.x86_64`
>>
>> While the warnings can be disabled I find better to just fix them. The GTK
>> prototypes in JDK reported by clang are either missing o
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan
wrote:
>> SwingNode does not update its internal cache of Swing pref/max/min height
>> and widths when its JComponent content's corresponding size constraints are
>> updated. As such, it isn't resized to honor those size constraints.
>>
>>
On Thu, 5 Oct 2023 16:43:17 GMT, Prasanta Sadhukhan
wrote:
> A JOptionPane message dialog owned by a JFrame which is not always on top can
> be obscured behind an `"always on top" JFrame`. Since the option pane is
> modal, one can't move the "always on top frame" to reveal it, so the
> applic
On Mon, 9 Oct 2023 05:07:13 GMT, Ravi Gupta wrote:
>> Write a test to check textArea triggers MouseEntered/MouseExited events
>> properly
>>
>> MouseEntered should be triggered only when the mouse enters the component
>> and MouseExited should be triggered when the mouse goes out of the compon
On Mon, 9 Oct 2023 14:38:27 GMT, Daniel Jeliński wrote:
>> Jan Kratochvil has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove declaration changes which are not required
>>- suggested by djelinski
>
> src/java.desktop/unix/native/l
> `--with-toolchain-type=clang` fails the compilation for me with
> `clang-16.0.6-3.fc38.x86_64`
>
> While the warnings can be disabled I find better to just fix them. The GTK
> prototypes in JDK reported by clang are either missing or wrong.
>
>
> src/java.base/unix/native/libnet/DefaultProx
> `--with-toolchain-type=clang` fails the compilation for me with
> `clang-16.0.6-3.fc38.x86_64`
>
> While the warnings can be disabled I find better to just fix them. The GTK
> prototypes in JDK reported by clang are either missing or wrong.
>
>
> src/java.base/unix/native/libnet/DefaultProx
On Thu, 17 Aug 2023 23:13:51 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8292276 : Add named colors from CSS Color Module Level
>> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276)
>>
>> This is tracked in JBS as
>> - [JDK-8292276 : Add named
On Sat, 7 Oct 2023 16:24:29 GMT, Jan Kratochvil wrote:
> `--with-toolchain-type=clang` fails the compilation for me with
> `clang-16.0.6-3.fc38.x86_64`
>
> While the warnings can be disabled I find better to just fix them. The GTK
> prototypes in JDK reported by clang are either missing or wro
On Sun, 13 Aug 2023 18:17:57 GMT, ScientificWare wrote:
> This is referenced in Java Bug Database as
> - [JDK-8294090 : Aligns the CSS `` and `` function
> behaviours](https://bugs.java.com/bugdatabase/view_bug?bug_id=8294090)
>
> This is tracked in JBS as
> - [JDK-8294090 : Aligns the CSS ``
On Sun, 20 Aug 2023 23:07:01 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8294090 : Aligns the CSS `` and `` function
>> behaviours](https://bugs.java.com/bugdatabase/view_bug?bug_id=8294090)
>>
>> This is tracked in JBS as
>> - [JDK-8294090 : Aligns the C
On Mon, 9 Oct 2023 06:25:08 GMT, Tejesh R wrote:
> The fix is working fine with the test mentioned in JBS. Any reason for not
> adding a test for the fix?
I couldn't get ways to do automated test for this and manual test using
PassFailJFrame doesn't support multiple test windows which this tes
32 matches
Mail list logo
