Re: RFR: 8333403: Write a test to check various components events are triggered properly

2024-06-03 Thread lawrence . andrews
On Mon, 3 Jun 2024 12:22:53 GMT, Ravi Gupta wrote: > This testcase checks for the following assertions for Component events: > > 1. When components are resized, moved, hidden and shown the respective events > are triggered. > 2. When the components are hidden/disabled also,the component events

Integrated: 8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled

2024-06-03 Thread Jayathirth D V
On Fri, 24 May 2024 08:37:25 GMT, Jayathirth D V wrote: > In IJG library's jmemmgr.c file we can define MEM_STATS(by default this flag > is disabled and we don't see this issue) to enable printing of memory trace > logs when we have OOM. But if we enable it we get crash while disposing IJG > s

Re: RFR: 8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled [v2]

2024-06-03 Thread Jayathirth D V
> In IJG library's jmemmgr.c file we can define MEM_STATS(by default this flag > is disabled and we don't see this issue) to enable printing of memory trace > logs when we have OOM. But if we enable it we get crash while disposing IJG > stored objects in jmemmgr->free-pool() function. > > This

Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L&F [v5]

2024-06-03 Thread Abhishek Kumar
On Mon, 3 Jun 2024 05:52:31 GMT, Abhishek Kumar wrote: >> bug6492108.java test always fails in GTK L&F in single as well as dual >> screen linux machines. Since this test was not marked as "_headful_" in it's >> initial version, it never failed but after the fix of >> [JDK-8287051](https://bug

Re: RFR: 8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled

2024-06-03 Thread Prasanta Sadhukhan
On Fri, 24 May 2024 08:37:25 GMT, Jayathirth D V wrote: > In IJG library's jmemmgr.c file we can define MEM_STATS(by default this flag > is disabled and we don't see this issue) to enable printing of memory trace > logs when we have OOM. But if we enable it we get crash while disposing IJG > s

Integrated: 8314070: javax.print: Support IPP output-bin attribute extension

2024-06-03 Thread Alexander Scherbatiy
On Thu, 12 Oct 2023 15:39:45 GMT, Alexander Scherbatiy wrote: > The fix adds new public `OutputBin` print attribute class which allow to set > a printer output bin in a `PrinterJob` class. The corresponding internal > `CustomOutputBin` class is added as well. > > - Constants used in `OutputBi

Re: RFR: 8332103: since-checker - Add missing @ since` tags to java.desktop [v2]

2024-06-03 Thread Nizar Benalla
On Mon, 3 Jun 2024 20:02:12 GMT, Sergey Bylokhov wrote: >>> Hmm, the _explicit_ default constructor was added in JDK 16, but it was >>> implicit before then. So I am not 100% sure what the right answer is - the >>> same as the class, or when it was explicitly added. >> >> I believe there was n

Re: RFR: 8332103: since-checker - Add missing `@since` tags to `java.desktop` [v2]

2024-06-03 Thread Nizar Benalla
On Wed, 15 May 2024 03:38:29 GMT, Nizar Benalla wrote: >> If you're currently reviewing this PR, thank you! >> Most fixes here are according to the reports by the since checker tool in >> #18934 and are pretty simple. >> >> To make reviewing easier >> - `BasicSliderUI` has the constructor `publ

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v17]

2024-06-03 Thread Phil Race
On Thu, 30 May 2024 18:45:38 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >> >> - Constants used in `Out

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v17]

2024-06-03 Thread Phil Race
On Mon, 3 Jun 2024 16:16:23 GMT, Alexander Scherbatiy wrote: > @prrace Should I use the integrate command with the `auto` or `delegate` > parameter? Academic now, since I just approved it. - PR Comment: https://git.openjdk.org/jdk/pull/16166#issuecomment-2146273729

Re: RFR: 8332103: since-checker - Add missing `@since` tags to `java.desktop` [v2]

2024-06-03 Thread Sergey Bylokhov
On Wed, 29 May 2024 11:51:34 GMT, Alexey Ivanov wrote: >> When mapping methods and when they first appeared (by using the historical >> record built into javac) I use an id in the form of >> `method: >> .()` so >> for covariant overrides in general, when the return type changes I consider >

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v17]

2024-06-03 Thread Alexander Scherbatiy
On Thu, 30 May 2024 18:53:49 GMT, Alexander Scherbatiy wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add Skip test option to the OutputBinAttributePrintDialogTest with the >> native dialog > > The `Outp

Integrated: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized

2024-06-03 Thread Prasanta Sadhukhan
On Thu, 30 May 2024 12:05:25 GMT, Prasanta Sadhukhan wrote: > Issue is in macosx, when a JMenu or JPopupmenu is opened and then window is > resized from the lower right corner, then the Menu / JPopupmenu stays open > unlike in native osx apps like Notes, Mail etc.. > > This is because when LM

RFR: 8333403: Write a test to check various components events are triggered properly

2024-06-03 Thread Ravi Gupta
This testcase checks for the following assertions for Component events: 1. When components are resized, moved, hidden and shown the respective events are triggered. 2. When the components are hidden/disabled also,the component events like resized/moved are triggered. 3. When a hidden component i

Integrated: 8280990: [XWayland] XTest emulated mouse click does not bring window to front

2024-06-03 Thread Alexander Zvegintsev
On Tue, 28 May 2024 02:25:46 GMT, Alexander Zvegintsev wrote: > Some of the modal tests fail in X11 compatibility mode on Wayland, because a > mouse click emulated with XTEST does not not cause the windows to be > reordered. > > This is a known limitation because these click events do not lea

Re: RFR: 8280990: [XWayland] XTest emulated mouse click does not bring window to front

2024-06-03 Thread Alexander Zuev
On Tue, 28 May 2024 02:25:46 GMT, Alexander Zvegintsev wrote: > Some of the modal tests fail in X11 compatibility mode on Wayland, because a > mouse click emulated with XTEST does not not cause the windows to be > reordered. > > This is a known limitation because these click events do not lea