Re: RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v39]

2025-09-05 Thread Khalid Boulanouare
> Many Mixing tests failed because the work around click lands on the > minimizing area in the window control and causes the tests to fail. > > This fix changes the width of base frames which allows most of tests to pass. Khalid Boulanouare has updated the pull request incrementally with two ad

Re: RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v39]

2025-09-05 Thread Alexey Ivanov
On Thu, 4 Sep 2025 22:02:14 GMT, Khalid Boulanouare wrote: >> Many Mixing tests failed because the work around click lands on the >> minimizing area in the window control and causes the tests to fail. >> >> This fix changes the width of base frames which allows most of tests to pass. > > Khalid

Re: RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v37]

2025-09-05 Thread Khalid Boulanouare
On Thu, 4 Sep 2025 14:26:52 GMT, Alexey Ivanov wrote: >> Khalid Boulanouare has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Organizes imports > > test/jdk/java/awt/Mixing/AWT_Mixing/MixingPanelsResizing.java line 315: > >> 313:

Re: RFR: 8361381: GlyphLayout behavior differs on JDK 11+ compared to JDK 8 [v4]

2025-09-05 Thread Phil Race
On Tue, 26 Aug 2025 17:32:36 GMT, Volker Simonis wrote: >> ### TL;DR >> >> This is a fix for what I think is a regression since the introduction of >> HarfBuzz in JDK 9. The problem is that the algorithm which converts the >> glyph vector produced by the layout engine into a corresponding char

Re: RFR: 8366149: JNI exception pending in Java_sun_awt_X11GraphicsDevice_pGetBounds of awt_GraphicsEnv.c:1484

2025-09-05 Thread Damon Nguyen
On Fri, 5 Sep 2025 04:35:07 GMT, Phil Race wrote: >> In the scenario where AWT's UNLOCK API encounters a pendingException, the >> env pointer throws the pendingException (as seen in `awt.h`). However, in >> `Java_sun_awt_X11GraphicsDevice_pGetBounds`, after `AWT_UNLOCK`, the bounds >> var is s

Integrated: 8366750: Remove test 'java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java' from problemlist

2025-09-05 Thread Sarvesh Kumar Jain
On Thu, 4 Sep 2025 06:43:09 GMT, Sarvesh Kumar Jain wrote: > The test is problem listed with incorrect bug JDK-6849371, > The bug JDK-6849371 is for a different test and it is closed. > A new bug has been raised for ChoiceMouseWheelTest.java test failure. This pull request has now been integrate

Re: RFR: 8366750: Remove test 'java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java' from problemlist [v2]

2025-09-05 Thread Sergey Bylokhov
On Fri, 5 Sep 2025 05:31:31 GMT, Sarvesh Kumar Jain wrote: >> The test is problem listed with incorrect bug JDK-6849371, >> The bug JDK-6849371 is for a different test and it is closed. >> A new bug has been raised for ChoiceMouseWheelTest.java test failure. > > Sarvesh Kumar Jain has updated the

Integrated: 8347277: java/awt/Focus/ComponentLostFocusTest.java fails intermittently

2025-09-05 Thread Manukumar V S
On Tue, 2 Sep 2025 07:16:20 GMT, Manukumar V S wrote: > Issue: > java/awt/Focus/ComponentLostFocusTest.java fails intermittently(2/40) with an > exception " Execution failed: `main' threw exception: > java.lang.RuntimeException: TextField got no focus! Test failed." > I have seen it failing in

Re: RFR: 8150564: Migrate useful ExtendedRobot methods into awt.Robot [v4]

2025-09-05 Thread Chen Liang
On Fri, 5 Sep 2025 17:15:47 GMT, Phil Race wrote: >> src/java.desktop/share/classes/java/awt/Robot.java line 977: >> >>> 975: public synchronized void type(int keycode) { >>> 976: keyPress(keycode); >>> 977: waitForIdle(20); >> >> Should this use `DEFAULT_STEP_DELAY` too? >

Re: RFR: 8366844: Update and automate MouseDraggedOriginatedByScrollBarTest.java [v6]

2025-09-05 Thread Damon Nguyen
> When testing jtreg manual tests, some tests were out of date. This PR is an > attempt at updating the test and automating it. > > `MouseDraggedOriginatedByScrollBarTest.java` works as expected when compared > to native apps and outputs drag events even when the mouse pointer is dragged > off

Re: RFR: 8366844: Update and automate MouseDraggedOriginatedByScrollBarTest.java [v4]

2025-09-05 Thread Damon Nguyen
On Thu, 4 Sep 2025 08:20:05 GMT, Alexey Ivanov wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comment edits > > test/jdk/java/awt/List/MouseDraggedOriginatedByScrollBarTest.java line 131: > >> 129:

Re: RFR: 8366844: Update and automate MouseDraggedOriginatedByScrollBarTest.java [v4]

2025-09-05 Thread Damon Nguyen
On Thu, 4 Sep 2025 08:09:54 GMT, Alexey Ivanov wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comment edits > > test/jdk/java/awt/List/MouseDraggedOriginatedByScrollBarTest.java line 85: > >> 83:

Re: RFR: 8366844: Update and automate MouseDraggedOriginatedByScrollBarTest.java [v5]

2025-09-05 Thread Damon Nguyen
> When testing jtreg manual tests, some tests were out of date. This PR is an > attempt at updating the test and automating it. > > `MouseDraggedOriginatedByScrollBarTest.java` works as expected when compared > to native apps and outputs drag events even when the mouse pointer is dragged > off

Re: RFR: 8150564: Migrate useful ExtendedRobot methods into awt.Robot [v4]

2025-09-05 Thread Phil Race
On Thu, 4 Sep 2025 00:13:15 GMT, Chen Liang wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add finally block > > src/java.desktop/share/classes/java/awt/Robot.java line 977: > >> 975: public synchronized void

Re: RFR: 8347277: java/awt/Focus/ComponentLostFocusTest.java fails intermittently [v5]

2025-09-05 Thread Sergey Bylokhov
On Thu, 4 Sep 2025 03:40:25 GMT, Manukumar V S wrote: >> Issue: >> java/awt/Focus/ComponentLostFocusTest.java fails intermittently(2/40) with >> an exception " Execution failed: `main' threw exception: >> java.lang.RuntimeException: TextField got no focus! Test failed." >> I have seen it failin

Integrated: 8365569: Remove finalize from JavaSoundAudioClip.java

2025-09-05 Thread Phil Race
On Thu, 14 Aug 2025 17:27:09 GMT, Phil Race wrote: > This refactors com/sun/media/sound/JavaSoundAudioClip.java so that most of > the implementation is in a delegate > com/sun/media/sound/JavaSoundAudioClipDelegate.java > > Then a disposer can be used to free the audio resources held by the del

Re: RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v38]

2025-09-05 Thread Alexey Ivanov
On Thu, 4 Sep 2025 21:47:19 GMT, Khalid Boulanouare wrote: >> test/jdk/java/awt/Mixing/AWT_Mixing/SimpleOverlappingTestBase.java line 70: >> >>> 68: } >>> 69: >>> 70: protected boolean isMultiFramesTest(){ >> >> Suggestion: >> >> @Override >> protected boolean isMultiFramesTes

Re: Possible BufferedImage.getRGB optimization

2025-09-05 Thread Daniel Gredler
OK, thanks -- I'll add a `colorModel.getColorSpace().isCS_sRGB()` check here as well. Take care, Daniel On Thu, Sep 4, 2025 at 11:55 PM Philip Race wrote: > It doesn't seem like a change that needs a project. > I would make sure that call to colorModel.getRGB(..) isn't needed and I > think t

Re: RFR: 8339791: Refactor MiscUndecorated/ActiveAWTWindowTest.java [v3]

2025-09-05 Thread Srinivas Mandalika
On Thu, 4 Sep 2025 16:30:40 GMT, lawrence.andrews wrote: >> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review Feedback: Removed redundant RTEs > > test/jdk/java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java l

Re: RFR: 8366750: Remove test 'java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java' from problemlist

2025-09-05 Thread Prasanta Sadhukhan
On Thu, 4 Sep 2025 06:43:09 GMT, Sarvesh Kumar Jain wrote: > The test is problem listed with incorrect bug JDK-6849371, > The bug JDK-6849371 is for a different test and it is closed. > A new bug has been raised for ChoiceMouseWheelTest.java test failure. That new bugid 8366852 needs to be added