RFR: 8365379: SU3.applyInsets may produce wrong results

2025-09-08 Thread Renjith Kannath Pariyangad
Hi Reviewers, I have updated the insets calculation, similar calculation observed in **SynthGraphicsUtils.java**. Reused the **SwingUtilities3.java** modified code Please review and let me know your suggestions if any. - Commit messages: - 8365379: SU3.applyInsets may produce wron

RFR: 8023263: [TESTBUG] Test closed/java/awt/Focus/InactiveWindowTest/InactiveFocusRace fails due to not enough time to initialize graphic components

2025-09-08 Thread Prasanta Sadhukhan
Test was failing due to lack of time between initializing graphics components and test start. Added robot delay and execution under EDT. Several iterations of test is passing so deproblemlisting, CI job link in JBS - Commit messages: - 8023263: [TESTBUG] Test closed/java/awt/Focus

Re: RFR: 8256289: java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java failed with "RuntimeException: Wrong focus owner: java.awt.Button[button1,41,36,56x23,label=Button1]" [v2]

2025-09-08 Thread Prasanta Sadhukhan
On Mon, 8 Sep 2025 18:01:49 GMT, Phil Race wrote: > > Do we consider renaming the test in this or a separate PR since Applets > > usage is removed? > > Actually there are 2 Applet based tests in > > java/awt/Focus/AppletInitialFocusTest folder. These tests can be deleted if > > they are decide

Re: RFR: 8256289: java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java failed with "RuntimeException: Wrong focus owner: java.awt.Button[button1,41,36,56x23,label=Button1]" [v2]

2025-09-08 Thread Prasanta Sadhukhan
> Test used to fail earlier with above message. > Execution of the test didn't cause any failure in recent run of this test for > several iterations as seen in job listed in JBS so deproblemlisting Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the

Re: RFR: 8150564: Migrate useful ExtendedRobot methods into awt.Robot [v5]

2025-09-08 Thread Damon Nguyen
> Some useful methods (click, glide, waitForIdle, type) in ExtendedRobot should > be migrated into Robot itself so that ExtendedRobot can be removed in the > future. The tests using these ExtendedRobot methods will be handled > separately. Damon Nguyen has updated the pull request incrementally

Re: RFR: 8150564: Migrate useful ExtendedRobot methods into awt.Robot [v6]

2025-09-08 Thread Damon Nguyen
> Some useful methods (click, glide, waitForIdle, type) in ExtendedRobot should > be migrated into Robot itself so that ExtendedRobot can be removed in the > future. The tests using these ExtendedRobot methods will be handled > separately. Damon Nguyen has updated the pull request incrementally

Re: RFR: 8150564: Migrate useful ExtendedRobot methods into awt.Robot [v4]

2025-09-08 Thread Damon Nguyen
On Fri, 5 Sep 2025 18:52:58 GMT, Chen Liang wrote: >> In the code this is based on (ExtendedRobot.java) it was called >> DEFAULT_SPEED and used by click and type as well as glide >> As 'named' now, DEFAULT_STEP_DELAY is only appropriate for glide(..). >> There's no "stepping" here. >> >> And y

Re: RFR: 8321289: open/test/jdk/javax/swing/JFrame/MaximizeWindowTest.java fails on Linux

2025-09-08 Thread lawrence . andrews
On Mon, 8 Sep 2025 16:30:48 GMT, Alexander Zvegintsev wrote: > This changeset excludes the test from running on Linux. We receive a > ConfigureNotify from the system (Gnome Shell) with the initial window size. > However, this does not happen on Plasma. LGTM - PR Comment: https:/

Re: RFR: 8251928: [macos] the printer DPI always be 72, cause some content lost when print out [v6]

2025-09-08 Thread GennadiyKrivoshein
> The fix for the https://bugs.openjdk.org/browse/JDK-8251928. > > **Description**. > This PR contains changes to be able to print with DPI higher than 72 on > macOS, set default CPrinterJob DPI is 300 like in the PSPrinterJob. > > As described in the macOS drawing guide, the following steps are

Re: RFR: 8256289: java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java failed with "RuntimeException: Wrong focus owner: java.awt.Button[button1,41,36,56x23,label=Button1]"

2025-09-08 Thread Phil Race
On Mon, 8 Sep 2025 17:51:45 GMT, Harshitha Onkar wrote: > Do we consider renaming the test in this or a separate PR since Applets usage > is removed? > > Actually there are 2 Applet based tests in > java/awt/Focus/AppletInitialFocusTest folder. These tests can be deleted if > they are decided

Re: RFR: 8256289: java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java failed with "RuntimeException: Wrong focus owner: java.awt.Button[button1,41,36,56x23,label=Button1]"

2025-09-08 Thread Harshitha Onkar
On Mon, 8 Sep 2025 08:46:59 GMT, Prasanta Sadhukhan wrote: > Test used to fail earlier with above message. > Execution of the test didn't cause any failure in recent run of this test for > several iterations as seen in job listed in JBS so deproblemlisting Do we consider renaming the test in t

Re: RFR: 8321289: open/test/jdk/javax/swing/JFrame/MaximizeWindowTest.java fails on Linux

2025-09-08 Thread Sergey Bylokhov
On Mon, 8 Sep 2025 16:30:48 GMT, Alexander Zvegintsev wrote: > This changeset excludes the test from running on Linux. We receive a > ConfigureNotify from the system (Gnome Shell) with the initial window size. > However, this does not happen on Plasma. If the initial size is correct now, why

Re: RFR: 8256289: java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java failed with "RuntimeException: Wrong focus owner: java.awt.Button[button1,41,36,56x23,label=Button1]"

2025-09-08 Thread Sergey Bylokhov
On Mon, 8 Sep 2025 08:46:59 GMT, Prasanta Sadhukhan wrote: > Test used to fail earlier with above message. > Execution of the test didn't cause any failure in recent run of this test for > several iterations as seen in job listed in JBS so deproblemlisting Marked as reviewed by serb (Reviewer)

RFR: 8321289: open/test/jdk/javax/swing/JFrame/MaximizeWindowTest.java fails on Linux

2025-09-08 Thread Alexander Zvegintsev
This changeset excludes the test from running on Linux. We receive a ConfigureNotify from the system (Gnome Shell) with the initial window size. However, this does not happen on Plasma. - Commit messages: - 8321289: open/test/jdk/javax/swing/JFrame/MaximizeWindowTest.java fails on

Re: RFR: 8342869: Errors related to unused code on Windows after 8339120 in awt [v2]

2025-09-08 Thread Julian Waters
On Mon, 8 Sep 2025 14:25:02 GMT, Julian Waters wrote: >> After 8339120, gcc began catching many different instances of unused code in >> the Windows specific codebase. Some of these seem to be bugs. I've taken the >> effort to mark out all the relevant globals and locals that trigger the >> un

Re: RFR: 8342870: Errors related to unused code on Windows after 8339120 in accessibility [v5]

2025-09-08 Thread Julian Waters
On Tue, 28 Jan 2025 17:38:29 GMT, Alexey Ivanov wrote: >> I see no reason to keep it. >> >> If it's needed during debugging, there are many ways to find the handle. >> >> Otherwise, the edit control is accessed by its id: `cAccessInfoText`. > > It looks like this feature doesn't work: > [JDK-8

Re: RFR: 8342870: Errors related to unused code on Windows after 8339120 in accessibility [v5]

2025-09-08 Thread Julian Waters
On Tue, 28 Jan 2025 17:33:42 GMT, Alexey Ivanov wrote: >> I'll submit a new bug to address this problem. >> >> It's not just a matter of an unused variables, it's the logic error: if the >> buffer is too small, *a new buffer is allocated*, yet this new buffer isn't >> deleted afterwards, nor i

Re: RFR: 8342870: Errors related to unused code on Windows after 8339120 in accessibility [v6]

2025-09-08 Thread Julian Waters
On Thu, 23 Jan 2025 05:37:29 GMT, Julian Waters wrote: >> After 8339120, gcc began catching many different instances of unused code in >> the Windows specific codebase. Some of these seem to be bugs. I've taken the >> effort to mark out all the relevant globals and locals that trigger the >> u

Re: RFR: 8342870: Errors related to unused code on Windows after 8339120 in accessibility [v7]

2025-09-08 Thread Julian Waters
> After 8339120, gcc began catching many different instances of unused code in > the Windows specific codebase. Some of these seem to be bugs. I've taken the > effort to mark out all the relevant globals and locals that trigger the > unused warnings and addressed all of them by commenting out th

Integrated: 8361381: GlyphLayout behavior differs on JDK 11+ compared to JDK 8

2025-09-08 Thread Volker Simonis
On Mon, 18 Aug 2025 16:05:24 GMT, Volker Simonis wrote: > ### TL;DR > > This is a fix for what I think is a regression since the introduction of > HarfBuzz in JDK 9. The problem is that the algorithm which converts the glyph > vector produced by the layout engine into a corresponding character

Re: RFR: 8366844: Update and automate MouseDraggedOriginatedByScrollBarTest.java [v6]

2025-09-08 Thread Alexey Ivanov
On Fri, 5 Sep 2025 18:45:59 GMT, Damon Nguyen wrote: >> When testing jtreg manual tests, some tests were out of date. This PR is an >> attempt at updating the test and automating it. >> >> `MouseDraggedOriginatedByScrollBarTest.java` works as expected when compared >> to native apps and outpu

RFR: 8068378: [TEST_BUG]The java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java instruction need to update

2025-09-08 Thread Srinivas Mandalika
Test Name: java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java Updated the test instructions for better clarity, formatting and removed its entry from the ProblemList.txt. - Commit messages: - 8068378: [TEST_BUG]The java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java instructio

RFR: 8256289: java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java failed with "RuntimeException: Wrong focus owner: java.awt.Button[button1,41,36,56x23,label=Button1]"

2025-09-08 Thread Prasanta Sadhukhan
Test used to fail earlier with above message. Execution of the test didn't cause any failure in recent run of this test for several iterations as seen in job listed in JBS so deproblemlisting - Commit messages: - 8256289: java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1

Re: RFR: 8339791: Refactor MiscUndecorated/ActiveAWTWindowTest.java [v5]

2025-09-08 Thread Srinivas Mandalika
> The java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java test uses object > monitors and wait/notify to synchronise actions in the test. > > Using CountDownLatch could make the test simpler, shorter, clearer. > Tested the code on a windows-x64, macos-x64 and lnux-x64 machines and the > test