On Thu, 28 Aug 2025 14:24:19 GMT, SendaoYan wrote:
> Hi all,
>
> I think test javax/print/PrintServiceLookup/CountPrintServices.java should
> throw jtreg.SkippedException when there is no lpstat, rather that report test
> failure.
>
> Only javax/pri
On Fri, 29 Aug 2025 16:43:37 GMT, Phil Race wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove redundant initial
>
> Marked as reviewed by prr (Reviewer).
Thanks for your patien
ly.
>
> Change has been verified locally, test-fix only, no risk.
SendaoYan has updated the pull request incrementally with one additional commit
since the last revision:
Remove redundant initial
-
Changes:
- all: https://git.openjdk.org/jdk/pull/26988/files
- new: ht
On Fri, 29 Aug 2025 12:51:43 GMT, Alexey Ivanov wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 1. add import java.io.IOException; 2. Re-throw the IOException if do not
>> throw Skip
On Fri, 29 Aug 2025 09:27:38 GMT, Alexey Ivanov wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary whitespace
>
> test/jdk/javax/print/PrintServiceLookup/CountPrintS
On Fri, 29 Aug 2025 09:25:41 GMT, Alexey Ivanov wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary whitespace
>
> test/jdk/javax/print/PrintServiceLookup/CountPrintS
ly.
>
> Change has been verified locally, test-fix only, no risk.
SendaoYan has updated the pull request incrementally with one additional commit
since the last revision:
1. add import java.io.IOException; 2. Re-throw the IOException if do not
throw SkippeException
ly.
>
> Change has been verified locally, test-fix only, no risk.
SendaoYan has updated the pull request incrementally with one additional commit
since the last revision:
Remove unnecessary whitespace
-
Changes:
- all: https://git.openjdk.org/jdk/pull/26988/files
- ne
On Fri, 29 Aug 2025 08:41:11 GMT, Alexey Ivanov wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use "@requires (os.family == "linux")" instead of check OS type in code
On Fri, 29 Aug 2025 02:48:35 GMT, SendaoYan wrote:
>> Hi all,
>>
>> I think test javax/print/PrintServiceLookup/CountPrintServices.java should
>> throw jtreg.SkippedException when there is no lpstat, rather that report
>> test failure.
>>
&g
ly.
>
> Change has been verified locally, test-fix only, no risk.
SendaoYan has updated the pull request incrementally with one additional commit
since the last revision:
Use "@requires (os.family == "linux")" instead of check OS type in code
-
Change
On Thu, 28 Aug 2025 22:23:31 GMT, Phil Race wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use "@requires (os.family == "linux")" instead of check OS type in code
Hi all,
I think test javax/print/PrintServiceLookup/CountPrintServices.java should
throw jtreg.SkippedException when there is no lpstat, rather that report test
failure.
Only javax/print/PrintServiceLookup/CountPrintServices.java invoke lpstat
explicitly.
Change has been verified locally, tes
On Thu, 21 Aug 2025 09:10:26 GMT, Leo Korinth wrote:
>> Yes, this PR change the default timeoutFactor when the tested JVM options do
>> not contains '-Xcomp', and at the same time also multiplies 4 of the timeout
>> value defined in some tests.
>>
>> So after this PR, the tests which the timeo
4, after this PR the new
>> default is 120 * 1
>
> @sendaoYan this PR changes the default timeoutFactor and so also has to
> change quite a number of implicit and explicit timeouts. But that doesn't
> mean that test configs that already set their own timeoutFactor should adjust
&
t timeout = 120
> * 10 = 1200 but new default = 120 * 2.5 = 300!).
>
> However I see the concern of @sendaoYan because individual tests may now get
> much larger timeout values when run with the non-default timeoutFactor
> because they have been adjusted for the new default. I don
On Mon, 18 Aug 2025 09:15:29 GMT, Leo Korinth wrote:
>> It is unclear to me if the author meant this to be `2.5` more than normal or
>> `10` more than JTREG default, or a `multiplier that seems to work`. It does
>> not bother me _more_ if it is a `10` then a `2.5`, as it needs to have a
>> val
On Fri, 15 Aug 2025 11:43:33 GMT, Leo Korinth wrote:
>> This changes the timeout factor from 4 to 1. Most of the changes add
>> timeouts to individual test cases so that I am able to run them with a
>> timeout factor of 0.7 (some margin to the checked in factor of one)
>>
>> In addition to cha
On Tue, 12 Aug 2025 17:01:41 GMT, Leo Korinth wrote:
> This changes the timeout factor from 4 to 1. Most of the changes add timeouts
> to individual test cases so that I am able to run them with a timeout factor
> of 0.7 (some margin to the checked in factor of one)
>
> In addition to changing
On Tue, 12 Aug 2025 17:01:41 GMT, Leo Korinth wrote:
> This changes the timeout factor from 4 to 1. Most of the changes add timeouts
> to individual test cases so that I am able to run them with a timeout factor
> of 0.7 (some margin to the checked in factor of one)
>
> In addition to changing
On Tue, 24 Jun 2025 02:29:49 GMT, SendaoYan wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [bcad87ea](https://github.com/openjdk/jdk/commit/bcad87eacbd7fbfd3254479b7e061bab34e64aec)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
On Tue, 24 Jun 2025 02:29:49 GMT, SendaoYan wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [bcad87ea](https://github.com/openjdk/jdk/commit/bcad87eacbd7fbfd3254479b7e061bab34e64aec)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
On Tue, 24 Jun 2025 02:29:49 GMT, SendaoYan wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [bcad87ea](https://github.com/openjdk/jdk/commit/bcad87eacbd7fbfd3254479b7e061bab34e64aec)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
On Mon, 21 Jul 2025 08:48:41 GMT, Manukumar V S wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [bcad87ea](https://github.com/openjdk/jdk/commit/bcad87eacbd7fbfd3254479b7e061bab34e64aec)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit be
On Tue, 15 Jul 2025 05:40:17 GMT, Abhishek Kumar wrote:
> Test is failing on intermittently on macOS and ubuntu machine in CI testing.
> Test stabilization done by requesting focus for the frame before starting the
> testing.
>
> Ran the test before and after the fix and there is no failure af
Hi all,
This pull request contains a backport of commit
[bcad87ea](https://github.com/openjdk/jdk/commit/bcad87eacbd7fbfd3254479b7e061bab34e64aec)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Manukumar V S on 24 Jun 2025 and
was re
On Thu, 19 Jun 2025 11:11:32 GMT, Manukumar V S wrote:
>> Issue:
>> MyanmarTextTest.java produces a false positive result when some of the test
>> preconditions are not met. It checks whether certain fonts are present in
>> the system, for example, 'Padauk' on Linux. If the required font is mis
On Wed, 14 May 2025 21:28:37 GMT, Harshitha Onkar wrote:
>> The following line results in unused-result warning on linux/clang.
>>
>>
>> /java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c:695:9: error: ignoring
>> return value of function
>> declared with 'warn_unused_result' attribute [-W
On Wed, 14 May 2025 21:28:37 GMT, Harshitha Onkar wrote:
>> The following line results in unused-result warning on linux/clang.
>>
>>
>> /java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c:695:9: error: ignoring
>> return value of function
>> declared with 'warn_unused_result' attribute [-W
On Fri, 18 Apr 2025 13:10:10 GMT, Khalid Boulanouare wrote:
> Fixes issue in which the test fails when run on multi-screen machine.
>
> Tested on Ubuntu 24.04, MacOS 15 and Windows 11
>
> JTREG
>
> runner starting test: java/awt/Frame/MultiScreenTest.java
> runner finished test: java/awt/Frame
On Tue, 17 Dec 2024 15:27:30 GMT, Phil Race wrote:
>> Sorry for the confuse. I mean this PR change nothing except it will print a
>> message to stderr when realpath return NULL. Thanks magicus.
>
> Why did you integrate this ?
> It did not yet have my approval even though I was clearly reviewing
On Thu, 12 Dec 2024 04:32:14 GMT, SendaoYan wrote:
> Hi all,
> This PR fix file src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c
> reported compile warning "ignoring return value of function" by clang17,
> which add check the return value of `realpath` functi
On Thu, 12 Dec 2024 04:32:14 GMT, SendaoYan wrote:
> Hi all,
> This PR fix file src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c
> reported compile warning "ignoring return value of function" by clang17,
> which add check the return value of `realpath` function
On Fri, 13 Dec 2024 08:10:10 GMT, Magnus Ihse Bursie wrote:
>>> `perror` will print the given message accrording the previous `errno` info
>>> to stderr, so this change will not change the original behaviour.
>>
>> What do you mean? The original behavior would not write anything to stderr
>> u
On Thu, 12 Dec 2024 04:32:14 GMT, SendaoYan wrote:
> Hi all,
> This PR fix file src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c
> reported compile warning "ignoring return value of function" by clang17,
> which add check the return value of `realpath` function.
On Fri, 13 Dec 2024 03:38:15 GMT, SendaoYan wrote:
>> Hi @prrace,
>>> I saw this in another bug report too from the same submitter.
>>
>> I did create 3 clang17 compile waring issues, the compile warings occur in
>> different files, and maybe use should
On Thu, 12 Dec 2024 19:57:13 GMT, Phil Race wrote:
> Try running the jdk_desktop group instead.
Thanks your advice. Mine meaning was verify this change will not cause new
failures, since it will not change behaviour in theory.
I will run jdk_desktop group now.
-
PR Comment: https
On Fri, 13 Dec 2024 03:34:32 GMT, SendaoYan wrote:
>> I saw this in another bug report too from the same submitter.
>> I don't know that I want to encourage this as a pattern, except in debug
>> builds. better might be to just copy dlinfo.dli_fname into buf ..
>
>
On Thu, 12 Dec 2024 19:53:12 GMT, Phil Race wrote:
>> src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c line 141:
>>
>>> 139: dladdr((void *)AWT_OnLoad, &dlinfo);
>>> 140: if (realpath((char *)dlinfo.dli_fname, buf) == NULL) {
>>> 141: perror((char *)dlinfo.dl
On Thu, 12 Dec 2024 19:53:12 GMT, Phil Race wrote:
>> src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c line 141:
>>
>>> 139: dladdr((void *)AWT_OnLoad, &dlinfo);
>>> 140: if (realpath((char *)dlinfo.dli_fname, buf) == NULL) {
>>> 141: perror((char *)dlinfo.dl
Hi all,
This PR fix file src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c
reported compile warning "ignoring return value of function" by clang17, which
add check the return value of `realpath` function. Risk is low.
Additional testing:
- [ ] jtreg tests(include tier1/2/3) on linux-x6
On Tue, 5 Nov 2024 01:41:00 GMT, SendaoYan wrote:
> Hi all,
> The copyright year of some files which has been changed by
> [JDK-8341692](https://bugs.openjdk.org/browse/JDK-8341692) wasn't update
> correctly. This PR update the copyright year of
> [JDK-8341692](http
Hi all,
The copyright year of some files which has been changed by
[JDK-8341692](https://bugs.openjdk.org/browse/JDK-8341692) wasn't update
correctly. This PR update the copyright year of
[JDK-8341692](https://bugs.openjdk.org/browse/JDK-8341692). Trivial fix, no
risk.
-
Commit m
43 matches
Mail list logo
