On Mon, 21 Jul 2025 16:52:54 GMT, Phil Race wrote:
>> Remove finalize method from CStrike.java
>>
>> This one is a bit odd in that there's already a Disposer used - and in fact
>> it involves two classes
>> CStrikeDisposer.java and its subclass - the nested class
>> CStrike.GlyphInfoCache
>> C
On Mon, 21 Jul 2025 16:52:54 GMT, Phil Race wrote:
>> Remove finalize method from CStrike.java
>>
>> This one is a bit odd in that there's already a Disposer used - and in fact
>> it involves two classes
>> CStrikeDisposer.java and its subclass - the nested class
>> CStrike.GlyphInfoCache
>> C
On Mon, 21 Jul 2025 16:52:54 GMT, Phil Race wrote:
>> Remove finalize method from CStrike.java
>>
>> This one is a bit odd in that there's already a Disposer used - and in fact
>> it involves two classes
>> CStrikeDisposer.java and its subclass - the nested class
>> CStrike.GlyphInfoCache
>> C
On Fri, 1 Aug 2025 03:18:16 GMT, Prasanta Sadhukhan
wrote:
>> And if it is 0, what would you do ?
>> Previously 0 meant it hadn't yet been initialized. Now it is always
>> initialized.
>>
>> You'd need to return it anyway even it was zero.
>
> Then I guess whoever is using the `nativeStrikePtr
On Thu, 31 Jul 2025 04:12:07 GMT, Prasanta Sadhukhan
wrote:
> Guess wildcard import and copyright year fix can be done..
I'm not going looking for clean up here.
-
PR Comment: https://git.openjdk.org/jdk/pull/26397#issuecomment-3145861648
On Thu, 31 Jul 2025 19:47:29 GMT, Phil Race wrote:
>> src/java.desktop/macosx/classes/sun/font/CStrike.java line 99:
>>
>>> 97:
>>> 98: public long getNativeStrikePtr() {
>>> 99: return nativeStrikePtr;
>>
>> Any reason this check was removed?
>> I see that initNativeStrikePtr will
On Thu, 31 Jul 2025 04:10:37 GMT, Prasanta Sadhukhan
wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8210765
>
> src/java.desktop/macosx/classes/sun/font/CStrike.java line 99:
>
>> 97:
>> 98: public long getNat
On Mon, 21 Jul 2025 16:52:54 GMT, Phil Race wrote:
>> Remove finalize method from CStrike.java
>>
>> This one is a bit odd in that there's already a Disposer used - and in fact
>> it involves two classes
>> CStrikeDisposer.java and its subclass - the nested class
>> CStrike.GlyphInfoCache
>> C
On Fri, 18 Jul 2025 20:51:04 GMT, Phil Race wrote:
> Remove finalize method from CStrike.java
>
> This one is a bit odd in that there's already a Disposer used - and in fact
> it involves two classes
> CStrikeDisposer.java and its subclass - the nested class
> CStrike.GlyphInfoCache
> CStrike.
> Remove finalize method from CStrike.java
>
> This one is a bit odd in that there's already a Disposer used - and in fact
> it involves two classes
> CStrikeDisposer.java and its subclass - the nested class
> CStrike.GlyphInfoCache
> CStrike.GlyphInfoCache is tracking all the glyph image refere
Remove finalize method from CStrike.java
This one is a bit odd in that there's already a Disposer used - and in fact it
involves two classes
CStrikeDisposer.java and its subclass - the nested class CStrike.GlyphInfoCache
CStrike.GlyphInfoCache is tracking all the glyph image references.
CStrikeD
11 matches
Mail list logo
