Re: RFR: 8348308: Make fields of ListSelectionEvent final

2025-01-22 Thread Alexander Zvegintsev
On Wed, 22 Jan 2025 20:20:28 GMT, Alexey Ivanov wrote: > The fields of `ListSelectionEvent` are set in the constructor and are never > modified, mark the fields — `firstIndex`, `lastIndex`, `isAdjusting` — with > the `final` modifier. Marked as reviewed by azvegint (Reviewer). -

Re: RFR: 8348308: Make fields of ListSelectionEvent final

2025-01-22 Thread Harshitha Onkar
On Wed, 22 Jan 2025 20:20:28 GMT, Alexey Ivanov wrote: > The fields of `ListSelectionEvent` are set in the constructor and are never > modified, mark the fields — `firstIndex`, `lastIndex`, `isAdjusting` — with > the `final` modifier. Marked as reviewed by honkar (Reviewer). - PR

Re: RFR: 8348308: Make fields of ListSelectionEvent final

2025-01-22 Thread Alexey Ivanov
On Wed, 22 Jan 2025 20:39:50 GMT, Abdelhak Zaaim wrote: > Please update it to 2025 to reflect the changes. File header will be updated by #23240. - PR Comment: https://git.openjdk.org/jdk/pull/23243#issuecomment-2608222128

Re: RFR: 8348308: Make fields of ListSelectionEvent final

2025-01-22 Thread Abdelhak Zaaim
On Wed, 22 Jan 2025 20:20:28 GMT, Alexey Ivanov wrote: > The fields of `ListSelectionEvent` are set in the constructor and are never > modified, mark the fields — `firstIndex`, `lastIndex`, `isAdjusting` — with > the `final` modifier. Thank you for making the fields final, improving immutabili

RFR: 8348308: Make fields of ListSelectionEvent final

2025-01-22 Thread Alexey Ivanov
The fields of `ListSelectionEvent` are set in the constructor and are never modified, mark the fields — `firstIndex`, `lastIndex`, `isAdjusting` — with the `final` modifier. - Commit messages: - 8348308: Make fields of ListSelectionEvent final Changes: https://git.openjdk.org/jdk/