Re: RFR: 8352638: Enhance code consistency: java.desktop/windows [v2]

2025-04-21 Thread Sergey Bylokhov
> The `java.desktop` module currently lacks proper use of the `@Override` > annotation for methods and the `final` modifier for classes. While similar > changes were previously made in the > [JavaSound](https://github.com/openjdk/jdk/commit/e0c7d59246cf36644d494eced76e4b9d96ff1ded#diff-ae3e5f9c4

Re: RFR: 8352638: Enhance code consistency: java.desktop/windows

2025-04-17 Thread Phil Race
On Sat, 22 Mar 2025 00:49:25 GMT, Sergey Bylokhov wrote: > The `java.desktop` module currently lacks proper use of the `@Override` > annotation for methods and the `final` modifier for classes. While similar > changes were previously made in the > [JavaSound](https://github.com/openjdk/jdk/com

Re: RFR: 8352638: Enhance code consistency: java.desktop/windows

2025-04-17 Thread Phil Race
On Sat, 22 Mar 2025 00:49:25 GMT, Sergey Bylokhov wrote: > The `java.desktop` module currently lacks proper use of the `@Override` > annotation for methods and the `final` modifier for classes. While similar > changes were previously made in the > [JavaSound](https://github.com/openjdk/jdk/com

Re: RFR: 8352638: Enhance code consistency: java.desktop/windows

2025-04-06 Thread Sergey Bylokhov
On Sat, 5 Apr 2025 19:36:33 GMT, Andrey Turbanov wrote: >> The `java.desktop` module currently lacks proper use of the `@Override` >> annotation for methods and the `final` modifier for classes. While similar >> changes were previously made in the >> [JavaSound](https://github.com/openjdk/jdk/

Re: RFR: 8352638: Enhance code consistency: java.desktop/windows

2025-04-05 Thread Andrey Turbanov
On Sat, 22 Mar 2025 00:49:25 GMT, Sergey Bylokhov wrote: > The `java.desktop` module currently lacks proper use of the `@Override` > annotation for methods and the `final` modifier for classes. While similar > changes were previously made in the > [JavaSound](https://github.com/openjdk/jdk/com

Re: RFR: 8352638: Enhance code consistency: java.desktop/windows

2025-04-05 Thread Phil Race
On Sat, 22 Mar 2025 00:49:25 GMT, Sergey Bylokhov wrote: > The `java.desktop` module currently lacks proper use of the `@Override` > annotation for methods and the `final` modifier for classes. While similar > changes were previously made in the > [JavaSound](https://github.com/openjdk/jdk/com

Re: RFR: 8352638: Enhance code consistency: java.desktop/windows

2025-04-04 Thread Phil Race
On Fri, 4 Apr 2025 00:06:20 GMT, Sergey Bylokhov wrote: > > The pattern below seems odd. What is the point of the protected modifier on > > a final class ? > > This(and similar) logic was copied from > [Metal](https://github.com/openjdk/jdk/blob/57df89c46449a19bb626fee2ea01c868e6dfb712/src/jav

Re: RFR: 8352638: Enhance code consistency: java.desktop/windows

2025-04-03 Thread Sergey Bylokhov
On Thu, 3 Apr 2025 20:01:21 GMT, Phil Race wrote: >The pattern below seems odd. What is the point of the protected modifier on a >final class ? This(and similar) logic was copied from [Metal](https://github.com/openjdk/jdk/blob/57df89c46449a19bb626fee2ea01c868e6dfb712/src/java.desktop/share/cl

RFR: 8352638: Enhance code consistency: java.desktop/windows

2025-03-24 Thread Sergey Bylokhov
The `java.desktop` module currently lacks proper use of the `@Override` annotation for methods and the `final` modifier for classes. While similar changes were previously made in the [JavaSound](https://github.com/openjdk/jdk/commit/e0c7d59246cf36644d494eced76e4b9d96ff1ded#diff-ae3e5f9c40fe25ef0