Re: RFR: 8353002: Remove unnecessary Windows version check in WTaskbarPeer

2025-04-10 Thread Alexey Ivanov
On Fri, 28 Mar 2025 09:41:22 GMT, Daniel Gredler wrote: > WTaskbarPeer contains a check as to whether the current Windows version is > Windows 7 or later. The current minimum supported version is Windows 10, so > this is no longer needed. > > There didn't seem to be a public test exercising th

Re: RFR: 8353002: Remove unnecessary Windows version check in WTaskbarPeer

2025-04-10 Thread Alexey Ivanov
On Mon, 7 Apr 2025 14:40:38 GMT, Daniel Gredler wrote: >> src/java.desktop/windows/classes/sun/awt/windows/WTaskbarPeer.java line 46: >> >>> 44: private static synchronized void init() { >>> 45: if (!initExecuted) { >>> 46: supported = ShellFolder.invoke(() -> nativeInit(

Re: RFR: 8353002: Remove unnecessary Windows version check in WTaskbarPeer

2025-04-07 Thread duke
On Fri, 28 Mar 2025 09:41:22 GMT, Daniel Gredler wrote: > WTaskbarPeer contains a check as to whether the current Windows version is > Windows 7 or later. The current minimum supported version is Windows 10, so > this is no longer needed. > > There didn't seem to be a public test exercising th

Re: RFR: 8353002: Remove unnecessary Windows version check in WTaskbarPeer

2025-04-07 Thread Daniel Gredler
On Fri, 28 Mar 2025 19:28:58 GMT, Alexey Ivanov wrote: >> WTaskbarPeer contains a check as to whether the current Windows version is >> Windows 7 or later. The current minimum supported version is Windows 10, so >> this is no longer needed. >> >> There didn't seem to be a public test exercisin

Re: RFR: 8353002: Remove unnecessary Windows version check in WTaskbarPeer

2025-04-05 Thread Phil Race
On Wed, 2 Apr 2025 10:29:00 GMT, Daniel Gredler wrote: >> The biggest issue with >> [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) is that it was >> backported to older updates, including JDK 11, which is still in use on >> legacy systems. I think it's reasonable to assume that JDK

Re: RFR: 8353002: Remove unnecessary Windows version check in WTaskbarPeer

2025-04-05 Thread Alexey Ivanov
On Fri, 28 Mar 2025 09:41:22 GMT, Daniel Gredler wrote: > WTaskbarPeer contains a check as to whether the current Windows version is > Windows 7 or later. The current minimum supported version is Windows 10, so > this is no longer needed. > > There didn't seem to be a public test exercising th

Re: RFR: 8353002: Remove unnecessary Windows version check in WTaskbarPeer

2025-04-04 Thread Sergey Bylokhov
On Fri, 28 Mar 2025 09:41:22 GMT, Daniel Gredler wrote: > WTaskbarPeer contains a check as to whether the current Windows version is > Windows 7 or later. The current minimum supported version is Windows 10, so > this is no longer needed. > > There didn't seem to be a public test exercising th

Re: RFR: 8353002: Remove unnecessary Windows version check in WTaskbarPeer

2025-04-03 Thread Phil Race
On Fri, 28 Mar 2025 09:41:22 GMT, Daniel Gredler wrote: > WTaskbarPeer contains a check as to whether the current Windows version is > Windows 7 or later. The current minimum supported version is Windows 10, so > this is no longer needed. > > There didn't seem to be a public test exercising th

Re: RFR: 8353002: Remove unnecessary Windows version check in WTaskbarPeer

2025-04-02 Thread Daniel Gredler
On Wed, 2 Apr 2025 04:05:52 GMT, Sergey Bylokhov wrote: >> Interesting, thanks for the link! >> >> One issue I see with >> [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) is that it didn't >> work all the way back to the original Windows 10 release, which conflicts >> with the [Ora

Re: RFR: 8353002: Remove unnecessary Windows version check in WTaskbarPeer

2025-04-01 Thread Sergey Bylokhov
On Fri, 28 Mar 2025 20:55:57 GMT, Daniel Gredler wrote: >> src/java.desktop/windows/classes/sun/awt/windows/WTaskbarPeer.java line 46: >> >>> 44: private static synchronized void init() { >>> 45: if (!initExecuted) { >>> 46: supported = ShellFolder.invoke(() -> nativeInit

Re: RFR: 8353002: Remove unnecessary Windows version check in WTaskbarPeer

2025-03-29 Thread Daniel Gredler
On Fri, 28 Mar 2025 19:28:58 GMT, Alexey Ivanov wrote: >> WTaskbarPeer contains a check as to whether the current Windows version is >> Windows 7 or later. The current minimum supported version is Windows 10, so >> this is no longer needed. >> >> There didn't seem to be a public test exercisin

RFR: 8353002: Remove unnecessary Windows version check in WTaskbarPeer

2025-03-28 Thread Daniel Gredler
WTaskbarPeer contains a check as to whether the current Windows version is Windows 7 or later. The current minimum supported version is Windows 10, so this is no longer needed. There didn't seem to be a public test exercising this code, so I also added a basic Taskbar sanity test.