Re: RFR: 8358057: Update validation of ICC_Profile header data [v4]

2025-06-02 Thread Harshitha Onkar
On Mon, 2 Jun 2025 19:28:09 GMT, Sergey Bylokhov wrote: >> The [next PR](https://github.com/openjdk/jdk/pull/23044) introduces several >> new methods to the ICC_Profile class: >> - getProfileClass(byte[]) >> - getColorSpaceType(byte[]) >> - getPCSType(byte[]) >> - checkRenderingIntent(byte[]

Re: RFR: 8358057: Update validation of ICC_Profile header data [v4]

2025-06-02 Thread Sergey Bylokhov
> The [next PR](https://github.com/openjdk/jdk/pull/23044) introduces several > new methods to the ICC_Profile class: > - getProfileClass(byte[]) > - getColorSpaceType(byte[]) > - getPCSType(byte[]) > - checkRenderingIntent(byte[]) > > These new methods extract data directly from the provided

Re: RFR: 8358057: Update validation of ICC_Profile header data [v3]

2025-06-02 Thread Harshitha Onkar
On Sat, 31 May 2025 04:21:41 GMT, Sergey Bylokhov wrote: >> Sergey Bylokhov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update ValidateICCHeaderData.java > > test/jdk/java/awt/color/ICC_Profile/ValidateICCHeaderData/ValidateICCHeader

Re: RFR: 8358057: Update validation of ICC_Profile header data [v3]

2025-05-30 Thread Sergey Bylokhov
On Sat, 31 May 2025 04:21:41 GMT, Sergey Bylokhov wrote: >> The [next PR](https://github.com/openjdk/jdk/pull/23044) introduces several >> new methods to the ICC_Profile class: >> - getProfileClass(byte[]) >> - getColorSpaceType(byte[]) >> - getPCSType(byte[]) >> - checkRenderingIntent(byte[

Re: RFR: 8358057: Update validation of ICC_Profile header data [v3]

2025-05-30 Thread Sergey Bylokhov
> The [next PR](https://github.com/openjdk/jdk/pull/23044) introduces several > new methods to the ICC_Profile class: > - getProfileClass(byte[]) > - getColorSpaceType(byte[]) > - getPCSType(byte[]) > - checkRenderingIntent(byte[]) > > These new methods extract data directly from the provided

Re: RFR: 8358057: Update validation of ICC_Profile header data [v2]

2025-05-30 Thread Sergey Bylokhov
> The [next PR](https://github.com/openjdk/jdk/pull/23044) introduces several > new methods to the ICC_Profile class: > - getProfileClass(byte[]) > - getColorSpaceType(byte[]) > - getPCSType(byte[]) > - checkRenderingIntent(byte[]) > > These new methods extract data directly from the provided

Re: RFR: 8358057: Update validation of ICC_Profile header data

2025-05-30 Thread Sergey Bylokhov
On Fri, 30 May 2025 23:56:35 GMT, Harshitha Onkar wrote: >I hadn't noticed it earlier but icAbsoluteColorimetric and >icICCAbsoluteColorimetric point to the same intent. Is it good to unify them >into a single constant in src code during clean up (separate issue)? At some point, that constants

Re: RFR: 8358057: Update validation of ICC_Profile header data

2025-05-30 Thread Harshitha Onkar
On Thu, 29 May 2025 10:22:39 GMT, Sergey Bylokhov wrote: > The [next PR](https://github.com/openjdk/jdk/pull/23044) introduces several > new methods to the ICC_Profile class: > - getProfileClass(byte[]) > - getColorSpaceType(byte[]) > - getPCSType(byte[]) > - checkRenderingIntent(byte[]) >

RFR: 8358057: Update validation of ICC_Profile header data

2025-05-29 Thread Sergey Bylokhov
The [next PR](https://github.com/openjdk/jdk/pull/23044) introduces several new methods to the ICC_Profile class: - getProfileClass(byte[]) - getColorSpaceType(byte[]) - getPCSType(byte[]) - checkRenderingIntent(byte[]) These new methods extract data directly from the provided byte array rath