Re: RFR: JDK-8302281 - ImageIO objects should implement AutoClosable [v5]

2023-02-18 Thread Markus KARG
> ImageIO objects, like ImageReader, ImageWrite, ImageInputStream and > ImageOutputStream, should implement AutoClosable. > > There is a risk of keeping resources opened longer than needed (or even run > into a resource leak with long running processes) as the user cannot use > try-with-resourc

Re: RFR: JDK-8302281 - ImageIO objects should implement AutoClosable [v4]

2023-02-18 Thread Markus KARG
> ImageIO objects, like ImageReader, ImageWrite, ImageInputStream and > ImageOutputStream, should implement AutoClosable. > > There is a risk of keeping resources opened longer than needed (or even run > into a resource leak with long running processes) as the user cannot use > try-with-resourc

Re: RFR: JDK-8302281 - ImageIO objects should implement AutoClosable [v3]

2023-02-18 Thread Markus KARG
> ImageIO objects, like ImageReader, ImageWrite, ImageInputStream and > ImageOutputStream, should implement AutoClosable. > > There is a risk of keeping resources opened longer than needed (or even run > into a resource leak with long running processes) as the user cannot use > try-with-resourc

Re: RFR: JDK-8302281 - ImageIO objects should implement AutoClosable [v2]

2023-02-18 Thread Markus KARG
On Mon, 13 Feb 2023 21:03:45 GMT, Phil Race wrote: >> Markus KARG has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added @since > > oh, and in future discuss things like this on the list and get agreement > BEFORE posting a PR. > See htt

Re: RFR: JDK-8302281 - ImageIO objects should implement AutoClosable [v2]

2023-02-13 Thread Phil Race
On Sun, 12 Feb 2023 09:41:47 GMT, Markus KARG wrote: >> ImageIO objects, like ImageReader, ImageWrite, ImageInputStream and >> ImageOutputStream, should implement AutoClosable. >> >> There is a risk of keeping resources opened longer than needed (or even run >> into a resource leak with long r

Re: RFR: JDK-8302281 - ImageIO objects should implement AutoClosable [v2]

2023-02-13 Thread Phil Race
On Sun, 12 Feb 2023 09:41:47 GMT, Markus KARG wrote: >> ImageIO objects, like ImageReader, ImageWrite, ImageInputStream and >> ImageOutputStream, should implement AutoClosable. >> >> There is a risk of keeping resources opened longer than needed (or even run >> into a resource leak with long r

Re: RFR: JDK-8302281 - ImageIO objects should implement AutoClosable [v2]

2023-02-12 Thread Markus KARG
On Sun, 12 Feb 2023 01:28:40 GMT, Glavo wrote: >> Markus KARG has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added @since > > src/java.desktop/share/classes/javax/imageio/ImageReader.java line 2883: > >> 2881: * @implNote The defa

Re: RFR: JDK-8302281 - ImageIO objects should implement AutoClosable [v2]

2023-02-12 Thread Markus KARG
> ImageIO objects, like ImageReader, ImageWrite, ImageInputStream and > ImageOutputStream, should implement AutoClosable. > > There is a risk of keeping resources opened longer than needed (or even run > into a resource leak with long running processes) as the user cannot use > try-with-resourc

Re: RFR: JDK-8302281 - ImageIO objects should implement AutoClosable

2023-02-11 Thread Glavo
On Thu, 19 Jan 2023 18:41:08 GMT, Markus KARG wrote: > ImageIO objects, like ImageReader, ImageWrite, ImageInputStream and > ImageOutputStream, should implement AutoClosable. > > There is a risk of keeping resources opened longer than needed (or even run > into a resource leak with long runnin

RFR: JDK-8302281 - ImageIO objects should implement AutoClosable

2023-02-11 Thread Markus KARG
ImageIO objects, like ImageReader, ImageWrite, ImageInputStream and ImageOutputStream, should implement AutoClosable. There is a risk of keeping resources opened longer than needed (or even run into a resource leak with long running processes) as the user cannot use try-with-resources currently