Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v6]

2023-04-21 Thread Sergey Bylokhov
On Fri, 21 Apr 2023 23:16:06 GMT, Jeremy wrote: > Does this answer your question, or are you considering a different use case? Yes, if it is safe to assume that it is not possible to change the `theConsumer` by a different thread. - PR Review Comment: https://git.openjdk.org/jdk/p

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v6]

2023-04-21 Thread Sergey Bylokhov
On Fri, 14 Apr 2023 01:54:49 GMT, Jeremy wrote: >> This resolves a 25 year old P4 ticket: a NullPointerException is printed to >> System.err needlessly. >> >> This resolution involves confirming that an ImageConsumer is still >> registered before every notification. >> >> I'll understand if t

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v6]

2023-04-21 Thread Jeremy
On Fri, 21 Apr 2023 21:31:54 GMT, Sergey Bylokhov wrote: >> Jeremy has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 4200096: removing whitespace diffs >> >> prrace pointed out this branch introduced some pointless whitespace >> chan

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v6]

2023-04-21 Thread Sergey Bylokhov
On Fri, 14 Apr 2023 01:54:49 GMT, Jeremy wrote: >> This resolves a 25 year old P4 ticket: a NullPointerException is printed to >> System.err needlessly. >> >> This resolution involves confirming that an ImageConsumer is still >> registered before every notification. >> >> I'll understand if t

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v5]

2023-04-20 Thread Jeremy
On Wed, 12 Apr 2023 22:55:42 GMT, Phil Race wrote: >> Jeremy has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 4200096: updating test class header to better describe test > > src/java.desktop/share/classes/sun/awt/image/OffScreenImageSourc

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v6]

2023-04-13 Thread Jeremy
> This resolves a 25 year old P4 ticket: a NullPointerException is printed to > System.err needlessly. > > This resolution involves confirming that an ImageConsumer is still registered > before every notification. > > I'll understand if this is rejected as unimportant, but I stumbled across >

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v5]

2023-04-13 Thread Phil Race
On Wed, 12 Apr 2023 08:33:28 GMT, Jeremy wrote: >> This resolves a 25 year old P4 ticket: a NullPointerException is printed to >> System.err needlessly. >> >> This resolution involves confirming that an ImageConsumer is still >> registered before every notification. >> >> I'll understand if t

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v5]

2023-04-12 Thread Jeremy
> This resolves a 25 year old P4 ticket: a NullPointerException is printed to > System.err needlessly. > > This resolution involves confirming that an ImageConsumer is still registered > before every notification. > > I'll understand if this is rejected as unimportant, but I stumbled across >

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v4]

2023-04-12 Thread Jeremy
On Wed, 12 Apr 2023 08:09:42 GMT, Jeremy wrote: >> This resolves a 25 year old P4 ticket: a NullPointerException is printed to >> System.err needlessly. >> >> This resolution involves confirming that an ImageConsumer is still >> registered before every notification. >> >> I'll understand if t

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v4]

2023-04-12 Thread Jeremy
> This resolves a 25 year old P4 ticket: a NullPointerException is printed to > System.err needlessly. > > This resolution involves confirming that an ImageConsumer is still registered > before every notification. > > I'll understand if this is rejected as unimportant, but I stumbled across >

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v3]

2023-04-11 Thread Phil Race
On Wed, 12 Apr 2023 04:00:57 GMT, Jeremy wrote: >> This resolves a 25 year old P4 ticket: a NullPointerException is printed to >> System.err needlessly. >> >> This resolution involves confirming that an ImageConsumer is still >> registered before every notification. >> >> I'll understand if t

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v3]

2023-04-11 Thread Jeremy
On Tue, 11 Apr 2023 00:10:53 GMT, Sergey Bylokhov wrote: >> Jeremy has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 4200096: rewrite solution, add LegitimateNullPointerTest >> >> Also I'm breaking out the unit tests (now there are 4

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v2]

2023-04-11 Thread Jeremy
On Tue, 11 Apr 2023 03:49:25 GMT, Jeremy wrote: >> This resolves a 25 year old P4 ticket: a NullPointerException is printed to >> System.err needlessly. >> >> This resolution involves confirming that an ImageConsumer is still >> registered before every notification. >> >> I'll understand if t

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v3]

2023-04-11 Thread Jeremy
> This resolves a 25 year old P4 ticket: a NullPointerException is printed to > System.err needlessly. > > This resolution involves confirming that an ImageConsumer is still registered > before every notification. > > I'll understand if this is rejected as unimportant, but I stumbled across >

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v2]

2023-04-11 Thread Phil Race
On Tue, 11 Apr 2023 03:49:25 GMT, Jeremy wrote: >> This resolves a 25 year old P4 ticket: a NullPointerException is printed to >> System.err needlessly. >> >> This resolution involves confirming that an ImageConsumer is still >> registered before every notification. >> >> I'll understand if t

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException

2023-04-10 Thread Jeremy
On Mon, 10 Apr 2023 16:16:32 GMT, Jeremy wrote: > This resolves a 25 year old P4 ticket: a NullPointerException is printed to > System.err needlessly. > > This resolution involves confirming that an ImageConsumer is still registered > before every notification. > > I'll understand if this is

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v2]

2023-04-10 Thread Jeremy
> This resolves a 25 year old P4 ticket: a NullPointerException is printed to > System.err needlessly. > > This resolution involves confirming that an ImageConsumer is still registered > before every notification. > > I'll understand if this is rejected as unimportant, but I stumbled across >

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException

2023-04-10 Thread Sergey Bylokhov
On Mon, 10 Apr 2023 16:16:32 GMT, Jeremy wrote: > This resolves a 25 year old P4 ticket: a NullPointerException is printed to > System.err needlessly. > > This resolution involves confirming that an ImageConsumer is still registered > before every notification. > > I'll understand if this is

Re: RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException

2023-04-10 Thread Phil Race
On Mon, 10 Apr 2023 16:16:32 GMT, Jeremy wrote: > This resolves a 25 year old P4 ticket: a NullPointerException is printed to > System.err needlessly. > > This resolution involves confirming that an ImageConsumer is still registered > before every notification. > > I'll understand if this is