Integrated: 6513512: MetalLookAndFeel.initClassDefaults does not install an entry for MetalMenuBarUI

2023-02-13 Thread Prasanta Sadhukhan
On Tue, 13 Dec 2022 09:56:47 GMT, Prasanta Sadhukhan wrote: > Spec for > [MetalLookAndFeel](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java#L247) > says: > "...MetalLookAndFeel registers an entry for each of the classes > in

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v7]

2023-02-13 Thread Prasanta Sadhukhan
> Issue is observed that after changing the Look & Feel from Metal to Nimbus > and back to Metal, the Nimbus font continues to be used by a JFileChooser. > This is because Synth `installDefaults `methods set the font, but its > inverse methods `uninstallDefaults `do not remove them. > Fix is mad

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v6]

2023-02-13 Thread Prasanta Sadhukhan
On Fri, 10 Feb 2023 17:08:34 GMT, Alexey Ivanov wrote: >> I dont think it's redundant..There's a || check in between >> >> If `curFont `is not null and `origFont `is null, then 1st condition `curFont >> != null && !curFont.equals(origFont)` is satisfied and it will throw >> exception >> >> If

Re: RFR: 8081474: SwingWorker calls 'done' before the 'doInBackground' is finished [v19]

2023-02-13 Thread Prasanta Sadhukhan
On Fri, 10 Feb 2023 16:46:24 GMT, Prasanta Sadhukhan wrote: >> SwingWorker done() method [spec >> ](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L452) >> says "Executed on the Event Dispatch Thread after the doInBackground method >> is

RFR: 8302173: Button border overlaps with button icon on macOS system LaF

2023-02-13 Thread Damon Nguyen
Previous fix to HTML in AquaButtonUI fixed spacing issue for HTML images in a JButton in Aqua L&F. The new issue comes from having text inside the HTML as the button's text. If an icon is used, this icon exceeds the bounds of the button and overlaps the border. Added additional logic to check i

Re: RFR: JDK-8302281 - ImageIO objects should implement AutoClosable [v2]

2023-02-13 Thread Phil Race
On Sun, 12 Feb 2023 09:41:47 GMT, Markus KARG wrote: >> ImageIO objects, like ImageReader, ImageWrite, ImageInputStream and >> ImageOutputStream, should implement AutoClosable. >> >> There is a risk of keeping resources opened longer than needed (or even run >> into a resource leak with long r

Re: RFR: JDK-8302281 - ImageIO objects should implement AutoClosable [v2]

2023-02-13 Thread Phil Race
On Sun, 12 Feb 2023 09:41:47 GMT, Markus KARG wrote: >> ImageIO objects, like ImageReader, ImageWrite, ImageInputStream and >> ImageOutputStream, should implement AutoClosable. >> >> There is a risk of keeping resources opened longer than needed (or even run >> into a resource leak with long r

Re: RFR: 8302173: Button border overlaps with button icon on macOS system LaF

2023-02-13 Thread Harshitha Onkar
On Sat, 11 Feb 2023 00:23:05 GMT, Damon Nguyen wrote: > Previous fix to HTML in AquaButtonUI fixed spacing issue for HTML images in a > JButton in Aqua L&F. The new issue comes from having text inside the HTML as > the button's text. If an icon is used, this icon exceeds the bounds of the > bu