suggested clarification

2024-08-04 Thread Alan Snyder
The spec for javax.swing.text.View.viewToModel(float x, float y, Shape a, Position.Bias[] biasReturn) says: "The biasReturn argument will be filled in to indicate that the point given is closer to the next character in the model or the previous character in the model.” It looks like a non-null

Re: RFR: 8335231: [macos] Test java/awt/print/PrinterJob/Cancel/PrinterJobCancel.java failed on macOS because the case didn't get the expected PrintAbortException [v4]

2024-08-04 Thread Phil Race
On Fri, 2 Aug 2024 04:51:13 GMT, Prasanta Sadhukhan wrote: >> When a printjob is cancelled midway, `PrinterAbortException `was not thrown >> in macos. because >> firstly,` cancelCheck` invokes` LWCToolkit.invokeLater` with null as >> parameter causing it to fail with NPE and >> secondly Print

Re: RFR: 8333403: Write a test to check various components events are triggered properly [v7]

2024-08-04 Thread Ravi Gupta
> This testcase checks for the following assertions for Component events: > > 1. When components are resized, moved, hidden and shown the respective events > are triggered. > 2. When the components are hidden/disabled also,the component events like > resized/moved are triggered. > 3. When a hidd

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v3]

2024-08-04 Thread Julian Waters
On Tue, 16 Jul 2024 08:59:20 GMT, Julian Waters wrote: >> snprintf has been available for all officially and unofficially supported >> compilers for Windows, Visual Studio since version 2015 and gcc since, well, >> forever. snprintf is conforming to C99 since the start when compiling using >>

Integrated: 8334599: Improve code from JDK-8302671

2024-08-04 Thread Julian Waters
On Thu, 20 Jun 2024 08:29:39 GMT, Julian Waters wrote: > In [JDK-8302671](https://bugs.openjdk.org/browse/JDK-8302671) I fixed a > memmove decay bug by rewriting a sizeof on an array to an explicit size of > 256, but this is a bit of a band aid fix. It's come to my attention that in > C++, one

Re: RFR: 8334599: Improve code from JDK-8302671 [v3]

2024-08-04 Thread Julian Waters
On Thu, 11 Jul 2024 08:41:28 GMT, Julian Waters wrote: >> In [JDK-8302671](https://bugs.openjdk.org/browse/JDK-8302671) I fixed a >> memmove decay bug by rewriting a sizeof on an array to an explicit size of >> 256, but this is a bit of a band aid fix. It's come to my attention that in >> C++,

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v3]

2024-08-04 Thread Jaikiran Pai
On Tue, 16 Jul 2024 08:59:20 GMT, Julian Waters wrote: >> snprintf has been available for all officially and unofficially supported >> compilers for Windows, Visual Studio since version 2015 and gcc since, well, >> forever. snprintf is conforming to C99 since the start when compiling using >>