On Thu, 22 Aug 2024 22:12:10 GMT, Harshitha Onkar wrote:
>> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java
>> line 1062:
>>
>>> 1060:"shift KP_RIGHT",
>>> "selectNextColumnExtendSelection",
>>> 1061: "ctrl shift RIGHT
On Thu, 22 Aug 2024 21:32:08 GMT, Alisen Chung wrote:
>> This test should have failed with the
>> [changeset](https://github.com/openjdk/jdk/pull/20612) proposed for
>> [JDK-4795384](https://bugs.openjdk.org/browse/JDK-4795384) but it didn't
>> because GTK look and feel isn't supported in head
On Thu, 22 Aug 2024 05:24:24 GMT, Abhishek Kumar wrote:
> This test should have failed with the
> [changeset](https://github.com/openjdk/jdk/pull/20612) proposed for
> [JDK-4795384](https://bugs.openjdk.org/browse/JDK-4795384) but it didn't
> because GTK look and feel isn't supported in headle
On Thu, 22 Aug 2024 22:02:13 GMT, Harshitha Onkar wrote:
> @kumarabhi006
>
> > Fix is to run the test with headful environment on linux platform.
>
> Does this have to do with not loading the gtk files in headless mode?
> https://github.com/openjdk/jdk/blob/master/src/java.desktop/unix/native/
> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
> the use of JNI in the following ways:
>
> * `System::load` and `System::loadLibrary` are now restricted methods
> * `Runtime::load` and `Runtime::loadLibrary` are now restricted methods
> * binding a JNI `native` metho
On Thu, 22 Aug 2024 18:04:46 GMT, Manukumar V S wrote:
>> This PR creates a new test by stabilising and open sourcing a closed test.
>> This test verifies that the OpenGL pipeline does not create artifacts with
>> swing components after window is zoomed to maximum size and then resized
>> back
On Fri, 23 Aug 2024 08:59:52 GMT, Alexey Ivanov wrote:
> > @kumarabhi006
> > > Fix is to run the test with headful environment on linux platform.
> >
> >
> > Does this have to do with not loading the gtk files in headless mode?
> > https://github.com/openjdk/jdk/blob/master/src/java.desktop/un
> This test should have failed with the
> [changeset](https://github.com/openjdk/jdk/pull/20612) proposed for
> [JDK-4795384](https://bugs.openjdk.org/browse/JDK-4795384) but it didn't
> because GTK look and feel isn't supported in headless environment.
>
> Fix is to run the test with headful e
On Thu, 22 Aug 2024 21:33:56 GMT, Alisen Chung wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment update
>
> test/jdk/javax/swing/JFileChooser/8080628/bug8080628.java line 1:
>
>> 1: /*
>
> Could yo
The testcase calls Platform.exit before the dialog is made visible but
on macOS, JavaFX takes over the AppKit thread and uses that as the FX
application thread. As part of the FX platform shutdown process, it detaches
that thread from the JVM. This means that the AppKit thread is no longer
avail
On Fri, 23 Aug 2024 09:28:22 GMT, Abhishek Kumar wrote:
>> This test should have failed with the
>> [changeset](https://github.com/openjdk/jdk/pull/20612) proposed for
>> [JDK-4795384](https://bugs.openjdk.org/browse/JDK-4795384) but it didn't
>> because GTK look and feel isn't supported in he
On Fri, 23 Aug 2024 09:21:02 GMT, Abhishek Kumar wrote:
>> test/jdk/javax/swing/JFileChooser/8080628/bug8080628.java line 1:
>>
>>> 1: /*
>>
>> Could you also clean up the main method and remove the extra overhead in the
>> SwingUtilities.invokeAndWait call? Also remember to update copyright y
On Thu, 22 Aug 2024 22:49:50 GMT, David Holmes wrote:
> is the final intent here that this one magic file will be compiled first with
> an inline declaration such that when the other files containing the apparent
> runtime check get compiled, it can actually be determined at build time and
> s
On Thu, 25 Jul 2024 14:04:32 GMT, Tejesh R wrote:
> Mismatch in key combinations, I have taken native macos Numbers application
> as reference to verify. Have added `Ctrl-Shift Left/Right` action keys
> similar to `Ctrl-Shift UP/DOWN` which would be expected functionality. I've
> removed those
On Thu, 22 Aug 2024 18:04:46 GMT, Manukumar V S wrote:
>> This PR creates a new test by stabilising and open sourcing a closed test.
>> This test verifies that the OpenGL pipeline does not create artifacts with
>> swing components after window is zoomed to maximum size and then resized
>> back
In addition to SWinxy very good comments, allow me to suggest a few more items:
* ability to set the date format, locale, calendar separately
* possibly show additional information such as week numbers
* make sure the new component is fully accessible
* option to grey out or hide
It would be helpful if replies were structured so as to answer the
questions we asked.
These are very much in priority order. Unless there's yes answers to the
1st & 2nd question,
the feature set and comparisons really don't matter ..
-phil.
On 8/23/24 9:25 AM, Andy Goryachev wrote:
- Is it
On Fri, 23 Aug 2024 09:28:22 GMT, Abhishek Kumar wrote:
>> This test should have failed with the
>> [changeset](https://github.com/openjdk/jdk/pull/20612) proposed for
>> [JDK-4795384](https://bugs.openjdk.org/browse/JDK-4795384) but it didn't
>> because GTK look and feel isn't supported in he
On Fri, 23 Aug 2024 09:17:43 GMT, Prasanta Sadhukhan
wrote:
> The testcase calls Platform.exit before the dialog is made visible but
> on macOS, JavaFX takes over the AppKit thread and uses that as the FX
> application thread. As part of the FX platform shutdown process, it detaches
> that thr
On Fri, 23 Aug 2024 09:28:22 GMT, Abhishek Kumar wrote:
>> This test should have failed with the
>> [changeset](https://github.com/openjdk/jdk/pull/20612) proposed for
>> [JDK-4795384](https://bugs.openjdk.org/browse/JDK-4795384) but it didn't
>> because GTK look and feel isn't supported in he
On Tue, 20 Aug 2024 07:26:12 GMT, Tejesh R wrote:
>> In JTable, keyboard navigation keys Ctrl Shift RIGHT/LEFT doesn't follow
>> native actions of Linux. In native the actions are extended to end of
>> selected columns cells either LEFT/RIGHT but in swing gtk look and feel the
>> selection is
On Tue, 20 Aug 2024 14:47:23 GMT, Alexey Ivanov wrote:
>> I looked at
>> `java/awt/Choice/SelectCurrentItemTest/SelectCurrentItemTest.java`, ran it
>> and noticed that the test does not open the popup of the `Choice` component
>> on macOS 14.x.
>>
>> If the popup does not open, the test does
On Thu, 15 Aug 2024 00:58:18 GMT, lawrence.andrews wrote:
> Added the missing jpg file & tested and NPE is not seen any more
Marked as reviewed by prr (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/20589#pullrequestreview-2257836393
On Mon, 19 Aug 2024 01:28:20 GMT, toshiogata wrote:
>> Rename the tests to prevent unexpected deletion of result files when
>> `-retain` jtreg option is specified.
>> Testing: modified tests
>
> toshiogata has updated the pull request incrementally with one additional
> commit since the last re
On Mon, 29 Jul 2024 18:33:08 GMT, Phil Race wrote:
>> This changeset updates the image in the documentation for the
>> `Document.insert` method. The image in `Document.remove` was updated by
>> [JDK-4622866](https://bugs.openjdk.org/browse/JDK-4622866) in PR #15701.
>>
>> Now the illustration
On Thu, 22 Aug 2024 18:04:46 GMT, Manukumar V S wrote:
>> This PR creates a new test by stabilising and open sourcing a closed test.
>> This test verifies that the OpenGL pipeline does not create artifacts with
>> swing components after window is zoomed to maximum size and then resized
>> back
On Fri, 23 Aug 2024 18:36:40 GMT, Phil Race wrote:
>> Manukumar V S has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comment fixed : Changed the position of line comments
>
> test/jdk/javax/swing/JButton/SwingButtonResizeTestWithOp
> Is it of interest ?
Yes
> Would you use it ?
As needed, sure. Our current app doesn’t really need a date picker,
though. I can imagine other apps that would.
> What features must it have?
1. A data model that supports choosing one date.
2. A highlighter that lets us decorate arbitrary da
On Mon, 19 Aug 2024 12:34:15 GMT, Alexey Ivanov wrote:
>> Thank you for pointing it out. I was not aware of the git rename issue.
>> I changed the fix to only rename files.
>
>> Thank you for pointing it out. I was not aware of the git rename issue.
>
> Even if it were not for this Git “limitati
On Mon, 19 Aug 2024 01:28:20 GMT, toshiogata wrote:
>> Rename the tests to prevent unexpected deletion of result files when
>> `-retain` jtreg option is specified.
>> Testing: modified tests
>
> toshiogata has updated the pull request incrementally with one additional
> commit since the last re
On Fri, 23 Aug 2024 22:31:04 GMT, Jonathan Gibbons wrote:
>> toshiogata has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert "Move jtreg tags and expand wildcard imports"
>>
>> This reverts commit 9b30df1230b7e31b42e63ae01ef154956
On Tue, 30 Jul 2024 03:14:05 GMT, Prasanta Sadhukhan
wrote:
>> BasicSplitPaneDivider:oneTouchExpandableChanged() spec doesn't mention that
>> it will create left/right button only if L&F supports
>> SplitPane.supportsOneTouchButtons which is now added in javadoc..
>
> Prasanta Sadhukhan has up
On Fri, 23 Aug 2024 17:56:57 GMT, Phil Race wrote:
>> The testcase calls Platform.exit before the dialog is made visible but
>> on macOS, JavaFX takes over the AppKit thread and uses that as the FX
>> application thread. As part of the FX platform shutdown process, it detaches
>> that thread fr
On Thu, 22 Aug 2024 03:59:57 GMT, Sergey Bylokhov wrote:
> The unused `java.awt.datatransfer.SystemFlavorMap#FLAVOR_MAP_KEY` field is
> deleted.
>
> It was unused since [8037485](https://bugs.openjdk.org/browse/JDK-8037485):
> Refactor java.awt.datatransfer to eliminate dependency on AWT.
>
>
On Mon, 29 Jul 2024 13:43:42 GMT, Alexey Ivanov wrote:
> This changeset updates the image in the documentation for the
> `Document.insert` method. The image in `Document.remove` was updated by
> [JDK-4622866](https://bugs.openjdk.org/browse/JDK-4622866) in PR #15701.
>
> Now the illustration o
On Fri, 23 Aug 2024 23:30:53 GMT, Phil Race wrote:
> Can you make it clear it is a "Swing" property and update the CSR too.
Maybe we can improve the javadoc tool for that? It is currently possible to
mark/highlight the system properties in the doc, it should be possible to do
the same for Swin
On Fri, 23 Aug 2024 23:47:12 GMT, Kevin Rushforth wrote:
> I'm also not sure that this is the right fix. It seems like it will fix one
> specific place where AWT could do an upcall on the AppKit thread after FX has
> detached without addressing the problem as a whole.
>
> Another possible fix
On Sat, 24 Aug 2024 00:04:33 GMT, Phil Race wrote:
>> I'm also not sure that this is the right fix. It seems like it will fix one
>> specific place where AWT could do an upcall on the AppKit thread after FX
>> has detached without addressing the problem as a whole.
>>
>> Another possible fix w
On Tue, 16 Jul 2024 08:59:20 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
> snprintf has been available for all officially and unofficially supported
> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
> forever. snprintf is conforming to C99 since the start when compiling using
> gcc, and 2015 when using Visual Studio. Since it conforms to
> snprintf has been available for all officially and unofficially supported
> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
> forever. snprintf is conforming to C99 since the start when compiling using
> gcc, and 2015 when using Visual Studio. Since it conforms to
On Sat, 24 Aug 2024 05:06:18 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
On Sat, 24 Aug 2024 05:12:42 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
On Fri, 23 Aug 2024 18:36:40 GMT, Phil Race wrote:
>> Manukumar V S has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comment fixed : Changed the position of line comments
>
> test/jdk/javax/swing/JButton/SwingButtonResizeTestWithOp
44 matches
Mail list logo
