Re: RFR: 8270265: LineBreakMeasurer calculates incorrect line breaks with zero-width characters

2025-02-21 Thread Alisen Chung
On Fri, 14 Feb 2025 00:04:29 GMT, Phil Race wrote: >> When a string contains zero-width characters, `LineBreakMeasurer` calculates >> line breaks incorrectly. >> >> The root cause appears to be that `LineBreakMeasurer` eventually calls into >> `StandardGlyphVector.getGlyphInfo()`, which derive

Re: RFR: 8160327: Support for thumbnails present in APP1 marker for JPEG [v3]

2025-02-21 Thread Brian Burkhalter
On Fri, 21 Feb 2025 02:31:42 GMT, Jeremy wrote: >> This adds support for parsing thumbnails in an APP1 Exif marker. >> >> This builds on an unfinished proposal by Brian Burkhalter (around 2016). In >> that previous work the only additional meta info he parsed was the image >> creation time; th

Re: RFR: 8270265: LineBreakMeasurer calculates incorrect line breaks with zero-width characters [v2]

2025-02-21 Thread Alisen Chung
On Fri, 14 Feb 2025 20:33:26 GMT, Daniel Gredler wrote: >> When a string contains zero-width characters, `LineBreakMeasurer` calculates >> line breaks incorrectly. >> >> The root cause appears to be that `LineBreakMeasurer` eventually calls into >> `StandardGlyphVector.getGlyphInfo()`, which d

Re: RFR: 8270265: LineBreakMeasurer calculates incorrect line breaks with zero-width characters [v3]

2025-02-21 Thread Daniel Gredler
> When a string contains zero-width characters, `LineBreakMeasurer` calculates > line breaks incorrectly. > > The root cause appears to be that `LineBreakMeasurer` eventually calls into > `StandardGlyphVector.getGlyphInfo()`, which derives the glyph advances from > the glyph IDs. However, HarfB

Re: RFR: 8270265: LineBreakMeasurer calculates incorrect line breaks with zero-width characters

2025-02-21 Thread Daniel Gredler
On Fri, 21 Feb 2025 19:39:25 GMT, Alisen Chung wrote: > Should you add only these pixels when running the test on macos? Or do these > pixels not matter on other platforms? It doesn't matter on other platforms, since it's just a little bit of extra leniency. I'm relatively new to the codebase,

Re: RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea [v11]

2025-02-21 Thread Alexander Zuev
On Tue, 28 Jan 2025 15:56:54 GMT, Nikita Provotorov wrote: > Am I right that you don't mind to accept the behavior change you mentioned I am okay with the most of it. Now when you mentioned about ignoring scrolling i think i will need to do some additional testing with the textarea in the scro

Re: RFR: 8160327: Support for thumbnails present in APP1 marker for JPEG [v3]

2025-02-21 Thread Jeremy
On Fri, 21 Feb 2025 02:31:42 GMT, Jeremy wrote: >> This adds support for parsing thumbnails in an APP1 Exif marker. >> >> This builds on an unfinished proposal by Brian Burkhalter (around 2016). In >> that previous work the only additional meta info he parsed was the image >> creation time; th

Re: RFR: 8344981: [REDO] JDK-6672644 JComboBox still scrolling if switch to another window and return back [v6]

2025-02-21 Thread Alexander Zvegintsev
On Wed, 19 Feb 2025 23:04:39 GMT, Damon Nguyen wrote: >> Redo for JComboBox infinite scrolling issue. The issue is that when a >> scrollbar is clicked and held, if the user switches focus (ex: ALT+TAB) >> while scrolling, when focused is returned to the scrolling application, the >> JComboBox

Re: RFR: 8348106: Catch C++ exception in Java_sun_awt_windows_WTaskbarPeer_setOverlayIcon [v5]

2025-02-21 Thread Rajat Mahajan
> **Issue:** > The JNI method `Java_sun_awt_windows_WTaskbarPeer_setOverlayIcon `calls > `CreateIconFromRaster `that can throw a C++ exception. > > The C++ exception must be caught and must not be allowed to escape the JNI > method. The call to `CreateIconFromRaster `has to wrapped into a try-ca

Re: RFR: 8160327: Support for thumbnails present in APP1 marker for JPEG [v3]

2025-02-21 Thread Brian Burkhalter
On Fri, 21 Feb 2025 23:28:26 GMT, Jeremy wrote: > I don't know how to initiate a CSR. Is that something I can initiate, or does > that require a more senior sponsor? I can do that, probably next week. We will need to update the JPEG metadata documentation. - PR Comment: https://g

Re: RFR: 8349932: PSPrinterJob sometimes generates unnecessary PostScript commands [v2]

2025-02-21 Thread Alisen Chung
On Fri, 14 Feb 2025 23:51:49 GMT, Daniel Gredler wrote: >> Trying to print text which is ignored (e.g. `\r` or `\n` or `\t`), or trying >> to print empty shapes generates PostScript graphics context setup commands >> which are not necessary. This can lead to unnecessarily large PostScript >> f

Re: RFR: 8348106: Catch C++ exception in Java_sun_awt_windows_WTaskbarPeer_setOverlayIcon [v5]

2025-02-21 Thread Alexander Zvegintsev
On Fri, 21 Feb 2025 16:29:08 GMT, Rajat Mahajan wrote: >> **Issue:** >> The JNI method `Java_sun_awt_windows_WTaskbarPeer_setOverlayIcon `calls >> `CreateIconFromRaster `that can throw a C++ exception. >> >> The C++ exception must be caught and must not be allowed to escape the JNI >> method.