On Tue, 13 Jun 2023 10:11:28 GMT, Pavel Rappo wrote:
>> Please review this long-awaited change to documentation inheritance.
>>
>> This change improves "methods comment algorithm" and introduces directed
>> documentation inheritance. While "methods comment algorithm" -- automatic
>> search for
On Tue, 20 Sep 2022 06:00:14 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/io/FilterOutputStream.java line 195:
>>
>>> 193:// evaluate possible precedence of flushException
>>> over closeException
>>> 194:if ((flushException instanceof Thre
IdentityLinkedList is used in only one place, so it's fairly simple to replace
it with IdentityArrayList.
-
Commit messages:
- Replace IdentityLinkedList with IdentityArrayList.
Changes: https://git.openjdk.org/jdk/pull/12567/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=
> IdentityLinkedList is used in only one place, so it's fairly simple to
> replace it with IdentityArrayList.
Stuart Marks has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/
> IdentityLinkedList is used in only one place, so it's fairly simple to
> replace it with IdentityArrayList.
Stuart Marks has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/
On Wed, 15 Feb 2023 00:11:58 GMT, Stuart Marks wrote:
> IdentityLinkedList is used in only one place, so it's fairly simple to
> replace it with IdentityArrayList.
This pull request has now been integrated.
Changeset: 94de0a73
Author:Stuart Marks
URL:
https://git.open
PR for Sequenced Collections implementation.
-
Commit messages:
- Specification cleanups.
- Update spec of CopyOnWriteArrayList::reversed.
- Move AbstractViewCollection to AbstractMap.ViewCollection to avoid exposing
it publicly.
- Merge branch 'master' into JDK-8266571-Sequenced
On Tue, 8 Feb 2022 17:23:38 GMT, Stuart Marks wrote:
> PR for Sequenced Collections implementation.
I'm not convinced it's binary compatible. :-) Perhaps this particular case is,
but there are a bunch of other cases (additional subclasses, etc.) that need to
be considered.
T
On Wed, 21 Sep 2022 04:01:13 GMT, Chen Liang wrote:
>> PR for Sequenced Collections implementation.
>
> Since we added reversal to deque, can we add notes to a few Collections APIs
> like `Collections::asLifoQueue` about this newer alternative? Also on using
> `reverse` on the list view than ac
eturns null if empty.
>> So to make things consistently throwing, we'd need to add
>> `getFirst/LastEntry` and `removeFirst/LastEntry` to SequencedMap (and
>> probably get rid of some of the other methods). This would make SequencedMap
>> and probably LinkedHashMap fairly
On Tue, 8 Nov 2022 06:15:48 GMT, Srikanth Adayapalam
wrote:
>> PR for Sequenced Collections implementation.
>
> Please include the following fix for the langtools test "failures":
>
>
> diff --git a/test/langtools/tools/javac/api/TestJavacTaskScanner.java
> b/test/langtools/tools/javac/api/T
4: putMode = PUT_NORM;
>
> @stuart-marks Would it be an alternative to have an `internalPut(mode, k,
> v)` so there is no need to have an internal variable which needs to be
> read/written multiple time per operation? 🤔
Yeah, the coupling here is rather distasteful. (Otherwise kno
On Tue, 12 Apr 2022 19:55:13 GMT, Eamonn McManus wrote:
>> PR for Sequenced Collections implementation.
>
> src/java.base/share/classes/java/util/LinkedHashMap.java line 604:
>
>> 602: * @return a set view of the keys contained in this map
>> 603: */
>> 604: public SequencedSet key
On Thu, 3 Nov 2022 07:41:05 GMT, ExE Boss wrote:
>> Yeah, the coupling here is rather distasteful. (Otherwise known as a quick
>> and dirty hack.) Unfortunately the coupling between HashMap and
>> LinkedHashMap is pretty special-purposed for exactly the intended usage
>> modes (insertion-order
On Wed, 13 Apr 2022 11:53:52 GMT, ExE Boss wrote:
>> Yes. Previously compiled binaries will also throw `NoSuchMethodError` if
>> they call `super.keySet()`. Clearly these are incompatibilities; the
>> question is whether they are severe enough to warrant pursuing a different
>> approach. If yo
On Wed, 13 Apr 2022 19:08:58 GMT, Stuart Marks wrote:
>> Won’t `super.keySet()` resolve to a bridge method in that case?
>
> Oh yes, in this case it might resolve to a bridge method, and it might
> actually work. In this case. However, the compatibility matrix for covariant
On Sun, 28 Aug 2022 05:45:54 GMT, Grzegorz Piwowarek wrote:
>> PR for Sequenced Collections implementation.
>
> src/java.base/share/classes/java/util/SequencedCollection.java line 84:
>
>> 82: * the iterator() method, calls next() on it and returns the result.
>> 83: */
>> 84: defa
* in this reversed view, depending upon the implementation.
>>> 93: *
>>
>> @stuart-marks Perhaps an opportunity to spec it so that x ==
>> x.reversed().reversed() (i.e. unwrap on double-reverse)?
>
> @stuart-marks What are examples of cases where it wouldn
On Fri, 17 Mar 2023 07:30:12 GMT, ExE Boss wrote:
>> PR for Sequenced Collections implementation.
>
> src/java.base/share/classes/java/util/SequencedMap.java line 343:
>
>> 341: return new SeqEntrySet();
>> 342: }
>> 343: }
>
> Missing trailing newline:
> Suggestion:
>
> }
will fi
On Tue, 8 Feb 2022 17:23:38 GMT, Stuart Marks wrote:
> PR for Sequenced Collections implementation.
[JEP 431](https://openjdk.org/jeps/431) is now Targeted to JDK 21. Hooray! It
thus seems as good a time as any to mark this PR as ready for review. Currently
I'm focusing on get
On Tue, 8 Feb 2022 17:23:38 GMT, Stuart Marks wrote:
> PR for Sequenced Collections implementation.
(Heh, it looks like a whole bunch of old PR comments from when it was in draft
state just got replayed to the mailing lists.)
-
PR Comment: https://git.openjdk.org/jdk/pull/7
On Mon, 20 Mar 2023 23:52:11 GMT, Chen Liang wrote:
>> PR for Sequenced Collections implementation.
>
> Just curious, does sequenced collection specify if add simulates addLast if
> addition supports custom ordering? I wish to have efficient reversible batch
> addition operations available, lik
On Tue, 21 Mar 2023 12:39:18 GMT, Chen Liang wrote:
> I am interested in the optimization potential of
> `arraylist.reversed().addAll()` and similar batch operations. Though reverse
> list/deque views are a good start, I still wish to see customized
> implementations for `reversed` to perform
On Fri, 24 Mar 2023 22:26:03 GMT, Tagir F. Valeev wrote:
>> PR for Sequenced Collections implementation.
>
> Hello, Stuart!
>
> I'm really glad that this proposal progresses, and now we have a solid
> implementation draft. In general, I like it very much. You may find a couple
> of comments fr
> PR for Sequenced Collections implementation.
Stuart Marks has updated the pull request incrementally with two additional
commits since the last revision:
- More specification tweaks.
- Add simple overrides to ArrayList.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/7
> PR for Sequenced Collections implementation.
Stuart Marks has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 78 commits:
- Merge branch 'master' into JDK-8266571-SequencedCollections
- Update copyrights.
- More specifi
On Sat, 25 Mar 2023 08:19:18 GMT, RĂ©mi Forax wrote:
>> Stuart Marks has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - More specification tweaks.
>> - Add simple overrides to ArrayList.
>
&g
On Fri, 24 Mar 2023 21:28:18 GMT, Tagir F. Valeev wrote:
>> Stuart Marks has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 78 commits:
>>
>> - Merge branch 'master' into JDK-8266571-SequencedC
On Fri, 24 Mar 2023 21:35:22 GMT, Tagir F. Valeev wrote:
>> Stuart Marks has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 78 commits:
>>
>> - Merge branch 'master' into JDK-8266571-SequencedC
> PR for Sequenced Collections implementation.
Stuart Marks has updated the pull request incrementally with one additional
commit since the last revision:
Simplify handling of cached keySet, values, and entrySet views.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/7
On Wed, 29 Mar 2023 13:09:52 GMT, RĂ©mi Forax wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify handling of cached keySet, values, and entrySet views.
>
> This is taking a pers
On Wed, 29 Mar 2023 21:18:02 GMT, Chen Liang wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify handling of cached keySet, values, and entrySet views.
>
> In the JEP:
>
On Wed, 10 Sep 2025 17:33:05 GMT, Weijun Wang wrote:
>> Allow password hiding even if there is no `System.console`. A manual test is
>> included.
>
> Weijun Wang has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains three commits:
>
>
On Thu, 11 Sep 2025 17:57:57 GMT, Weijun Wang wrote:
>> Allow password hiding even if there is no `System.console`. A manual test is
>> included.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> use ByteBuffer::put for newli
On Thu, 11 Sep 2025 17:50:10 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/util/Password.java line 193:
>>
>>> 191: ba[bb.position()] = '\n';
>>> 192: }
>>> 193: return ba;
>>
>> Some random comments. This is all internal to this cla
35 matches
Mail list logo
