Fixed the java.lang.NullPointerException & tested .
@shurymury
-
Commit messages:
- 8289559 : java/awt/a11y/AccessibleJPopupMenuTest.java test fails with
java.lang.NullPointerException
Changes: https://git.openjdk.org/jdk/pull/9342/files
Webrev: https://webrevs.openjdk.org/?repo=
On Thu, 30 Jun 2022 23:58:44 GMT, lawrence.andrews wrote:
> Fixed the java.lang.NullPointerException & tested .
>
> @shurymury
This pull request has now been integrated.
Changeset: 3216d198
Author:lawrence.andrews
Committer: Phil Race
URL:
https://git.openjdk.org/jdk/commit/3216d1
On Sat, 1 Jul 2023 00:29:11 GMT, Harshitha Onkar wrote:
>> **Problem:**
>>
>> Robot erroneously produces lowercase letter when mouse is moved (manually)
>> in unison with Robot's keyEvents on MacOS. This issue was originally logged
>> by a developer of an on-screen accessibility keyboard - To
> 1) Used builder pattern
> 2) Tested AWT tests and it passed
lawrence.andrews has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 10 commits:
- Revert changes to PrintLatinCJKTest.java
- Refactor screen capture
Move creating sc
> 1) Used builder pattern
> 2) Tested AWT tests and it passed
lawrence.andrews has updated the pull request incrementally with two additional
commits since the last revision:
- Changed enableScreenCapture method name to screenCapture shorter method name
- Update full name
-
Chan
On Wed, 9 Aug 2023 21:02:37 GMT, Harshitha Onkar wrote:
>> lawrence.andrews has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Changed enableScreenCapture method name to screenCapture shorter method
>> name
>> - Update full name
>
> tes
On Thu, 10 Aug 2023 23:10:15 GMT, Alisen Chung wrote:
> Swapped order of showing frame and managing extended frame state.
src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line 1005:
> 1003: int prevWindowState = peer.getState();
> 1004: if (prevWindowState =
On Wed, 9 Aug 2023 20:55:32 GMT, lawrence.andrews wrote:
>> 1) Used builder pattern
>> 2) Tested AWT tests and it passed
>
> lawrence.andrews has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Changed enableScreenCapture method name to scre
> 1) Used builder pattern
> 2) Tested AWT tests and it passed
lawrence.andrews has updated the pull request incrementally with one additional
commit since the last revision:
Changed enableScreenCapture to screenCapture
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14094/f
On Mon, 21 Aug 2023 16:54:00 GMT, Alisen Chung wrote:
>> Swapped order of showing frame and managing extended frame state.
>
> Alisen Chung has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - test update
> - added test, updated comment
test
On Mon, 14 Aug 2023 21:00:56 GMT, Alisen Chung wrote:
>> @alisenchung
>>
>> An automated test can be created by adding Component Listener to the
>> reproducer test in JBS. The following code throws Runtime Exception if the
>> frame was visible at the original size of 200 x 200 before it was m
On Wed, 23 Aug 2023 17:42:54 GMT, Alisen Chung wrote:
>> Swapped order of showing frame and managing extended frame state.
>
> Alisen Chung has updated the pull request incrementally with four additional
> commits since the last revision:
>
> - add copyright
> - update test
> - update test
>
On Tue, 23 May 2023 02:52:03 GMT, lawrence.andrews wrote:
> 1) Used builder pattern
> 2) Tested AWT tests and it passed
This pull request has now been integrated.
Changeset: dbb788f3
Author:lawrence.andrews
Committer: Alexey Ivanov
URL:
https://git.openjdk.org/jdk/commit/dbb788f34
Both the tests demonstrates how to use the PassFailJFrame's builder pattern.
1) TrayIconScalingTest.java demonstrates how to add screen shot method
2) PrintLatinCJKTest.java demonstrates how to use PassFailJFrame's builder
pattern without screen shot method.
@aivanov-jdk
@honkar-jdk
--
On Mon, 28 Aug 2023 18:57:18 GMT, Harshitha Onkar wrote:
>> I have made the test changes to include radio button in menu and tested the
>> same and it works fine.
>
> @lawrence-andrew This test (bug8031573.java) can be a good manual test
> candidate to be re-written using the new PassFailJFrame
On Sat, 26 Aug 2023 21:11:11 GMT, lawrence.andrews wrote:
> Both the tests demonstrates how to use the PassFailJFrame's builder pattern.
> 1) TrayIconScalingTest.java demonstrates how to add screen shot method
> 2) PrintLatinCJKTest.java demonstrates how to use PassFailJFrame's builder
> patter
On Thu, 31 Aug 2023 08:02:35 GMT, Prasanta Sadhukhan
wrote:
> After the first time a JTableHeader is serialized, it no longer will
> uninstall its UI upon subsequent serializations.
> This happens for classes that use the BasicTableHeaderUI class. Any LAF that
> extends the BasicTableHeaderUI
On Thu, 31 Aug 2023 16:07:03 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/javax/swing/JTableHeader/SerializeJTableHeader.java line 47:
>>
>>> 45: ByteArrayOutputStream baos = new
>>> ByteArrayOutputStream();
>>> 46: ObjectOutputStream oos = new ObjectOutputStream(
Test was failing with "test result: Error. Parse Exception: Arguments to
`manual' option not supported: yesno"
Following are fixed
1) Removed yesno
2) Added test PassFailJFrame manual framework
3) Added SkippedException in case Printer is not configured on the test host.
4) Updated the instructi
> Test was failing with "test result: Error. Parse Exception: Arguments to
> `manual' option not supported: yesno"
> Following are fixed
> 1) Removed yesno
> 2) Used PassFailJFrame manual test framework to show the test instruction &
> allow the user to decide test execution result.
> 3) Added
On Mon, 11 Sep 2023 18:18:28 GMT, Alexey Ivanov wrote:
> Refactored timeout handling in PassFailJFrame:
>
> 1. Managing the timer and formatting the time left is inside `TimeoutHandler`
> class.
> 2. The class handles timer events and updates the label accordingly.
>
> This is implemented on t
On Wed, 13 Sep 2023 14:25:19 GMT, Alexey Ivanov wrote:
>> This enhances the `Builder` pattern added in
>> [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method
>> `testUI` which allows passing a lambda expression or a method reference to
>> create *the test UI window*.
>
ProblemListed ConsumeForModalDialogTest.java, MenuItemActivatedTest.java &
MouseModifiersUnitTest_Standard.java for windows
@prrace
-
Commit messages:
- 8317751 : ProblemList ConsumeForModalDialogTest.java,
MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for win
> ProblemListed ConsumeForModalDialogTest.java, MenuItemActivatedTest.java &
> MouseModifiersUnitTest_Standard.java for windows
>
> @prrace
lawrence.andrews has updated the pull request incrementally with one additional
commit since the last revision:
Update ProblemList.txt
Fixed the b
On Mon, 9 Oct 2023 20:14:40 GMT, lawrence.andrews wrote:
> ProblemListed ConsumeForModalDialogTest.java, MenuItemActivatedTest.java &
> MouseModifiersUnitTest_Standard.java for windows
>
> @prrace
This pull request has now been integrated.
Changeset: f40ea510
Author:lawrence.andrews <873
1) Fixed the @library regtesthelpers file path
2) Added @build PassFailJFrame
3) Added a empty line at the end of the file that was missing.
-
Commit messages:
- 8318580 : "javax/swing/MultiMonitor/MultimonVImage.java failing with Error.
Can't find library: /open/test/jdk/java/awt/
On Fri, 27 Oct 2023 23:29:19 GMT, lawrence.andrews wrote:
> 1) Fixed the @library regtesthelpers file path
> 2) Added @build PassFailJFrame
> 3) Added a empty line at the end of the file that was missing.
This pull request has now been integrated.
Changeset: e4803e0c
Author:lawrence.andrew
1) This test was failing due to yesno
test result: Error. Parse Exception: Arguments to `manual' option not
supported: yesno
2) PrintCheckboxManualTest.html file was missing
3) Added os.family since test instruction says that its a linux and solair
toolkit only test
4) Removed Sysout & TestDial
1) Fixed Parse Exception by removing yesno
test result: Error. Parse Exception: Arguments to `manual' option not
supported: yesno
2) Throw jtreg.SkippedException when printer is not configured on the test host
3) Replaced Sysout & TestDialog with ManualTestFrame, which allows to the user
to bette
Corrected the test instruction to show the popup menu on JLabel when voice over
is enabled .
@shurymury
-
Commit messages:
- 8292328 : AccessibleActionsTest.java test instruction for show popup on
JLabel did not specify shift key
Changes: https://git.openjdk.org/jdk/pull/9868/fil
Border line is seen outside round Rectangle both for JInternalFrame
backgroundShadowBorder & foregroundShadowBorder line in mac L&F.
I have circled the
On Mon, 22 Aug 2022 19:35:34 GMT, Harshitha Onkar wrote:
>> Additional position setting (TOP_LEFT_CORNER) and a method to obtain bounds
>> of test instruction frame are added to PassFailJFrame to handle positioning
>> of multiple test frames.
>>
>> In scenarios where multiple test windows migh
On Mon, 22 Aug 2022 21:20:54 GMT, lawrence.andrews wrote:
> Border line is seen outside round Rectangle both for JInternalFrame
> backgroundShadowBorder & foregroundShadowBorder line in mac L&F.
>  This test was failing due to yesno
> test result: Error. Parse Exception: Arguments to `manual' option not
> supported: yesno
> 2) PrintCheckboxManualTest.html file was missing
> 3) Added os.family since test instruction says that its a linux and solair
> toolkit only test
> 4) Removed Sys
> 1) This test was failing due to yesno
> test result: Error. Parse Exception: Arguments to `manual' option not
> supported: yesno
> 2) PrintCheckboxManualTest.html file was missing
> 3) Added os.family since test instruction says that its a linux and solair
> toolkit only test
> 4) Removed Sys
> 1) This test was failing due to yesno
> test result: Error. Parse Exception: Arguments to `manual' option not
> supported: yesno
> 2) PrintCheckboxManualTest.html file was missing
> 3) Added os.family since test instruction says that its a linux and solair
> toolkit only test
> 4) Removed Sys
> 1) Fixed Parse Exception by removing yesno
> test result: Error. Parse Exception: Arguments to `manual' option not
> supported: yesno
> 2) Throw jtreg.SkippedException when printer is not configured on the test
> host
> 3) Replaced Sysout & TestDialog with ManualTestFrame, which allows to the
> 1) This test was failing due to yesno
> test result: Error. Parse Exception: Arguments to `manual' option not
> supported: yesno
> 2) PrintCheckboxManualTest.html file was missing
> 3) Added os.family since test instruction says that its a linux and solair
> toolkit only test
> 4) Removed Sys
On Mon, 22 Aug 2022 21:20:54 GMT, lawrence.andrews wrote:
> Border line is seen outside round Rectangle both for JInternalFrame
> backgroundShadowBorder & foregroundShadowBorder line in mac L&F.
> ` instead of throwing an
> exception in `PrintAllPagesTest`. When the test is run outside of jtr
On Wed, 7 Sep 2022 22:42:35 GMT, lawrence.andrews wrote:
>> 1) Fixed Parse Exception by removing yesno
>> test result: Error. Parse Exception: Arguments to `manual' option not
>> supported: yesno
>> 2) Throw jtreg.SkippedException when printer is not configured on the test
>> host
>> 3) Replace
> 1) Fixed Parse Exception by removing yesno
> test result: Error. Parse Exception: Arguments to `manual' option not
> supported: yesno
> 2) Throw jtreg.SkippedException when printer is not configured on the test
> host
> 3) Replaced Sysout & TestDialog with ManualTestFrame, which allows to the
On Sat, 13 Aug 2022 22:44:52 GMT, lawrence.andrews wrote:
> Corrected the test instruction to show the popup menu on JLabel when voice
> over is enabled .
>
> @shurymury
This pull request has now been integrated.
Changeset: df53fa75
Author:lawrence.andrews
Committer: Alexey Ivanov
URL:
On Fri, 12 Aug 2022 23:10:01 GMT, lawrence.andrews wrote:
> 1) Fixed Parse Exception by removing yesno
> test result: Error. Parse Exception: Arguments to `manual' option not
> supported: yesno
> 2) Throw jtreg.SkippedException when printer is not configured on the test
> host
> 3) Replaced Sys
On Thu, 20 Oct 2022 08:59:20 GMT, Srinivas Mandalika
wrote:
> 8295707: Create a regression test for JDK-7184401
>
> JDK-7184401 - JDk7u6 : Missing main menu bar in Netbeans after fix for 7162144
> Above bug got introduced due to a fix for
> [JDK-7162144](https://bugs.openjdk.java.net/browse/JD
Fixed test instruction that helps the manual tester to perform actions
@shurymury
-
Commit messages:
- 8296335 : Fix accessibility manual test instruction
Changes: https://git.openjdk.org/jdk/pull/10996/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10996&range=00
Issue:
> Fixed test instruction that helps the manual tester to perform actions
>
> @shurymury
lawrence.andrews has updated the pull request incrementally with one additional
commit since the last revision:
Preserve last line
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10996/f
> Fixed test instruction that helps the manual tester to perform actions
>
> @shurymury
lawrence.andrews has updated the pull request incrementally with one additional
commit since the last revision:
Add a blank line
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10996/fil
> Fixed test instruction that helps the manual tester to perform actions
>
> @shurymury
lawrence.andrews has updated the pull request incrementally with two additional
commits since the last revision:
- Fixed the review comments
- html files with just one empty last line
-
Chang
> Fixed test instruction that helps the manual tester to perform actions
>
> @shurymury
lawrence.andrews has updated the pull request incrementally with one additional
commit since the last revision:
Fixed the review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/
> Fixed test instruction that helps the manual tester to perform actions
>
> @shurymury
lawrence.andrews has updated the pull request incrementally with one additional
commit since the last revision:
Fixed the review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/
> Fixed test instruction that helps the manual tester to perform actions
>
> @shurymury
lawrence.andrews has updated the pull request incrementally with four
additional commits since the last revision:
- Update TreeDemo.html
- Update TableDemo.html
- Update ComboBoxDemo.html
- Update Button
> Fixed test instruction that helps the manual tester to perform actions
>
> @shurymury
lawrence.andrews has updated the pull request incrementally with one additional
commit since the last revision:
Update OptionPaneDemo.html
-
Changes:
- all: https://git.openjdk.org/jdk/pull
On Fri, 4 Nov 2022 20:18:09 GMT, lawrence.andrews wrote:
> Fixed test instruction that helps the manual tester to perform actions
>
> @shurymury
This pull request has now been integrated.
Changeset: c2f76383
Author:lawrence.andrews <87324768+lawrence-and...@users.noreply.github.com>
Commit
On Tue, 8 Nov 2022 08:57:54 GMT, Naveen Narayanan wrote:
> Colocate JMenuItemSetAcceleratorTest to a regression test.
>
> This testcase will
> 1) Verify setAccelerator method of JMenuitem.
> 2) Check that the selection of a menu item in the menu bar will generate
> action by a key combination o
On Tue, 8 Nov 2022 08:57:54 GMT, Naveen Narayanan wrote:
> Colocate JMenuItemSetAcceleratorTest to a regression test.
>
> This testcase will
> 1) Verify setAccelerator method of JMenuitem.
> 2) Check that the selection of a menu item in the menu bar will generate
> action by a key combination o
On Wed, 9 Nov 2022 10:37:24 GMT, Prasanta Sadhukhan
wrote:
> Test intermittently fails in VM citing "Tree is not editing". Seems to be
> problem with mouse clicks not getting registered properly..
> Similar test test/jdk/javax/swing/JTable/6263446/bug6263446.java is not
> affected, so made the
On Fri, 11 Nov 2022 08:20:55 GMT, ravi gupta wrote:
>> This testcase Verify the content changes of a TextArea for the following
>> assertions.
>>
>> a. TextListener get invoked when the content of a TextArea gets changed.
>> b. TextListener not get invoked during text selection or when Special
On Fri, 11 Nov 2022 08:20:55 GMT, ravi gupta wrote:
>> This testcase Verify the content changes of a TextArea for the following
>> assertions.
>>
>> a. TextListener get invoked when the content of a TextArea gets changed.
>> b. TextListener not get invoked during text selection or when Special
On Mon, 7 Nov 2022 07:28:02 GMT, Srinivas Mandalika
wrote:
>> 8295707: Create a regression test for JDK-7184401
>>
>> JDK-7184401 - JDk7u6 : Missing main menu bar in Netbeans after fix for
>> 7162144
>> Above bug got introduced due to a fix for
>> [JDK-7162144](https://bugs.openjdk.java.net/b
On Fri, 16 Dec 2022 14:55:13 GMT, Alexander Zvegintsev
wrote:
> openjdk/jdk#9525 has changed behavior of PassFailJFrame.
> it doesn't call `setVisible()` from its constructor on instruction window
> anymore and some tests were not ready for that.
>
> So adding `positionTestWindow()` fixes the
On Fri, 16 Dec 2022 14:55:13 GMT, Alexander Zvegintsev
wrote:
> openjdk/jdk#9525 has changed behavior of PassFailJFrame.
> it doesn't call `setVisible()` from its constructor on instruction window
> anymore and some tests were not ready for that.
>
> So adding `positionTestWindow()` fixes the
On Fri, 16 Dec 2022 20:00:51 GMT, Alexander Zvegintsev
wrote:
>> openjdk/jdk#9525 has changed behavior of PassFailJFrame.
>> it doesn't call `setVisible()` from its constructor on instruction window
>> anymore and some tests were not ready for that.
>>
>> So adding `positionTestWindow()` fixes
On Fri, 16 Dec 2022 20:05:37 GMT, Alexander Zvegintsev
wrote:
>> openjdk/jdk#9525 has changed behavior of PassFailJFrame.
>> it doesn't call `setVisible()` from its constructor on instruction window
>> anymore and some tests were not ready for that.
>>
>> So adding `positionTestWindow()` fixes
This test needs to be executed on mac os only
@shurymury
@honkar-jdk
-
Commit messages:
- 8299044 : test/jdk/javax/swing/JComboBox/JComboBoxBorderTest.java fails on
non mac
Changes: https://git.openjdk.org/jdk/pull/11730/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=117
Test was failing with java.lang.NullPointerException due to image file
extension was specified in upper case ( GIF )
https://github.com/openjdk/jdk/blob/master/test/jdk/javax/swing/AbstractButton/5049549/bug5049549.java#L44-L50
but actually it is in smaller case ( gif )
https://github.com/ope
On Mon, 19 Dec 2022 20:55:14 GMT, Harshitha Onkar wrote:
>> This test needs to be executed on mac os only
>>
>> @shurymury
>> @honkar-jdk
>
> @lawrence-andrew Since it is manual test, I think adding that it is as
> mac-only test to the instructions would provide more clarity.
@honkar-jdk , ex
On Mon, 19 Dec 2022 19:34:21 GMT, lawrence.andrews wrote:
> This test needs to be executed on mac os only
>
> @shurymury
> @honkar-jdk
This pull request has now been integrated.
Changeset: abc12976
Author:lawrence.andrews
Committer: Harshitha Onkar
URL:
https://git.openjdk.org/jd
On Mon, 19 Dec 2022 20:20:11 GMT, lawrence.andrews wrote:
> Test was failing with java.lang.NullPointerException due to image file
> extension was specified in upper case ( GIF )
> https://github.com/openjdk/jdk/blob/master/test/jdk/javax/swing/AbstractButton/5049549/bug5049549.java#L44-L50
>
On Wed, 5 Apr 2023 11:47:06 GMT, Ravi Gupta wrote:
>> This testcase Checking whether the Component becoming the Focus Owner and
>> FocusEvent.FOCUS_GAINED will be received by the Component when the focus is
>> requested on the component using requestFocus.
>>
>> Testing:
>> Tested using Mach5(
On Thu, 13 Apr 2023 13:03:37 GMT, Dmitry Cherepanov
wrote:
> This PR suggests to move generalPrimitives array to a new static nested
> GeneralPrimitives class to eliminate the possible deadlock. The Blit class
> (and other classes that register as general primitives) calls to
> GeneralPrimiti
On Tue, 18 Apr 2023 18:55:42 GMT, Alexander Zuev wrote:
> Cleaning up and open sourcing three AWT tests
test/jdk/java/awt/Cursor/SingleColorCursorTest.java line 42:
> 40: import java.awt.image.BufferedImage;
> 41: import java.lang.reflect.InvocationTargetException;
> 42: public class SingleColo
On Tue, 18 Apr 2023 18:55:42 GMT, Alexander Zuev wrote:
> Cleaning up and open sourcing three AWT tests
All the 3 tests are new to open repo and there copy right years are different.
-
PR Comment: https://git.openjdk.org/jdk/pull/13518#issuecomment-1513670080
On Tue, 18 Apr 2023 18:55:42 GMT, Alexander Zuev wrote:
> Cleaning up and open sourcing three AWT tests
test/jdk/java/awt/Dialog/DialogAsParentOfFileDialog.java line 182:
> 180: }
> 181:
> 182: public static void main(String[] args) throws InterruptedException,
> InvocationTargetExcep
On Tue, 18 Apr 2023 18:55:42 GMT, Alexander Zuev wrote:
> Cleaning up and open sourcing three AWT tests
Set to 80-column limit where ever it required.
-
PR Comment: https://git.openjdk.org/jdk/pull/13518#issuecomment-1513737817
On Tue, 18 Apr 2023 20:12:16 GMT, Alexander Zuev wrote:
>> Cleaning up and open sourcing three AWT tests
>
> Alexander Zuev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Cosmitic change: couple of extra-long strings were reformatted to
On Fri, 21 Apr 2023 21:11:46 GMT, Alexander Zuev wrote:
> Cleaned up and stabilized four Dialog-related tests.
test/jdk/java/awt/Dialog/DialogLocationTest.java line 142:
> 140: int lastX, lastY;
> 141: String message = "Failed in componentMoved() expect:[%d,%d]"
> 142:
On Fri, 21 Apr 2023 21:11:46 GMT, Alexander Zuev wrote:
> Cleaned up and stabilized four Dialog-related tests.
test/jdk/java/awt/Dialog/ModalDialogOnNonEdt.java line 47:
> 45:
> 46: public class ModalDialogOnNonEdt {
> 47: public void start () {
Can you leave a blank line here
--
On Fri, 21 Apr 2023 21:07:32 GMT, Damon Nguyen wrote:
> This PR open sources few AWT DnD related tests
test/jdk/java/awt/dnd/NextDropActionTest/NextDropActionTest.java line 159:
> 157: }
> 158: } finally {
> 159: if (frame != null) {
frame is created with in EDT
On Fri, 21 Apr 2023 05:19:14 GMT, Tejesh R wrote:
> This open source AWT Mouse Info related tests.
test/jdk/java/awt/MouseInfo/ContainerMousePositionTest.java line 92:
> 90: throw new RuntimeException("Test failed: Container is
> overlapped by " + " child and it should be taken
On Mon, 24 Apr 2023 10:04:49 GMT, Tejesh R wrote:
>> This open source AWT Mouse Info related tests.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated
test/jdk/java/awt/MouseInfo/ContainerMousePositionTest.java line 88:
On Mon, 24 Apr 2023 14:08:24 GMT, Tejesh R wrote:
>> test/jdk/java/awt/MouseInfo/ContainerMousePositionTest.java line 88:
>>
>>> 86: EventQueue.invokeAndWait(() -> {
>>> 87: Point p = button.getLocationOnScreen();
>>> 88: xPos = p.x + button.getWidth()
On Mon, 24 Apr 2023 14:58:06 GMT, Nikita Provotorov wrote:
>> It is allowed please use transient keyword for xPos & yPos
>
> @lawrence-andrew, BTW, why `transient`? Should it be `volatile` instead?
Oh, yes, sorry I was meant to say volatile but I typed transient. Sorry for the
confusion.
-
On Mon, 24 Apr 2023 15:36:34 GMT, lawrence.andrews wrote:
>> @lawrence-andrew, BTW, why `transient`? Should it be `volatile` instead?
>
> Oh, yes, sorry I was meant to say volatile but I typed transient. Sorry for
> the confusion.
Looks good to me.
-
PR Review Comment: https://git
On Mon, 24 Apr 2023 17:39:17 GMT, Tejesh R wrote:
> Open source few AWT ScrollPane related tests.
test/jdk/java/awt/ScrollPane/ComponentScrollTest/ComponentScrollTest.java line
48:
> 46: public Frame frame;
> 47: public int count = 0;
> 48: public static void main(String[] args) th
On Thu, 4 May 2023 05:41:43 GMT, Ravi Gupta wrote:
> Write a test Check, when the top level Window is not the focused Window
> requesting for focus and becoming the Focus Owner for any Component in that
> Window checking the following
>
> 1.The Component is the Focus Owner and the Window becom
On Thu, 4 May 2023 09:56:18 GMT, Ravi Gupta wrote:
>> This testcase Checking whether the Component becoming the Focus Owner and
>> FocusEvent.FOCUS_GAINED will be received by the Component when the focus is
>> requested on the component using requestFocus.
>>
>> Testing:
>> Tested using Mach5(
1) Used builder pattern
2) Tested AWT tests and it passed
-
Commit messages:
- minor changes
- Used builder pattern for PassFailJFrame.java
- Merge branch 'master' into PassFailJFrame_Screen_Shot
- Fixed review comments
- Added screen shot functionality to PassFailJFrame.java
C
On Fri, 15 Mar 2024 15:33:30 GMT, lawrence.andrews wrote:
>> Okay. Most methods of the builder use `this.` prefix when assigning
>> something to a field.
>
> How about having a clear log button. Just an idea
> Example :
> I have a mouse event test & I am using the logArea to add all the events
On Fri, 15 Mar 2024 15:05:28 GMT, Alexey Ivanov wrote:
>> I keep it for consistency across builder methods, e.g. `screenCapture` does
>> not need to specify it either.
>
> Okay. Most methods of the builder use `this.` prefix when assigning something
> to a field.
How about having a clear log b
On Fri, 15 Mar 2024 15:42:42 GMT, Alexey Ivanov wrote:
>> 'Clear log' button calling logClear().
>
> @lawrence-andrew I can't see much value…
>
> Capturing logs by a screenshot is not something that you should ever do —
> copy the messages and paste them as text into a bug report.
>
> However,
On Tue, 30 Apr 2024 17:57:14 GMT, Harshitha Onkar wrote:
>> For the following manual test, more instructions are added as to what to
>> expect for "hide,iconify and show" vs "hide,iconify,show and restore" for
>> clarity.
>
> Harshitha Onkar has updated the pull request incrementally with one
On Tue, 28 May 2024 02:25:46 GMT, Alexander Zvegintsev
wrote:
> Some of the modal tests fail in X11 compatibility mode on Wayland, because a
> mouse click emulated with XTEST does not not cause the windows to be
> reordered.
>
> This is a known limitation because these click events do not lea
On Mon, 3 Jun 2024 12:22:53 GMT, Ravi Gupta wrote:
> This testcase checks for the following assertions for Component events:
>
> 1. When components are resized, moved, hidden and shown the respective events
> are triggered.
> 2. When the components are hidden/disabled also,the component events
On Wed, 5 Jun 2024 08:29:11 GMT, Ravi Gupta wrote:
>> This testcase checks for the following assertions for Component events:
>>
>> 1. When components are resized, moved, hidden and shown the respective
>> events are triggered.
>> 2. When the components are hidden/disabled also,the component ev
1) After the fix , I could see the test was launched.
-
Commit messages:
- 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception:
Invalid or unrecognized bugid: @
Changes: https://git.openjdk.org/jdk/pull/20057/files
Webrev: https://webrevs.openjdk.org/?repo=jd
> 1) After the fix , I could see the test was launched.
lawrence.andrews has updated the pull request incrementally with one additional
commit since the last revision:
updated the copyright
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20057/files
- new: https://git.open
On Fri, 5 Jul 2024 18:06:18 GMT, lawrence.andrews wrote:
> 1) After the fix , I could see the test was launched.
This pull request has now been integrated.
Changeset: 3733fe3a
Author:lawrence.andrews
Committer: Alexey Ivanov
URL:
https://git.openjdk.org/jdk/commit/3733fe3a207078b58
1) Replaced JApplet with JPanel
2) Tests passed before and after fix
-
Commit messages:
- Left a blank line at the end of the file
- 8328553: Get rid of JApplet in
test/jdk/sanity/client/lib/SwingSet2/src/DemoModule.java
Changes: https://git.openjdk.org/jdk/pull/20450/files
Web
On Sat, 3 Aug 2024 18:07:16 GMT, lawrence.andrews wrote:
> 1) Replaced JApplet with JPanel
> 2) Tests passed before and after fix
I can file a new ticket and work on the NPE.
-
PR Comment: https://git.openjdk.org/jdk/pull/20450#issuecomment-2282331277
1 - 100 of 122 matches
Mail list logo
