Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Thu, 29 Jan 2026 09:56:13 GMT, Thomas Stuefe wrote: >> This to support linux headless mode without X11. E.g. A headless server. > > Sorry, this keeps falling through the cracks. I opened > https://bugs.openjdk.org/browse/JDK-8376684 - I guess Alexey was snowed in. > > But I am no expert in this area; @magicus and @prrace should look at this. > > If this gets pushed, downporting it to LTSes is possible. ahem @tstuefe I was waiting for Alexey to finish testing before adding my approval, did you not see the comments by Alexey ? - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3848367244
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Wed, 4 Feb 2026 07:05:27 GMT, Thomas Devoogdt wrote: > What is the procedure to get this back ported to the LTS branches? Just open > PRs there with a reference to this one? See the guidelines for [Backporting](https://openjdk.org/guide/#backporting), and in particular [Requesting approvals for backports](https://openjdk.org/guide/#requesting-approvals-for-backports). Essentially, you create backport PRs for LTS releases and request approvals. You can look for examples at the [*jdk-updates-dev* mailing list](https://mail.openjdk.org/pipermail/jdk-updates-dev/). - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3847022323
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Thu, 29 Jan 2026 09:56:13 GMT, Thomas Stuefe wrote: >> This to support linux headless mode without X11. E.g. A headless server. > > Sorry, this keeps falling through the cracks. I opened > https://bugs.openjdk.org/browse/JDK-8376684 - I guess Alexey was snowed in. > > But I am no expert in this area; @magicus and @prrace should look at this. > > If this gets pushed, downporting it to LTSes is possible. @tstuefe What is the procedure to get this back ported to the LTS branches? Just open PRs there with a reference to this one? - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3845731350
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Thu, 13 Nov 2025 22:17:23 GMT, Thomas Devoogdt wrote: > This to support linux headless mode without X11. E.g. A headless server. @ThomasDevoogdt Your change (at version a5292aa123dfedd610bb7019b1645875a82b6ca7) is now ready to be sponsored by a Committer. - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3843781354
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Tue, 3 Feb 2026 21:18:00 GMT, Thomas Devoogdt wrote: > Thanks for the reviews and tests. I assume that merging goes automatically > now? No, you have to issue the [`/integrate` command](https://wiki.openjdk.org/spaces/SKARA/pages/56524908/Pull+Request+Commands#PullRequestCommands-/integrate). Then a [*Committer*](https://openjdk.org/bylaws#committer) will use the [`/sponsor` command](https://wiki.openjdk.org/spaces/SKARA/pages/56524908/Pull+Request+Commands#PullRequestCommands-/sponsor) to integrate the changeset. I'll happily sponsor once the test job finishes. I'll also allow some time for Phil to approve this PR. - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3843766391
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Thu, 13 Nov 2025 22:17:23 GMT, Thomas Devoogdt wrote: > This to support linux headless mode without X11. E.g. A headless server. Thanks for the reviews and tests. I assume that merging goes automatically now? - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3843732377
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Thu, 13 Nov 2025 22:17:23 GMT, Thomas Devoogdt wrote: > This to support linux headless mode without X11. E.g. A headless server. I also ran the clientlibs tests in Oracle CI. There were a few failures, they were unrelated to this fix. To play it safe, today I merged `master` into my local branch with this fix and submitted a new test job. The test job hasn't completed yet, but there are no failures so far. - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3843529266
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Thu, 13 Nov 2025 22:17:23 GMT, Thomas Devoogdt wrote: > This to support linux headless mode without X11. E.g. A headless server. I tested it in a live Ubuntu image. I installed all the dependencies except for X11 headers. The regular run of `configure` failed for me complaining about the missing X11 headers. When I passed the `--enable-headless-only` option to `configure`, it succeeded, and the build succeeded. I ran headless AWT tests, and all the tests passed. The fix for [JDK-8255785](https://bugs.openjdk.org/browse/JDK-8255785) that enabled building headless JDK without the X11 headers was reverted by [JDK-8258465](https://bugs.openjdk.org/browse/JDK-8258465) because there was a dependency on definition of the rectangle structure. The fix proposed in this PR removes that dependency by providing an alternative definition, the same one that's already used on macOS. Thus, this fix also resolves [JDK-8273258](https://bugs.openjdk.org/browse/JDK-8273258). - Marked as reviewed by aivanov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/28310#pullrequestreview-3747431493
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Fri, 30 Jan 2026 12:53:34 GMT, Alexey Ivanov wrote: >>> @ThomasDevoogdt A PR isn't announced on the mailing list until it's _ready >>> for review_ which includes a valid JBS bug. >>> >>> I suggest you write an email to build-dev and client-libs-dev mailing lists >>> to propose this change and discuss it. I haven't found an existing issue in >>> JBS for not requiring X11 libraries in headless mode. I can submit one on >>> your behalf. >>> >>> If I have time, I'll test your patch locally and run it in the Oracle CI. >> >> All our build systems have X11. So a test build there doesn't prove much, >> and also it can easily regress. > >> > If I have time, I'll test your patch locally and run it in the Oracle CI. >> >> All our build systems have X11. So a test build there doesn't prove much, >> and also it can easily regress. > > This is why I'm going to use a VM which doesn't have X11 headers installed. > >> is that a reason to not merge this kind of code? > > I think it's a good change. Looking at the history at which @dholmes-ora > pointed, building headless JDK without X11 was supported, but it has become > broken again. I am fine with this (once @aivanov-jdk has done the test build). I am just pointing out that it has apparently regressed before so could regress again because this configuration is not part of our testing. - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3837497493
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Thu, 13 Nov 2025 22:17:23 GMT, Thomas Devoogdt wrote: > This to support linux headless mode without X11. E.g. A headless server. >From a build point of view, this looks fine. Someone from client will need to >review it too. - Marked as reviewed by erikj (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/28310#pullrequestreview-3728768954
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Thu, 29 Jan 2026 22:32:46 GMT, Phil Race wrote: > > If I have time, I'll test your patch locally and run it in the Oracle CI. > > All our build systems have X11. So a test build there doesn't prove much, and > also it can easily regress. This is why I'm going to use a VM which doesn't have X11 headers installed. > is that a reason to not merge this kind of code? I think it's a good change. Looking at the history at which @dholmes-ora pointed, building headless JDK without X11 was supported, but it has become broken again. - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3823612106
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Thu, 29 Jan 2026 21:46:17 GMT, David Holmes wrote: >> This to support linux headless mode without X11. E.g. A headless server. > > I just updated the JBS issue with a couple of links. This is certainly not a > new issue and there is an existing RFE to deal with the source code > dependencies on X11. @dholmes-ora @aivanov-jdk @prrace I can see that there are duplicated issues on this topic, and that regression is easy without proper testing, but is that a reason to not merge this kind of code? If new regressions occurs, then chances are big that someone will notice them, and push a new fix for it. Yes, buildroot is a bit behind upstream JDK, but at least there we will see it. https://github.com/buildroot/buildroot/commit/3dd73c30d387b235589275bad729e66619d062c3 Other distributions might also be interested. Are there actions needed on my side? Because that is not clear out of the reviews. - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3822314701
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Thu, 29 Jan 2026 21:18:42 GMT, Thomas Devoogdt wrote: >> Sorry, this keeps falling through the cracks. I opened >> https://bugs.openjdk.org/browse/JDK-8376684 - I guess Alexey was snowed in. >> >> But I am no expert in this area; @magicus and @prrace should look at this. >> >> If this gets pushed, downporting it to LTSes is possible. > >> Sorry, this keeps falling through the cracks. I opened >> https://bugs.openjdk.org/browse/JDK-8376684 - I guess Alexey was snowed in. >> >> But I am no expert in this area; @magicus and @prrace should look at this. >> >> If this gets pushed, downporting it to LTSes is possible. > > Thanks for creating the issue. I've updated the commits with the issue tag. > @ThomasDevoogdt A PR isn't announced on the mailing list until it's _ready > for review_ which includes a valid JBS bug. > > I suggest you write an email to build-dev and client-libs-dev mailing lists > to propose this change and discuss it. I haven't found an existing issue in > JBS for not requiring X11 libraries in headless mode. I can submit one on > your behalf. > > If I have time, I'll test your patch locally and run it in the Oracle CI. All our build systems have X11. So a test build there doesn't prove much, and also it can easily regress. - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3820768881
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Thu, 29 Jan 2026 21:18:42 GMT, Thomas Devoogdt wrote: >> Sorry, this keeps falling through the cracks. I opened >> https://bugs.openjdk.org/browse/JDK-8376684 - I guess Alexey was snowed in. >> >> But I am no expert in this area; @magicus and @prrace should look at this. >> >> If this gets pushed, downporting it to LTSes is possible. > >> Sorry, this keeps falling through the cracks. I opened >> https://bugs.openjdk.org/browse/JDK-8376684 - I guess Alexey was snowed in. >> >> But I am no expert in this area; @magicus and @prrace should look at this. >> >> If this gets pushed, downporting it to LTSes is possible. > > Thanks for creating the issue. I've updated the commits with the issue tag. @ThomasDevoogdt Please, *do not force-push any more*. Instead, pull changes from upstream master and *merge* master into your branch. Force-pushing invalidates comments left in the code review. - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3820709314
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Thu, 13 Nov 2025 22:17:23 GMT, Thomas Devoogdt wrote: > This to support linux headless mode without X11. E.g. A headless server. This looks like a regression then. [JDK-8255785](https://bugs.openjdk.org/browse/JDK-8255785) made it possible, see https://github.com/openjdk/jdk/commit/f97ec359 - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3820700275
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Thu, 13 Nov 2025 22:17:23 GMT, Thomas Devoogdt wrote: > This to support linux headless mode without X11. E.g. A headless server. I just updated the JBS issue with a couple of links. This is certainly not a new issue and there is an existing RFE to deal with the source code dependencies on X11. - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3820573064
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Fri, 5 Dec 2025 11:46:36 GMT, Thomas Stuefe wrote: >> This to support linux headless mode without X11. E.g. A headless server. > > ping @magicus @tstuefe @magicus ping ... And is it possible that someone already create an official issue number for it, so that I can finish all the formal stuff? > Sorry, this keeps falling through the cracks. I opened > https://bugs.openjdk.org/browse/JDK-8376684 - I guess Alexey was snowed in. > > But I am no expert in this area; @magicus and @prrace should look at this. > > If this gets pushed, downporting it to LTSes is possible. Thanks for creating the issue. I've updated the commits with the issue tag. - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3638535424 PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3820397618
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Mon, 5 Jan 2026 20:36:40 GMT, Alexey Ivanov wrote: >> Hi all, the buildroot people have merged this functionality upstream >> (https://github.com/buildroot/buildroot/commit/3dd73c30d387b235589275bad729e66619d062c3). >> Is it also possible to handle this PR here? >> >> @tstuefe @magicus > > @ThomasDevoogdt A PR isn't announced on the mailing list until it's *ready > for review* which includes a valid JBS bug. > > I suggest you write an email to build-dev and client-libs-dev mailing lists > to propose this change and discuss it. I haven't found an existing issue in > JBS for not requiring X11 libraries in headless mode. I can submit one on > your behalf. > > If I have time, I'll test your patch locally and run it in the Oracle CI. @aivanov-jdk ping - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3769989683
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Mon, 5 Jan 2026 12:59:31 GMT, Thomas Devoogdt wrote: >> This to support linux headless mode without X11. E.g. A headless server. > > Hi all, the buildroot people have merged this functionality upstream > (https://github.com/buildroot/buildroot/commit/3dd73c30d387b235589275bad729e66619d062c3). > Is it also possible to handle this PR here? > > @tstuefe @magicus > @ThomasDevoogdt A PR isn't announced on the mailing list until it's *ready > for review* which includes a valid JBS bug. > > I suggest you write an email to build-dev and client-libs-dev mailing lists > to propose this change and discuss it. I haven't found an existing issue in > JBS for not requiring X11 libraries in headless mode. I can submit one on > your behalf. @aivanov-jdk Yes, please do so! > If I have time, I'll test your patch locally and run it in the Oracle CI. Yeah, sorry for all the spam, but I really really don't know how to get any attention here. I simply don't understand how to file a bug without account, how to announce a change and so on. So every little help is much appreciated! Thx! - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3712135725
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Mon, 5 Jan 2026 12:59:31 GMT, Thomas Devoogdt wrote: >> This to support linux headless mode without X11. E.g. A headless server. > > Hi all, the buildroot people have merged this functionality upstream > (https://github.com/buildroot/buildroot/commit/3dd73c30d387b235589275bad729e66619d062c3). > Is it also possible to handle this PR here? > > @tstuefe @magicus @ThomasDevoogdt A PR isn't announced on the mailing list until it's *ready for review* which includes a valid JBS bug. I suggest you write an email to build-dev and client-libs-dev mailing lists to propose this change and discuss it. I haven't found an existing issue in JBS for not requiring X11 libraries in headless mode. I can submit one on your behalf. If I have time, I'll test your patch locally and run it in the Oracle CI. - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3712001940
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Thu, 13 Nov 2025 22:17:23 GMT, Thomas Devoogdt wrote: > This to support linux headless mode without X11. E.g. A headless server. ping @magicus Sorry, this keeps falling through the cracks. I opened https://bugs.openjdk.org/browse/JDK-8376684 - I guess Alexey was snowed in. But I am no expert in this area; @magicus and @prrace should look at this. If this gets pushed, downporting it to LTSes is possible. - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3616561369 PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3816620358
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Fri, 14 Nov 2025 18:39:55 GMT, Thomas Devoogdt wrote: >> @robilad will handle your OCA when he is available. >> >> For the jbs issue, you need to ask someone with jbs account to create the >> issue for you. > >> @robilad will handle your OCA when he is available. >> >> For the jbs issue, you need to ask someone with jbs account to create the >> issue for you. > > @zhaosongzs And who is someone? I'm not affiliated with oracle, I don't know > who to address. Ideally I could just leave it from here, and having someone > who picks this up for me. @ThomasDevoogdt I recommend you read the OpenJDK Developers' guide, particularly [this section on proposing changes to the OpenJDK code](https://openjdk.org/guide/#things-to-consider-before-proposing-changes-to-openjdk-code). The mailing list on which to discuss this proposed change is [[email protected]](mailto:[email protected]). As for the OCA, if you work for an employer who is already an OCA signatory, which is what entering `/covered` means, no action is needed from you at this time. If you don't, you need to follow the instructions in the OpenJDK Developer's Guide to sign it as an individual contributor, and enter `/signed` in a comment. Either way, you will need to wait for your OCA to be processed. - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3534908960
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Thu, 13 Nov 2025 22:17:23 GMT, Thomas Devoogdt wrote: > This to support linux headless mode without X11. E.g. A headless server. @robilad will handle your OCA when he is available. For the jbs issue, you need to ask someone with jbs account to create the issue for you. - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3533868907
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Fri, 14 Nov 2025 17:42:47 GMT, Zhao Song wrote: > @robilad will handle your OCA when he is available. > > For the jbs issue, you need to ask someone with jbs account to create the > issue for you. @zhaosongzs And who is someone? I'm not affiliated with oracle, I don't know who to address. Ideally I could just leave it from here, and having someone who picks this up for me. - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3534081614
Re: RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
On Thu, 13 Nov 2025 22:17:23 GMT, Thomas Devoogdt wrote: > This to support linux headless mode without X11. E.g. A headless server. > Hi @ThomasDevoogdt, welcome to this OpenJDK project and thanks for > contributing! > > We do not recognize you as > [Contributor](https://openjdk.java.net/bylaws#contributor) and need to ensure > you have signed the Oracle Contributor Agreement (OCA). If you have not > signed the OCA, please follow [the > instructions](https://oca.opensource.oracle.com/). Please fill in your GitHub > username in the "Username" field of the application. Once you have signed the > OCA, please let us know by writing `/signed` in a comment in this pull > request. > > If you already are an OpenJDK > [Author](https://openjdk.java.net/bylaws#author), > [Committer](https://openjdk.java.net/bylaws#committer) or > [Reviewer](https://openjdk.java.net/bylaws#reviewer), please click > [here](https://bugs.openjdk.java.net/secure/CreateIssue.jspa?pid=11300&issuetype=1) > to open a new issue so that we can record that fact. Please use "Add GitHub > user ThomasDevoogdt" as summary for the issue. > > If you are contributing this work on behalf of your employer and your > employer has signed the OCA, please let us know by writing `/covered` in a > comment in this pull request. @zhaosongzs I don't know who to address here. I can't create an issue for this PR as I don't have an OpenJDK account. I'm also awaiting OCA. Hi all, the buildroot people have merged this functionality upstream (https://github.com/buildroot/buildroot/commit/3dd73c30d387b235589275bad729e66619d062c3). Is it also possible to handle this PR here? @tstuefe @magicus - PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3531547157 PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3531574662 PR Comment: https://git.openjdk.org/jdk/pull/28310#issuecomment-3710324642
RFR: 8376684: Compile OpenJDK in headless mode without required X11 libraries
This to support linux headless mode without X11. E.g. A headless server. - Commit messages: - 8376684: doc: fix X11 description when compiling headless - 8376684: autoconf: libraries: drop the need for X11 in headless mode - 8376684: awt: fix HEADLESS compilation without X11 Changes: https://git.openjdk.org/jdk/pull/28310/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=28310&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8376684 Stats: 30 lines in 5 files changed: 14 ins; 5 del; 11 mod Patch: https://git.openjdk.org/jdk/pull/28310.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/28310/head:pull/28310 PR: https://git.openjdk.org/jdk/pull/28310
